( )⚙ D9206 posix: avoid a leaked file descriptor in a unix domain socket exception case

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9206

posix: avoid a leaked file descriptor in a unix domain socket exception case
ClosedPublic

Authored by mharbison72 on Oct 14 2020, 12:24 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG87c35b5a14eb: posix: avoid a leaked file descriptor in a unix domain socket exception case

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Oct 14 2020, 12:24 PM
pulkit accepted this revision.Oct 15 2020, 8:06 AM
This revision is now accepted and ready to land.Oct 15 2020, 8:06 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/posix.py (18 lines)

Diff 23219

mercurial/posix.py

def bindunixsocket(sock, path): def bindunixsocket(sock, path):
"""Bind the UNIX domain socket to the specified path""" """Bind the UNIX domain socket to the specified path"""
# use relative path instead of full path at bind() if possible, since # use relative path instead of full path at bind() if possible, since
# AF_UNIX path has very small length limit (107 chars) on common # AF_UNIX path has very small length limit (107 chars) on common
# platforms (see sys/un.h) # platforms (see sys/un.h)
dirname, basename = os.path.split(path) dirname, basename = os.path.split(path)
bakwdfd = None bakwdfd = None
try:
if dirname: if dirname:
bakwdfd = os.open(b'.', os.O_DIRECTORY) bakwdfd = os.open(b'.', os.O_DIRECTORY)
os.chdir(dirname) os.chdir(dirname)
sock.bind(basename) sock.bind(basename)
if bakwdfd: if bakwdfd:
os.fchdir(bakwdfd) os.fchdir(bakwdfd)
finally:
if bakwdfd:
os.close(bakwdfd) os.close(bakwdfd)