Page MenuHomePhabricator

clonebundles: move a bundle of clone bundle related code to a new module
ClosedPublic

Authored by marmoute on Oct 14 2020, 7:34 PM.

Details

Summary

In the process on general clone bundle automatically, we need to make some
function available more widely. This is a good opportunity to extract a
significant amount of code from mercurial.exchange into a new
mercurial.bundlecaches. This make mercurial.exchange move under the 3K line
range (hooray…).

The module is called bundlecaches because I expect it to be eventually useful
for more than just clone bundle (like pull bunbles).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 14 2020, 7:34 PM
pulkit added a subscriber: pulkit.Oct 15 2020, 8:16 AM
pulkit added inline comments.
tests/test-pull-bundle.t
55 ↗(On Diff #23209)

seems like this and next one are unrelated change.

Ha yes, they sneaking in while debugging.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

Can you send a follow-up to mention the API change in relnotes/next? (I've said before that I'm skeptical that anyone reads the list of API changes, but I think the consensus has been to document it.)