Page MenuHomePhabricator

errors: restructure formatparse() to clarify conditions a bit
ClosedPublic

Authored by martinvonz on Fri, Nov 20, 7:24 PM.

Details

Summary

The similar list will be calculated only for
error.UnknownIdentifier. It was then printed only if `inst.location
is None`, which is true for that exception type, but it's an indirect
condition to rely on.

Also, it looked from the code like it could both report similarities
and print a hint. That would be a little awkward because the
similarity report looks similar to the hint (both are printed within
parentheses). I also added a elif to clarify that. I plan to
refactor this more coming patches so the similarity report actually is
a hint.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.