Page MenuHomePhabricator

errors: move similarity_hint() to error module
ClosedPublic

Authored by martinvonz on Fri, Nov 20, 7:24 PM.

Details

Summary

I want to be able to reuse it from UnknownIdentifier's constructor.

Moving it results in a new import of difflib in the error
module. There was a comment at the top of error.py saying "Do not
import anything but pycompat here, please", which was added (except
for the "pycompat" bit) in 08cabecfa8a8 (errors: move revlog errors,
2009-01-11). I don't know the reason for the comment. I'm guessing the
point was to not make the module depend on other Mercurial modules. If
that was it, then importing difflib should be fine.

Sorry about the churn (I moved this code from the dispatch module to
the scmutil module very recently).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.