This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9523

debugdiscovery: clarify internal key name in debugobsolete
ClosedPublic

Authored by marmoute on Dec 5 2020, 9:31 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Summary

They were probably clear when they got added initially but with more key around,
they gain to be clearer.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Dec 5 2020, 9:31 AM

initial sent before test run (refresh post test run imminent)

baymax updated this revision to Diff 24044.Dec 5 2020, 10:59 AM
pulkit accepted this revision.Dec 6 2020, 6:48 AM
pulkit added a subscriber: pulkit.

OOC, what does nb means in all these nb-*?

This revision is now accepted and ready to land.Dec 6 2020, 6:48 AM
Alphare accepted this revision.Dec 14 2020, 5:02 AM
Alphare added a subscriber: Alphare.
In D9523#143335, @pulkit wrote:

OOC, what does nb means in all these nb-*?

I'm assuming "number". :)

pulkit added a comment.Dec 18 2020, 2:56 PM

IIRC, a similar patch to this was also pushed. This needs to be abandoned or closed.

marmoute closed this revision.Dec 22 2020, 3:19 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/debugcommands.py (44 lines)

Diff 24044

mercurial/debugcommands.py

# compute all statistics # compute all statistics
common = set(common) common = set(common)
rheads = set(hds) rheads = set(hds)
lheads = set(repo.heads()) lheads = set(repo.heads())
data = {} data = {}
data[b'elapsed'] = t.elapsed data[b'elapsed'] = t.elapsed
data[b'nb-common'] = len(common) data[b'nb-common'] = len(common)
data[b'nb-common-local'] = len(common & lheads) data[b'nb-common-head-local'] = len(common & lheads)
data[b'nb-common-remote'] = len(common & rheads) data[b'nb-common-head-remote'] = len(common & rheads)
data[b'nb-common-both'] = len(common & rheads & lheads) data[b'nb-common-head-both'] = len(common & rheads & lheads)
data[b'nb-local'] = len(lheads) data[b'nb-head-local'] = len(lheads)
data[b'nb-local-missing'] = data[b'nb-local'] - data[b'nb-common-local'] data[b'nb-head-local-missing'] = (
data[b'nb-remote'] = len(rheads) data[b'nb-head-local'] - data[b'nb-common-head-local']
data[b'nb-remote-unknown'] = data[b'nb-remote'] - data[b'nb-common-remote'] )
data[b'nb-head-remote'] = len(rheads)
data[b'nb-head-remote-unknown'] = (
data[b'nb-head-remote'] - data[b'nb-common-head-remote']
)
data[b'nb-revs'] = len(repo.revs(b'all()')) data[b'nb-revs'] = len(repo.revs(b'all()'))
data[b'nb-revs-common'] = len(repo.revs(b'::%ln', common)) data[b'nb-revs-common'] = len(repo.revs(b'::%ln', common))
data[b'nb-revs-missing'] = data[b'nb-revs'] - data[b'nb-revs-common'] data[b'nb-revs-missing'] = data[b'nb-revs'] - data[b'nb-revs-common']
# display discovery summary # display discovery summary
ui.writenoi18n(b"elapsed time: %(elapsed)f seconds\n" % data) ui.writenoi18n(b"elapsed time: %(elapsed)f seconds\n" % data)
ui.writenoi18n(b"heads summary:\n") ui.writenoi18n(b"heads summary:\n")
ui.writenoi18n(b" total common heads: %(nb-common)9d\n" % data) ui.writenoi18n(b" total common heads: %(nb-common)9d\n" % data)
ui.writenoi18n(b" also local heads: %(nb-common-local)9d\n" % data) ui.writenoi18n(b" also local heads: %(nb-common-head-local)9d\n" % data)
ui.writenoi18n(b" also remote heads: %(nb-common-remote)9d\n" % data) ui.writenoi18n(
ui.writenoi18n(b" both: %(nb-common-both)9d\n" % data) b" also remote heads: %(nb-common-head-remote)9d\n" % data
ui.writenoi18n(b" local heads: %(nb-local)9d\n" % data) )
ui.writenoi18n(b" common: %(nb-common-local)9d\n" % data) ui.writenoi18n(b" both: %(nb-common-head-both)9d\n" % data)
ui.writenoi18n(b" missing: %(nb-local-missing)9d\n" % data) ui.writenoi18n(b" local heads: %(nb-head-local)9d\n" % data)
ui.writenoi18n(b" remote heads: %(nb-remote)9d\n" % data) ui.writenoi18n(b" common: %(nb-common-head-local)9d\n" % data)
ui.writenoi18n(b" common: %(nb-common-remote)9d\n" % data) ui.writenoi18n(
ui.writenoi18n(b" unknown: %(nb-remote-unknown)9d\n" % data) b" missing: %(nb-head-local-missing)9d\n" % data
)
ui.writenoi18n(b" remote heads: %(nb-head-remote)9d\n" % data)
ui.writenoi18n(
b" common: %(nb-common-head-remote)9d\n" % data
)
ui.writenoi18n(
b" unknown: %(nb-head-remote-unknown)9d\n" % data
)
ui.writenoi18n(b"local changesets: %(nb-revs)9d\n" % data) ui.writenoi18n(b"local changesets: %(nb-revs)9d\n" % data)
ui.writenoi18n(b" common: %(nb-revs-common)9d\n" % data) ui.writenoi18n(b" common: %(nb-revs-common)9d\n" % data)
ui.writenoi18n(b" missing: %(nb-revs-missing)9d\n" % data) ui.writenoi18n(b" missing: %(nb-revs-missing)9d\n" % data)
if ui.verbose: if ui.verbose:
ui.writenoi18n( ui.writenoi18n(
b"common heads: %s\n" % b" ".join(sorted(short(n) for n in common)) b"common heads: %s\n" % b" ".join(sorted(short(n) for n in common))
) )