Page MenuHomePhabricator

debugdiscovery: display the number of roundtrip used
ClosedPublic

Authored by marmoute on Dec 11 2020, 6:55 AM.

Details

Summary

This is a good metric of the complexity of a discovery process.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 11 2020, 6:55 AM
marmoute planned changes to this revision.Dec 11 2020, 7:01 AM

(test are still running)

marmoute requested review of this revision.Dec 11 2020, 8:20 AM

Test are fine.

This says it was updated, but phabricator did not update it.

https://foss.heptapod.net/octobus/mercurial-devel/-/jobs/132899

Kwan added a subscriber: Kwan.Dec 11 2020, 8:38 AM

Test are fine.
This says it was updated, but phabricator did not update it.
https://foss.heptapod.net/octobus/mercurial-devel/-/jobs/132899

If the diff content is the same phabsend will skip creating a new identical phab diff and will only do differential.setdiffproperty calls to update the metadata i.e. commit hash, shown in the commits tab. Changes to that metadata don't show up in the DREV log, but the shown short-hash 18571fd0b6ae matches the one in that job log. Additionally I can see baymax making the expected two setdiffproperty calls at 12:28, a minute after that job started.

pulkit accepted this revision.Dec 12 2020, 2:06 AM
This revision is now accepted and ready to land.Dec 12 2020, 2:06 AM
This revision was automatically updated to reflect the committed changes.