Page MenuHomePhabricator

copies: properly match result during changeset centric copy tracing
ClosedPublic

Authored by marmoute on Dec 14 2020, 6:17 AM.

Details

Summary

By filtering "during" the iteration we were excluding rename information that
were not in the matched set but that file served as base information for the
matched set.

We now do all copy tracing matching at the end of the process to ensure we raise
proper result.

If we were aggregating information top down instead of bottom up we could do
filtering during processing. However, we don't.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Dec 14 2020, 6:17 AM
baymax updated this revision to Diff 24249.Dec 14 2020, 9:15 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 24362.Dec 17 2020, 3:53 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Dec 18 2020, 7:42 AM
This revision is now accepted and ready to land.Dec 18 2020, 7:42 AM
baymax updated this revision to Diff 24384.Dec 18 2020, 8:40 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)