This is an archive of the discontinued Mercurial Phabricator instance.

copies: deal with the "same revision" special case earlier
ClosedPublic

Authored by marmoute on Dec 14 2020, 6:18 AM.

Details

Summary

This can happens a lot in case of deletion so we better deal with it early.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Dec 14 2020, 6:18 AM
baymax updated this revision to Diff 24256.Dec 14 2020, 9:15 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 24369.Dec 17 2020, 3:53 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit added a subscriber: pulkit.Dec 18 2020, 7:48 AM
pulkit added inline comments.
mercurial/copies.py
490

This comment seems to be misplaced now.

baymax updated this revision to Diff 24391.Dec 18 2020, 8:40 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added inline comments.Dec 18 2020, 9:07 AM
mercurial/copies.py
490

Not really, but the formatting is strange. I am sending an update (but that whole code is fully replaced soon after anyway.

baymax updated this revision to Diff 24396.Dec 18 2020, 9:07 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 24411.Dec 18 2020, 9:42 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 24450.

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Dec 28 2020, 3:12 AM
This revision is now accepted and ready to land.Dec 28 2020, 3:12 AM