This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9604

setup: exclude the git extension from py2 builds
ClosedPublic

Authored by mharbison72 on Dec 14 2020, 7:37 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3158522085f0: setup: exclude the git extension from py2 builds
Summary

This can't be built on Windows with the py2 compiler, and while old versions can
be installed via pip on Linux, I can't get the tests to run (even with py3.8)
using pygit2 0.28.2. Some manually run commands work, and others spew stack
traces that don't occur with the current 1.4.0 release using py3.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Dec 14 2020, 7:37 PM
pulkit accepted this revision.Dec 17 2020, 5:50 AM
This revision is now accepted and ready to land.Dec 17 2020, 5:50 AM
mharbison72 added a commit: rHG3158522085f0: setup: exclude the git extension from py2 builds.Dec 17 2020, 6:57 AM
Closed by commit rHG3158522085f0: setup: exclude the git extension from py2 builds (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msetup.py (7 lines)

Diff 24273

setup.py

'hgext.lfs', 'hgext.lfs',
'hgext.narrow', 'hgext.narrow',
'hgext.remotefilelog', 'hgext.remotefilelog',
'hgext.zeroconf', 'hgext.zeroconf',
'hgext3rd', 'hgext3rd',
'hgdemandimport', 'hgdemandimport',
] ]
# The pygit2 dependency dropped py2 support with the 1.0 release in Dec 2019.
# Prior releases do not build at all on Windows, because Visual Studio 2008
# doesn't understand C 11. Older Linux releases are buggy.
if sys.version_info[0] == 2:
packages.remove('hgext.git')
for name in os.listdir(os.path.join('mercurial', 'templates')): for name in os.listdir(os.path.join('mercurial', 'templates')):
if name != '__pycache__' and os.path.isdir( if name != '__pycache__' and os.path.isdir(
os.path.join('mercurial', 'templates', name) os.path.join('mercurial', 'templates', name)
): ):
packages.append('mercurial.templates.%s' % name) packages.append('mercurial.templates.%s' % name)
if sys.version_info[0] == 2: if sys.version_info[0] == 2:
packages.extend( packages.extend(