This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9626

branchmap: micro-optimize branchinfo
ClosedPublic

Authored by joerg.sonnenberger on Dec 17 2020, 7:30 AM.

Details

Reviewers
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHG2607a9346398: branchmap: micro-optimize branchinfo
Summary

changelogrevision() is supposed to be used if not all data of
changelog.read is used. This is the case here as only the extra field is
used. This also improves extensibility as at least hgext.git doesn't
implement changelog.read.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute added a subscriber: marmoute.Dec 17 2020, 8:21 AM

You description mention micro-optimisation, but I don't see any number. What's the performance impact of that ?

joerg.sonnenberger added a comment.Dec 17 2020, 8:31 AM

changelog.read nowadays is literally changelog.changelogrevision followed by creating a tuple from its parts. So this step just skips creating the tuple with unnecessary elements.

marmoute accepted this revision.Jan 8 2021, 11:04 AM
pulkit accepted this revision.Jan 9 2021, 5:04 AM
This revision is now accepted and ready to land.Jan 9 2021, 5:04 AM
joerg.sonnenberger added a commit: rHG2607a9346398: branchmap: micro-optimize branchinfo.Jan 9 2021, 6:12 AM
Closed by commit rHG2607a9346398: branchmap: micro-optimize branchinfo (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (2 lines)

Diff 24686

mercurial/changelog.py

text, transaction, len(self), p1, p2, sidedata=sidedata, flags=flags text, transaction, len(self), p1, p2, sidedata=sidedata, flags=flags
) )
def branchinfo(self, rev): def branchinfo(self, rev):
"""return the branch name and open/close state of a revision """return the branch name and open/close state of a revision
This function exists because creating a changectx object This function exists because creating a changectx object
just to access this is costly.""" just to access this is costly."""
extra = self.read(rev)[5] extra = self.changelogrevision(rev).extra
return encoding.tolocal(extra.get(b"branch")), b'close' in extra return encoding.tolocal(extra.get(b"branch")), b'close' in extra
def _nodeduplicatecallback(self, transaction, node): def _nodeduplicatecallback(self, transaction, node):
# keep track of revisions that got "re-added", eg: unbunde of know rev. # keep track of revisions that got "re-added", eg: unbunde of know rev.
# #
# We track them in a list to preserve their order from the source bundle # We track them in a list to preserve their order from the source bundle
duplicates = transaction.changes.setdefault(b'revduplicates', []) duplicates = transaction.changes.setdefault(b'revduplicates', [])
duplicates.append(self.rev(node)) duplicates.append(self.rev(node))