mercurial/changelog.py
609–610	Hm, is this unrelated change?

mercurial/changelog.py
609–610	Partially, I discovered in the next change that `hgext.git` doesn't expose `read()` and it was easier to do it earlier. I can pull it out into a separate commit as it is also a micro-optimisation.

mercurial/changelog.py
609–610	Yes please do.

mercurial/changelog.py
609–610	Done in D9626.

mercurial/branchmap.py
739	Hm, shouldn't this be `b'\0' * (max(...) - rbccur)`?
mercurial/bundle2.py
2481–2484	Better to mention upto which mercurial version the part was used and what recent versions do.
mercurial/localrepo.py
1992	We can get the node from changsetrevision, hence no need to pass it separately. minor name nit: we can call it `regitser_new_changeset`, the extra new will make it more obvious. Else we will require some documentation for this function. How about not making this a method on localrepo object? Having a normal function will help extensions wrap it easily.

mercurial/branchmap.py
739	The goal is to have room to grow for the next change to avoid quadratic resizing. If we need to resize, double the total size. The max size is to cheaply avoid a few iterations for the first few revisions. I've added a comment to make that clear.
mercurial/localrepo.py
1992	It's passed in to avoid the extra lookup and parsing for the important case of bundle operations. This means a minor penalty for commit, but it makes a measurable difference for the other cases. IMO "register" already implies that it is something new. I can add a few words in the interface definition though. Both work for me, no opinion yet on what is less effort for extensions.

mercurial/branchmap.py
709–721	That signature change is weird. we end up doing an extra lookup for nodeid we end up exposing implementation details about extra to code that did not needed it before. I don't understand why we need to shift responsability here and have the branch cache care about this.
740–742	In the comment, I seems mention of resizing double the size. But I don't see this happening in final code. Am I missing something ?
mercurial/changegroup.py
328	Why not simply pass the revision number to the API and let lower lever create the changelogrevision if they need it ?
mercurial/interfaces/repository.py
1644–1650	new naming allow this to be `register_changeset`, we should probably use that. WE should probably introduce this API in a different changeset to simplify the discussion around it.
1647–1648	What about the cache the latest `changelogrevision` accessed to make this free and help in other cases ?

mercurial/branchmap.py
709–721	I think redundant keys are an interface bug. The `node` was available for all, so at least `onchangelog` in `changegroup.py` would have to do a lookup anyway. For the `commit` caller it would mean shuffling things around a bit. I'll check the extra logic here again, it's been inconsistent across the code base. This is a bit of a left over from earlier iterations, but it can likely be made tighter and simpler now.
740–742	Extending by requiredsize will normally double the size, except when it was sparse before. In that case the gap will count toward to extension, which seems a reasonable compromise.
mercurial/changegroup.py
328	`readfiles` does the expensive part of creating the changelogrevision already. Not having to process the text twice makes a noticable difference. Note that we don't have the revision number here.
mercurial/interfaces/repository.py
1644–1650	I'm not attached to the name. The other concern was if it should be function on the module scope to allow easier monkey patching. Not sure if that question warrants splitting the change.
1647–1648	I tried adding a cache for the last `changelogrevision`, but it turned out to be more expensive than shuffling things around a bit here. See the remark about `readfiles` earlier, which is the primarily time sink right now.

mercurial/branchmap.py
709–721	The extra logic is essentially what `changelog.branchinfo` does. D9603 refactors that to put it into `revbranchcache` as the only consumer in core. I've kept it for the moment since topics interacts with this code and would break.

mercurial/branchmap.py
709–721	My main concerns is responsibility and implementation details leaking into a simple cache. Could we have the extra-extraction done in the register_changeset method itself ? or probably better, putting them on changelogrevision since it is the one responsible for the details of the data access.
709–721	Both `changegroup` and `commit` application should have a revision number handy (that just the size of the revlog before creating the changeset). Revision number are much more efficient that nodeid overall. I would much prefer this kind of low level API to standardize on using them.
740–742	I get it now. I don't know if it me being tired of the code being a bit too sneaky. but it might be worth having some explicit arithmetic or a clarification comment to highlight that the operation result in a array that is "current_size + currently needed size" leading to (about) a ×2 size increase.
mercurial/interfaces/repository.py
1644–1650	Wrapping of repository level method is a common operation in extension. That is probably a good place to put it. (And also a place because they are too many method on localrepo… but these one is not a too bad fit in my opinion.) The motivation to split the change is also about making the first half easier to land sooner, and to avoid mixing discussion on two different topic. That is not a requirement, but it might help.
1647–1648	could we cache the result of readfiles ? to reuse it at that time ?

mercurial/branchmap.py
709–721	I've moved the extra logic into changelogrevision, so it is again in one place only. Shouldn't make a performance difference and is cleaner. I would really prefer to not add assumptions about the revisions of new nodes, that seems to be error prone and also not what we do right now. Otherwise `phases.registernew` wouldn't lookup the revision either. I do expect this to be optimized in the revlog one way or the other.
740–742	Right, the adjusted comment should explain that.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	24197		Dec 13 2020, 1:49 PM	★	★
Diff 2	24264		Dec 14 2020, 2:01 PM	★	★
Diff 3	24307		Dec 16 2020, 9:14 AM	★	★
Diff 4	24308		Dec 16 2020, 9:23 AM	★	★
Diff 5	24340		Dec 17 2020, 7:32 AM	★	★
Diff 6	24341		Dec 17 2020, 8:17 AM	★	★
Diff 7	24420		Dec 18 2020, 2:55 PM	★	★
Diff 8	24629		Jan 7 2021, 8:32 AM	★	★
Diff 9	24701		Jan 11 2021, 10:43 AM	★	★
Diff 10	24818		Jan 13 2021, 3:54 PM	★	★
Diff 11	24820		Jan 13 2021, 4:24 PM	★	★
Diff 12	24821		Jan 13 2021, 4:44 PM	★	★
Diff 13	24863		Jan 14 2021, 5:31 PM	★	★

Commit	Parents	Author	Summary	Date
323bc5a7871c	4d79375a5c41	Joerg Sonnenberger		Dec 14 2020, 11:02 AM

	Status	Author	Revision
	Needs Revision	joerg.sonnenberger	D9603 branchmap: refactor revbranchmap and use it as topicmap [PoC]
	Abandoned	joerg.sonnenberger	D9573 branchmap: update rev-branch-cache incrementally

Diff 24863

mercurial/branchmap.py

	# Revision branch info cache			# Revision branch info cache

	_rbcversion = b'-v1'			_rbcversion = b'-v1'
	_rbcnames = b'rbc-names' + _rbcversion			_rbcnames = b'rbc-names' + _rbcversion
	_rbcrevs = b'rbc-revs' + _rbcversion			_rbcrevs = b'rbc-revs' + _rbcversion
	# [4 byte hash prefix][4 byte branch name number with sign bit indicating open]			# [4 byte hash prefix][4 byte branch name number with sign bit indicating open]
	_rbcrecfmt = b'>4sI'			_rbcrecfmt = b'>4sI'
	_rbcrecsize = calcsize(_rbcrecfmt)			_rbcrecsize = calcsize(_rbcrecfmt)
				_rbcmininc = 64 * _rbcrecsize
	_rbcnodelen = 4			_rbcnodelen = 4
	_rbcbranchidxmask = 0x7FFFFFFF			_rbcbranchidxmask = 0x7FFFFFFF
	_rbccloseflag = 0x80000000			_rbccloseflag = 0x80000000


	class revbranchcache(object):			class revbranchcache(object):
	"""Persistent cache, mapping from revision number to branch name and close.			"""Persistent cache, mapping from revision number to branch name and close.
	This is a low level cache, independent of filtering.			This is a low level cache, independent of filtering.
	self._names.append(b)			self._names.append(b)
	self._namesreverse[b] = branchidx			self._namesreverse[b] = branchidx
	reponode = changelog.node(rev)			reponode = changelog.node(rev)
	if close:			if close:
	branchidx \|= _rbccloseflag			branchidx \|= _rbccloseflag
	self._setcachedata(rev, reponode, branchidx)			self._setcachedata(rev, reponode, branchidx)
	return b, close			return b, close

	def setdata(self, branch, rev, node, close):			def setdata(self, node, changelogrevision):
	"""add new data information to the cache"""			"""add new data information to the cache"""
				branch, close = changelogrevision.branchinfo

	if branch in self._namesreverse:			if branch in self._namesreverse:
	branchidx = self._namesreverse[branch]			branchidx = self._namesreverse[branch]
	else:			else:
	branchidx = len(self._names)			branchidx = len(self._names)
	self._names.append(branch)			self._names.append(branch)
	self._namesreverse[branch] = branchidx			self._namesreverse[branch] = branchidx
	if close:			if close:
	branchidx \|= _rbccloseflag			branchidx \|= _rbccloseflag
	self._setcachedata(rev, node, branchidx)			self._setcachedata(self._repo.changelog.rev(node), node, branchidx)
				marmouteUnsubmitted Not Done That signature change is weird. we end up doing an extra lookup for nodeid we end up exposing implementation details about extra to code that did not needed it before. I don't understand why we need to shift responsability here and have the branch cache care about this. marmoute: That signature change is weird. 1) we end up doing an extra lookup for nodeid 2) we end up…
				joerg.sonnenbergerAuthorUnsubmitted Not Done I think redundant keys are an interface bug. The `node` was available for all, so at least `onchangelog` in `changegroup.py` would have to do a lookup anyway. For the `commit` caller it would mean shuffling things around a bit. I'll check the extra logic here again, it's been inconsistent across the code base. This is a bit of a left over from earlier iterations, but it can likely be made tighter and simpler now. joerg.sonnenberger: I think redundant keys are an interface bug. The `node` was available for all, so at least…
				joerg.sonnenbergerAuthorUnsubmitted Not Done The extra logic is essentially what `changelog.branchinfo` does. D9603 refactors that to put it into `revbranchcache` as the only consumer in core. I've kept it for the moment since topics interacts with this code and would break. joerg.sonnenberger: The extra logic is essentially what `changelog.branchinfo` does. D9603 refactors that to put it…
				marmouteUnsubmitted Not Done My main concerns is responsibility and implementation details leaking into a simple cache. Could we have the extra-extraction done in the register_changeset method itself ? or probably better, putting them on changelogrevision since it is the one responsible for the details of the data access. marmoute: My main concerns is responsibility and implementation details leaking into a simple cache.
				marmouteUnsubmitted Not Done Both `changegroup` and `commit` application should have a revision number handy (that just the size of the revlog before creating the changeset). Revision number are much more efficient that nodeid overall. I would much prefer this kind of low level API to standardize on using them. marmoute: Both `changegroup` and `commit` application should have a revision number handy (that just the…
				joerg.sonnenbergerAuthorUnsubmitted Done I've moved the extra logic into changelogrevision, so it is again in one place only. Shouldn't make a performance difference and is cleaner. I would really prefer to not add assumptions about the revisions of new nodes, that seems to be error prone and also not what we do right now. Otherwise `phases.registernew` wouldn't lookup the revision either. I do expect this to be optimized in the revlog one way or the other. joerg.sonnenberger: I've moved the extra logic into changelogrevision, so it is again in one place only. Shouldn't…
	# If no cache data were readable (non exists, bad permission, etc)			# If no cache data were readable (non exists, bad permission, etc)
	# the cache was bypassing itself by setting:			# the cache was bypassing itself by setting:
	#			#
	# self.branchinfo = self._branchinfo			# self.branchinfo = self._branchinfo
	#			#
	# Since we now have data in the cache, we need to drop this bypassing.			# Since we now have data in the cache, we need to drop this bypassing.
	if 'branchinfo' in vars(self):			if 'branchinfo' in vars(self):
	del self.branchinfo			del self.branchinfo

	def _setcachedata(self, rev, node, branchidx):			def _setcachedata(self, rev, node, branchidx):
	"""Writes the node's branch data to the in-memory cache data."""			"""Writes the node's branch data to the in-memory cache data."""
	if rev == nullrev:			if rev == nullrev:
	return			return
	rbcrevidx = rev * _rbcrecsize			rbcrevidx = rev * _rbcrecsize
	if len(self._rbcrevs) < rbcrevidx + _rbcrecsize:			requiredsize = rbcrevidx + _rbcrecsize
	self._rbcrevs.extend(			rbccur = len(self._rbcrevs)
	b'\0'			if rbccur < requiredsize:
	* (len(self._repo.changelog) * _rbcrecsize - len(self._rbcrevs))			# bytearray doesn't allocate extra space at least in Python 3.7.
				pulkitUnsubmitted Done Hm, shouldn't this be `b'\0' * (max(...) - rbccur)`? pulkit: Hm, shouldn't this be `b'\0' * (max(...) - rbccur)`?
				joerg.sonnenbergerAuthorUnsubmitted Done The goal is to have room to grow for the next change to avoid quadratic resizing. If we need to resize, double the total size. The max size is to cheaply avoid a few iterations for the first few revisions. I've added a comment to make that clear. joerg.sonnenberger: The goal is to have room to grow for the next change to avoid quadratic resizing. If we need to…
	)			# When multiple changesets are added in a row, precise resize would
				# result in quadratic complexity. Overallocate to compensate by
				# use the classic doubling technique for dynamic arrays instead.
				marmouteUnsubmitted Done In the comment, I seems mention of resizing double the size. But I don't see this happening in final code. Am I missing something ? marmoute: In the comment, I seems mention of resizing double the size. But I don't see this happening in…
				joerg.sonnenbergerAuthorUnsubmitted Done Extending by requiredsize will normally double the size, except when it was sparse before. In that case the gap will count toward to extension, which seems a reasonable compromise. joerg.sonnenberger: Extending by requiredsize will normally double the size, except when it was sparse before. In…
				marmouteUnsubmitted Done I get it now. I don't know if it me being tired of the code being a bit too sneaky. but it might be worth having some explicit arithmetic or a clarification comment to highlight that the operation result in a array that is "current_size + currently needed size" leading to (about) a ×2 size increase. marmoute: I get it now. I don't know if it me being tired of the code being a bit too sneaky. but it…
				joerg.sonnenbergerAuthorUnsubmitted Done Right, the adjusted comment should explain that. joerg.sonnenberger: Right, the adjusted comment should explain that.
				# If there was a gap in the map before, less space will be reserved.
				self._rbcrevs.extend(b'\0' * max(_rbcmininc, requiredsize))
	pack_into(_rbcrecfmt, self._rbcrevs, rbcrevidx, node, branchidx)			pack_into(_rbcrecfmt, self._rbcrevs, rbcrevidx, node, branchidx)
	self._rbcrevslen = min(self._rbcrevslen, rev)			self._rbcrevslen = min(self._rbcrevslen, rev)

	tr = self._repo.currenttransaction()			tr = self._repo.currenttransaction()
	if tr:			if tr:
	tr.addfinalize(b'write-revbranchcache', self.write)			tr.addfinalize(b'write-revbranchcache', self.write)

	def write(self, tr=None):			def write(self, tr=None):

mercurial/bundle2.py

	op.ui.debug(b'applied %i hgtags fnodes cache entries\n' % count)			op.ui.debug(b'applied %i hgtags fnodes cache entries\n' % count)


	rbcstruct = struct.Struct(b'>III')			rbcstruct = struct.Struct(b'>III')


	@parthandler(b'cache:rev-branch-cache')			@parthandler(b'cache:rev-branch-cache')
	def handlerbc(op, inpart):			def handlerbc(op, inpart):
	"""receive a rev-branch-cache payload and update the local cache			"""Legacy part, ignored for compatibility with bundles from or
				for Mercurial before 5.7. Newer Mercurial computes the cache
	The payload is a series of data related to each branch			efficiently enough during unbundling that the additional transfer
				is unnecessary."""
				pulkitUnsubmitted Done Better to mention upto which mercurial version the part was used and what recent versions do. pulkit: Better to mention upto which mercurial version the part was used and what recent versions do.
	1) branch name length
	2) number of open heads
	3) number of closed heads
	4) open heads nodes
	5) closed heads nodes
	"""
	total = 0
	rawheader = inpart.read(rbcstruct.size)
	cache = op.repo.revbranchcache()
	cl = op.repo.unfiltered().changelog
	while rawheader:
	header = rbcstruct.unpack(rawheader)
	total += header[1] + header[2]
	utf8branch = inpart.read(header[0])
	branch = encoding.tolocal(utf8branch)
	for x in pycompat.xrange(header[1]):
	node = inpart.read(20)
	rev = cl.rev(node)
	cache.setdata(branch, rev, node, False)
	for x in pycompat.xrange(header[2]):
	node = inpart.read(20)
	rev = cl.rev(node)
	cache.setdata(branch, rev, node, True)
	rawheader = inpart.read(rbcstruct.size)
	cache.write()


	@parthandler(b'pushvars')			@parthandler(b'pushvars')
	def bundle2getvars(op, part):			def bundle2getvars(op, part):
	'''unbundle a bundle2 containing shellvars on the server'''			'''unbundle a bundle2 containing shellvars on the server'''
	# An option to disable unbundling on server-side for security reasons			# An option to disable unbundling on server-side for security reasons
	if op.ui.configbool(b'push', b'pushvars.server'):			if op.ui.configbool(b'push', b'pushvars.server'):
	hookargs = {}			hookargs = {}

mercurial/changegroup.py

	efilesset = set()			efilesset = set()
	cgnodes = []			cgnodes = []

	def ondupchangelog(cl, node):			def ondupchangelog(cl, node):
	if cl.rev(node) < clstart:			if cl.rev(node) < clstart:
	cgnodes.append(node)			cgnodes.append(node)

	def onchangelog(cl, node):			def onchangelog(cl, node):
	efilesset.update(cl.readfiles(node))			ctx = cl.changelogrevision(node)
				efilesset.update(ctx.files)
				repo.register_changeset(node, ctx)
				marmouteUnsubmitted Not Done Why not simply pass the revision number to the API and let lower lever create the changelogrevision if they need it ? marmoute: Why not simply pass the revision number to the API and let lower lever create the…
				joerg.sonnenbergerAuthorUnsubmitted Not Done `readfiles` does the expensive part of creating the changelogrevision already. Not having to process the text twice makes a noticable difference. Note that we don't have the revision number here. joerg.sonnenberger: `readfiles` does the expensive part of creating the changelogrevision already. Not having to…

	self.changelogheader()			self.changelogheader()
	deltas = self.deltaiter()			deltas = self.deltaiter()
	if not cl.addgroup(			if not cl.addgroup(
	deltas,			deltas,
	csmap,			csmap,
	trp,			trp,
	addrevisioncb=onchangelog,			addrevisioncb=onchangelog,

mercurial/changelog.py

	user = attr.ib(default=b'')			user = attr.ib(default=b'')
	date = attr.ib(default=(0, 0))			date = attr.ib(default=(0, 0))
	files = attr.ib(default=attr.Factory(list))			files = attr.ib(default=attr.Factory(list))
	filesadded = attr.ib(default=None)			filesadded = attr.ib(default=None)
	filesremoved = attr.ib(default=None)			filesremoved = attr.ib(default=None)
	p1copies = attr.ib(default=None)			p1copies = attr.ib(default=None)
	p2copies = attr.ib(default=None)			p2copies = attr.ib(default=None)
	description = attr.ib(default=b'')			description = attr.ib(default=b'')
				branchinfo = attr.ib(default=(_defaultextra[b'branch'], False))


	class changelogrevision(object):			class changelogrevision(object):
	"""Holds results of a parsed changelog revision.			"""Holds results of a parsed changelog revision.

	Changelog revisions consist of multiple pieces of data, including			Changelog revisions consist of multiple pieces of data, including
	the manifest node, user, and date. This object exposes a view into			the manifest node, user, and date. This object exposes a view into
	the parsed object.			the parsed object.
	if rawcopies is None:			if rawcopies is None:
	return None			return None
	return metadata.decodecopies(self.files, rawcopies)			return metadata.decodecopies(self.files, rawcopies)

	@property			@property
	def description(self):			def description(self):
	return encoding.tolocal(self._text[self._offsets[3] + 2 :])			return encoding.tolocal(self._text[self._offsets[3] + 2 :])

				@property
				def branchinfo(self):
				extra = self.extra
				return encoding.tolocal(extra.get(b"branch")), b'close' in extra


	class changelog(revlog.revlog):			class changelog(revlog.revlog):
	def __init__(self, opener, trypending=False):			def __init__(self, opener, trypending=False):
	"""Load a changelog revlog using an opener.			"""Load a changelog revlog using an opener.

	If ``trypending`` is true, we attempt to load the index from a			If ``trypending`` is true, we attempt to load the index from a
	``00changelog.i.a`` file instead of the default ``00changelog.i``.			``00changelog.i.a`` file instead of the default ``00changelog.i``.
	The ``00changelog.i.a`` file contains index (and possibly inline			The ``00changelog.i.a`` file contains index (and possibly inline
	return self.addrevision(			return self.addrevision(
	text, transaction, len(self), p1, p2, sidedata=sidedata, flags=flags			text, transaction, len(self), p1, p2, sidedata=sidedata, flags=flags
	)			)

	def branchinfo(self, rev):			def branchinfo(self, rev):
	"""return the branch name and open/close state of a revision			"""return the branch name and open/close state of a revision

	This function exists because creating a changectx object			This function exists because creating a changectx object
	just to access this is costly."""			just to access this is costly."""
	extra = self.changelogrevision(rev).extra			return self.changelogrevision(rev).branchinfo
				pulkitUnsubmitted Not Done Hm, is this unrelated change? pulkit: Hm, is this unrelated change?
				joerg.sonnenbergerAuthorUnsubmitted Not Done Partially, I discovered in the next change that `hgext.git` doesn't expose `read()` and it was easier to do it earlier. I can pull it out into a separate commit as it is also a micro-optimisation. joerg.sonnenberger: Partially, I discovered in the next change that `hgext.git` doesn't expose `read()` and it was…
				pulkitUnsubmitted Done Yes please do. pulkit: Yes please do.
				joerg.sonnenbergerAuthorUnsubmitted Done Done in D9626. joerg.sonnenberger: Done in D9626.
	return encoding.tolocal(extra.get(b"branch")), b'close' in extra

	def _nodeduplicatecallback(self, transaction, node):			def _nodeduplicatecallback(self, transaction, node):
	# keep track of revisions that got "re-added", eg: unbunde of know rev.			# keep track of revisions that got "re-added", eg: unbunde of know rev.
	#			#
	# We track them in a list to preserve their order from the source bundle			# We track them in a list to preserve their order from the source bundle
	duplicates = transaction.changes.setdefault(b'revduplicates', [])			duplicates = transaction.changes.setdefault(b'revduplicates', [])
	duplicates.append(self.rev(node))			duplicates.append(self.rev(node))

mercurial/commit.py

	ctx.description(),			ctx.description(),
	tr,			tr,
	p1.node(),			p1.node(),
	p2.node(),			p2.node(),
	user,			user,
	ctx.date(),			ctx.date(),
	extra,			extra,
	)			)
				repo.register_changeset(n, repo.changelog.changelogrevision(n))

	xp1, xp2 = p1.hex(), p2 and p2.hex() or b''			xp1, xp2 = p1.hex(), p2 and p2.hex() or b''
	repo.hook(			repo.hook(
	b'pretxncommit',			b'pretxncommit',
	throw=True,			throw=True,
	node=hex(n),			node=hex(n),
	parent1=xp1,			parent1=xp1,
	parent2=xp2,			parent2=xp2,
	)			)

mercurial/exchangev2.py


	revision = cl.changelogrevision(node)			revision = cl.changelogrevision(node)
	added.append(node)			added.append(node)

	# We need to preserve the mapping of changelog revision to node			# We need to preserve the mapping of changelog revision to node
	# so we can set the linkrev accordingly when manifests are added.			# so we can set the linkrev accordingly when manifests are added.
	manifestnodes[cl.rev(node)] = revision.manifest			manifestnodes[cl.rev(node)] = revision.manifest

				repo.register_changeset(node, revision)

	nodesbyphase = {phase: set() for phase in phases.phasenames.values()}			nodesbyphase = {phase: set() for phase in phases.phasenames.values()}
	remotebookmarks = {}			remotebookmarks = {}

	# addgroup() expects a 7-tuple describing revisions. This normalizes			# addgroup() expects a 7-tuple describing revisions. This normalizes
	# the wire data to that format.			# the wire data to that format.
	#			#
	# This loop also aggregates non-revision metadata, such as phase			# This loop also aggregates non-revision metadata, such as phase
	# data.			# data.

mercurial/interfaces/repository.py

	"""Return the list of bookmarks pointing to the specified node."""			"""Return the list of bookmarks pointing to the specified node."""

	def branchmap():			def branchmap():
	"""Return a mapping of branch to heads in that branch."""			"""Return a mapping of branch to heads in that branch."""

	def revbranchcache():			def revbranchcache():
	pass			pass

				def register_changeset(node, changelogrevision):
				"""Extension point for caches for new nodes.

				The changelogrevision object is provided as optimisation to
				avoid duplicate lookups."""
				marmouteUnsubmitted Not Done What about the cache the latest `changelogrevision` accessed to make this free and help in other cases ? marmoute: What about the cache the latest `changelogrevision` accessed to make this free and help in…
				joerg.sonnenbergerAuthorUnsubmitted Not Done I tried adding a cache for the last `changelogrevision`, but it turned out to be more expensive than shuffling things around a bit here. See the remark about `readfiles` earlier, which is the primarily time sink right now. joerg.sonnenberger: I tried adding a cache for the last `changelogrevision`, but it turned out to be more expensive…
				marmouteUnsubmitted Not Done could we cache the result of readfiles ? to reuse it at that time ? marmoute: could we cache the result of readfiles ? to reuse it at that time ?
				pass

				marmouteUnsubmitted Not Done new naming allow this to be `register_changeset`, we should probably use that. WE should probably introduce this API in a different changeset to simplify the discussion around it. marmoute: new naming allow this to be `register_changeset`, we should probably use that. WE should…
				joerg.sonnenbergerAuthorUnsubmitted Not Done I'm not attached to the name. The other concern was if it should be function on the module scope to allow easier monkey patching. Not sure if that question warrants splitting the change. joerg.sonnenberger: I'm not attached to the name. The other concern was if it should be function on the module…
				marmouteUnsubmitted Not Done Wrapping of repository level method is a common operation in extension. That is probably a good place to put it. (And also a place because they are too many method on localrepo… but these one is not a too bad fit in my opinion.) The motivation to split the change is also about making the first half easier to land sooner, and to avoid mixing discussion on two different topic. That is not a requirement, but it might help. marmoute: Wrapping of repository level method is a common operation in extension. That is probably a good…
	def branchtip(branchtip, ignoremissing=False):			def branchtip(branchtip, ignoremissing=False):
	"""Return the tip node for a given branch."""			"""Return the tip node for a given branch."""

	def lookup(key):			def lookup(key):
	"""Resolve the node for a revision."""			"""Resolve the node for a revision."""

	def lookupbranch(key):			def lookupbranch(key):
	"""Look up the branch name of the given revision or branch name."""			"""Look up the branch name of the given revision or branch name."""

mercurial/localrepo.py

	return self._branchcaches[self]			return self._branchcaches[self]

	@unfilteredmethod			@unfilteredmethod
	def revbranchcache(self):			def revbranchcache(self):
	if not self._revbranchcache:			if not self._revbranchcache:
	self._revbranchcache = branchmap.revbranchcache(self.unfiltered())			self._revbranchcache = branchmap.revbranchcache(self.unfiltered())
	return self._revbranchcache			return self._revbranchcache

				def register_changeset(self, node, changelogrevision):
				pulkitUnsubmitted Not Done We can get the node from changsetrevision, hence no need to pass it separately. minor name nit: we can call it `regitser_new_changeset`, the extra new will make it more obvious. Else we will require some documentation for this function. How about not making this a method on localrepo object? Having a normal function will help extensions wrap it easily. pulkit: 1) We can get the node from changsetrevision, hence no need to pass it separately. 2) minor…
				joerg.sonnenbergerAuthorUnsubmitted Done It's passed in to avoid the extra lookup and parsing for the important case of bundle operations. This means a minor penalty for commit, but it makes a measurable difference for the other cases. IMO "register" already implies that it is something new. I can add a few words in the interface definition though. Both work for me, no opinion yet on what is less effort for extensions. joerg.sonnenberger: 1. It's passed in to avoid the extra lookup and parsing for the important case of bundle…
				self.revbranchcache().setdata(node, changelogrevision)

	def branchtip(self, branch, ignoremissing=False):			def branchtip(self, branch, ignoremissing=False):
	"""return the tip node for a given branch			"""return the tip node for a given branch

	If ignoremissing is True, then this method will not raise an error.			If ignoremissing is True, then this method will not raise an error.
	This is helpful for callers that only expect None for a missing branch			This is helpful for callers that only expect None for a missing branch
	(e.g. namespace).			(e.g. namespace).

	"""			"""

relnotes/next

	is also supported by "premerge" as			is also supported by "premerge" as
	`merge-tools.<tool>.premerge=keep-mergediff`.			`merge-tools.<tool>.premerge=keep-mergediff`.

	* External hooks are now called with `HGPLAIN=1` preset.			* External hooks are now called with `HGPLAIN=1` preset.

	* The `branchmap` cache is updated more intelligently and can be			* The `branchmap` cache is updated more intelligently and can be
	significantly faster for repositories with many branches and changesets.			significantly faster for repositories with many branches and changesets.

				* The `rev-branch-cache` is now updated incrementally whenever changesets
				are added.


	== New Experimental Features ==			== New Experimental Features ==

	* `experimental.single-head-per-branch:public-changes-only` can be used			* `experimental.single-head-per-branch:public-changes-only` can be used
	restrict the single head check to public revision. This is useful for			restrict the single head check to public revision. This is useful for
	overlay repository that have both a publishing and non-publishing view			overlay repository that have both a publishing and non-publishing view
	of the same storage.			of the same storage.

tests/test-acl.t

	adding foo/file.txt revisions			adding foo/file.txt revisions
	adding quux/file.py revisions			adding quux/file.py revisions
	calling hook pretxnchangegroup.acl: hgext.acl.hook			calling hook pretxnchangegroup.acl: hgext.acl.hook
	acl: changes have source "push" - skipping			acl: changes have source "push" - skipping
	bundle2-input-part: total payload size 1553			bundle2-input-part: total payload size 1553
	bundle2-input-part: "phase-heads" supported			bundle2-input-part: "phase-heads" supported
	bundle2-input-part: total payload size 24			bundle2-input-part: total payload size 24
	bundle2-input-bundle: 5 parts total			bundle2-input-bundle: 5 parts total
				truncating cache/rbc-revs-v1 to 8
	updating the branch cache			updating the branch cache
	added 3 changesets with 3 changes to 3 files			added 3 changesets with 3 changes to 3 files
	bundle2-output-bundle: "HG20", 1 parts total			bundle2-output-bundle: "HG20", 1 parts total
	bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload			bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload
	bundle2-input-bundle: no-transaction			bundle2-input-bundle: no-transaction
	bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported			bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported
	bundle2-input-bundle: 1 parts total			bundle2-input-bundle: 1 parts total
	listing keys for "phases"			listing keys for "phases"
	acl: branch access granted: "f9cafe1212c8" on branch "default"			acl: branch access granted: "f9cafe1212c8" on branch "default"
	acl: path access granted: "f9cafe1212c8"			acl: path access granted: "f9cafe1212c8"
	acl: branch access granted: "911600dab2ae" on branch "default"			acl: branch access granted: "911600dab2ae" on branch "default"
	acl: path access granted: "911600dab2ae"			acl: path access granted: "911600dab2ae"
	bundle2-input-part: total payload size 1553			bundle2-input-part: total payload size 1553
	bundle2-input-part: "phase-heads" supported			bundle2-input-part: "phase-heads" supported
	bundle2-input-part: total payload size 24			bundle2-input-part: total payload size 24
	bundle2-input-bundle: 5 parts total			bundle2-input-bundle: 5 parts total
				truncating cache/rbc-revs-v1 to 8
	updating the branch cache			updating the branch cache
	added 3 changesets with 3 changes to 3 files			added 3 changesets with 3 changes to 3 files
	bundle2-output-bundle: "HG20", 1 parts total			bundle2-output-bundle: "HG20", 1 parts total
	bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload			bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload
	bundle2-input-bundle: no-transaction			bundle2-input-bundle: no-transaction
	bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported			bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported
	bundle2-input-bundle: 1 parts total			bundle2-input-bundle: 1 parts total
	listing keys for "phases"			listing keys for "phases"
	bundle2-input-part: "bookmarks" supported			bundle2-input-part: "bookmarks" supported
	bundle2-input-part: total payload size 37			bundle2-input-part: total payload size 37
	calling hook prepushkey.acl: hgext.acl.hook			calling hook prepushkey.acl: hgext.acl.hook
	acl: checking access for user "fred"			acl: checking access for user "fred"
	acl: acl.allow.bookmarks not enabled			acl: acl.allow.bookmarks not enabled
	acl: acl.deny.bookmarks not enabled			acl: acl.deny.bookmarks not enabled
	acl: bookmark access granted: "ef1ea85a6374b77d6da9dcda9541f498f2d17df7" on bookmark "moving-bookmark"			acl: bookmark access granted: "ef1ea85a6374b77d6da9dcda9541f498f2d17df7" on bookmark "moving-bookmark"
	bundle2-input-bundle: 7 parts total			bundle2-input-bundle: 7 parts total
				truncating cache/rbc-revs-v1 to 8
	updating the branch cache			updating the branch cache
	invalid branch cache (served.hidden): tip differs			invalid branch cache (served.hidden): tip differs
	added 1 changesets with 1 changes to 1 files			added 1 changesets with 1 changes to 1 files
	bundle2-output-bundle: "HG20", 1 parts total			bundle2-output-bundle: "HG20", 1 parts total
	bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload			bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload
	bundle2-input-bundle: no-transaction			bundle2-input-bundle: no-transaction
	bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported			bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported
	bundle2-input-bundle: 1 parts total			bundle2-input-bundle: 1 parts total
	acl: branch access granted: "f9cafe1212c8" on branch "default"			acl: branch access granted: "f9cafe1212c8" on branch "default"
	acl: path access granted: "f9cafe1212c8"			acl: path access granted: "f9cafe1212c8"
	acl: branch access granted: "911600dab2ae" on branch "default"			acl: branch access granted: "911600dab2ae" on branch "default"
	acl: path access granted: "911600dab2ae"			acl: path access granted: "911600dab2ae"
	bundle2-input-part: total payload size 1553			bundle2-input-part: total payload size 1553
	bundle2-input-part: "phase-heads" supported			bundle2-input-part: "phase-heads" supported
	bundle2-input-part: total payload size 24			bundle2-input-part: total payload size 24
	bundle2-input-bundle: 5 parts total			bundle2-input-bundle: 5 parts total
				truncating cache/rbc-revs-v1 to 8
	updating the branch cache			updating the branch cache
	added 3 changesets with 3 changes to 3 files			added 3 changesets with 3 changes to 3 files
	bundle2-output-bundle: "HG20", 1 parts total			bundle2-output-bundle: "HG20", 1 parts total
	bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload			bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload
	bundle2-input-bundle: no-transaction			bundle2-input-bundle: no-transaction
	bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported			bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported
	bundle2-input-bundle: 1 parts total			bundle2-input-bundle: 1 parts total
	listing keys for "phases"			listing keys for "phases"
	acl: branch access granted: "f9cafe1212c8" on branch "default"			acl: branch access granted: "f9cafe1212c8" on branch "default"
	acl: path access granted: "f9cafe1212c8"			acl: path access granted: "f9cafe1212c8"
	acl: branch access granted: "911600dab2ae" on branch "default"			acl: branch access granted: "911600dab2ae" on branch "default"
	acl: path access granted: "911600dab2ae"			acl: path access granted: "911600dab2ae"
	bundle2-input-part: total payload size 1553			bundle2-input-part: total payload size 1553
	bundle2-input-part: "phase-heads" supported			bundle2-input-part: "phase-heads" supported
	bundle2-input-part: total payload size 24			bundle2-input-part: total payload size 24
	bundle2-input-bundle: 5 parts total			bundle2-input-bundle: 5 parts total
				truncating cache/rbc-revs-v1 to 8
	updating the branch cache			updating the branch cache
	added 3 changesets with 3 changes to 3 files			added 3 changesets with 3 changes to 3 files
	bundle2-output-bundle: "HG20", 1 parts total			bundle2-output-bundle: "HG20", 1 parts total
	bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload			bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload
	bundle2-input-bundle: no-transaction			bundle2-input-bundle: no-transaction
	bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported			bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported
	bundle2-input-bundle: 1 parts total			bundle2-input-bundle: 1 parts total
	listing keys for "phases"			listing keys for "phases"
	acl: branch access granted: "f9cafe1212c8" on branch "default"			acl: branch access granted: "f9cafe1212c8" on branch "default"
	acl: path access granted: "f9cafe1212c8"			acl: path access granted: "f9cafe1212c8"
	acl: branch access granted: "911600dab2ae" on branch "default"			acl: branch access granted: "911600dab2ae" on branch "default"
	acl: path access granted: "911600dab2ae"			acl: path access granted: "911600dab2ae"
	bundle2-input-part: total payload size 1553			bundle2-input-part: total payload size 1553
	bundle2-input-part: "phase-heads" supported			bundle2-input-part: "phase-heads" supported
	bundle2-input-part: total payload size 24			bundle2-input-part: total payload size 24
	bundle2-input-bundle: 5 parts total			bundle2-input-bundle: 5 parts total
				truncating cache/rbc-revs-v1 to 8
	updating the branch cache			updating the branch cache
	added 3 changesets with 3 changes to 3 files			added 3 changesets with 3 changes to 3 files
	bundle2-output-bundle: "HG20", 1 parts total			bundle2-output-bundle: "HG20", 1 parts total
	bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload			bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload
	bundle2-input-bundle: no-transaction			bundle2-input-bundle: no-transaction
	bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported			bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported
	bundle2-input-bundle: 1 parts total			bundle2-input-bundle: 1 parts total
	listing keys for "phases"			listing keys for "phases"
	acl: branch access granted: "f9cafe1212c8" on branch "default"			acl: branch access granted: "f9cafe1212c8" on branch "default"
	acl: path access granted: "f9cafe1212c8"			acl: path access granted: "f9cafe1212c8"
	acl: branch access granted: "911600dab2ae" on branch "default"			acl: branch access granted: "911600dab2ae" on branch "default"
	acl: path access granted: "911600dab2ae"			acl: path access granted: "911600dab2ae"
	bundle2-input-part: total payload size 1553			bundle2-input-part: total payload size 1553
	bundle2-input-part: "phase-heads" supported			bundle2-input-part: "phase-heads" supported
	bundle2-input-part: total payload size 24			bundle2-input-part: total payload size 24
	bundle2-input-bundle: 5 parts total			bundle2-input-bundle: 5 parts total
				truncating cache/rbc-revs-v1 to 8
	updating the branch cache			updating the branch cache
	added 3 changesets with 3 changes to 3 files			added 3 changesets with 3 changes to 3 files
	bundle2-output-bundle: "HG20", 1 parts total			bundle2-output-bundle: "HG20", 1 parts total
	bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload			bundle2-output-part: "reply:changegroup" (advisory) (params: 0 advisory) empty payload
	bundle2-input-bundle: no-transaction			bundle2-input-bundle: no-transaction
	bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported			bundle2-input-part: "reply:changegroup" (advisory) (params: 0 advisory) supported
	bundle2-input-bundle: 1 parts total			bundle2-input-bundle: 1 parts total
	listing keys for "phases"			listing keys for "phases"

tests/test-inherit-mode.t

	after push			after push
	group can still write everything			group can still write everything

	$ "$PYTHON" ../printmodes.py ../push			$ "$PYTHON" ../printmodes.py ../push
	00770 ../push/.hg/			00770 ../push/.hg/
	00660 ../push/.hg/00changelog.i			00660 ../push/.hg/00changelog.i
	00770 ../push/.hg/cache/			00770 ../push/.hg/cache/
	00660 ../push/.hg/cache/branch2-base			00660 ../push/.hg/cache/branch2-base
				00660 ../push/.hg/cache/rbc-names-v1
				00660 ../push/.hg/cache/rbc-revs-v1
	00660 ../push/.hg/dirstate			00660 ../push/.hg/dirstate
	00660 ../push/.hg/requires			00660 ../push/.hg/requires
	00770 ../push/.hg/store/			00770 ../push/.hg/store/
	00660 ../push/.hg/store/00changelog.i			00660 ../push/.hg/store/00changelog.i
	00660 ../push/.hg/store/00manifest.i			00660 ../push/.hg/store/00manifest.i
	00770 ../push/.hg/store/data/			00770 ../push/.hg/store/data/
	00770 ../push/.hg/store/data/dir/			00770 ../push/.hg/store/data/dir/
	00660 ../push/.hg/store/data/dir/bar.i (reporevlogstore !)			00660 ../push/.hg/store/data/dir/bar.i (reporevlogstore !)

tests/test-rebase-conflicts.t

	add changeset 19c888675e13			add changeset 19c888675e13
	add changeset 2a7f09cac94c			add changeset 2a7f09cac94c
	adding manifests			adding manifests
	adding file changes			adding file changes
	adding f1.txt revisions			adding f1.txt revisions
	bundle2-input-part: total payload size 1686			bundle2-input-part: total payload size 1686
	bundle2-input-part: "cache:rev-branch-cache" (advisory) supported			bundle2-input-part: "cache:rev-branch-cache" (advisory) supported
	bundle2-input-part: total payload size 74			bundle2-input-part: total payload size 74
	truncating cache/rbc-revs-v1 to 56
	bundle2-input-part: "phase-heads" supported			bundle2-input-part: "phase-heads" supported
	bundle2-input-part: total payload size 24			bundle2-input-part: total payload size 24
	bundle2-input-bundle: 3 parts total			bundle2-input-bundle: 3 parts total
				truncating cache/rbc-revs-v1 to 72
	added 2 changesets with 2 changes to 1 files			added 2 changesets with 2 changes to 1 files
	updating the branch cache			updating the branch cache
	invalid branch cache (served): tip differs			invalid branch cache (served): tip differs
	invalid branch cache (served.hidden): tip differs			invalid branch cache (served.hidden): tip differs
	rebase completed			rebase completed

	Test minimization of merge conflicts			Test minimization of merge conflicts
	$ hg up -q null			$ hg up -q null

tests/test-wireproto-exchangev2-shallow.t

	getting dir0/c			getting dir0/c
	dir0/d: remote created -> g			dir0/d: remote created -> g
	getting dir0/d			getting dir0/d
	dir1/e: remote created -> g			dir1/e: remote created -> g
	getting dir1/e			getting dir1/e
	dir1/f: remote created -> g			dir1/f: remote created -> g
	getting dir1/f			getting dir1/f
	6 files updated, 0 files merged, 0 files removed, 0 files unresolved			6 files updated, 0 files merged, 0 files removed, 0 files unresolved
				updating the branch cache
	(sent 5 HTTP requests and * bytes; received * bytes in responses) (glob)			(sent 5 HTTP requests and * bytes; received * bytes in responses) (glob)

	$ sqlite3 -line client-shallow-1/.hg/store/db.sqlite << EOF			$ sqlite3 -line client-shallow-1/.hg/store/db.sqlite << EOF
	> SELECT id, path, revnum, node, p1rev, p2rev, linkrev, flags FROM filedata ORDER BY id ASC;			> SELECT id, path, revnum, node, p1rev, p2rev, linkrev, flags FROM filedata ORDER BY id ASC;
	> EOF			> EOF
	id = 1			id = 1
	path = a			path = a
	revnum = 0			revnum = 0
	resolving manifests			resolving manifests
	branchmerge: False, force: False, partial: False			branchmerge: False, force: False, partial: False
	ancestor: 000000000000, local: 000000000000+, remote: 93a8bd067ed2			ancestor: 000000000000, local: 000000000000+, remote: 93a8bd067ed2
	dir0/c: remote created -> g			dir0/c: remote created -> g
	getting dir0/c			getting dir0/c
	dir0/d: remote created -> g			dir0/d: remote created -> g
	getting dir0/d			getting dir0/d
	2 files updated, 0 files merged, 0 files removed, 0 files unresolved			2 files updated, 0 files merged, 0 files removed, 0 files unresolved
				updating the branch cache
	(sent 5 HTTP requests and * bytes; received * bytes in responses) (glob)			(sent 5 HTTP requests and * bytes; received * bytes in responses) (glob)

	$ sqlite3 -line client-shallow-narrow-1/.hg/store/db.sqlite << EOF			$ sqlite3 -line client-shallow-narrow-1/.hg/store/db.sqlite << EOF
	> SELECT id, path, revnum, node, p1rev, p2rev, linkrev, flags FROM filedata ORDER BY id ASC;			> SELECT id, path, revnum, node, p1rev, p2rev, linkrev, flags FROM filedata ORDER BY id ASC;
	> EOF			> EOF
	id = 1			id = 1
	path = dir0/c			path = dir0/c
	revnum = 0			revnum = 0
	getting dir0/c			getting dir0/c
	dir0/d: remote created -> g			dir0/d: remote created -> g
	getting dir0/d			getting dir0/d
	dir1/e: remote created -> g			dir1/e: remote created -> g
	getting dir1/e			getting dir1/e
	dir1/f: remote created -> g			dir1/f: remote created -> g
	getting dir1/f			getting dir1/f
	6 files updated, 0 files merged, 0 files removed, 0 files unresolved			6 files updated, 0 files merged, 0 files removed, 0 files unresolved
				updating the branch cache
	(sent 6 HTTP requests and * bytes; received * bytes in responses) (glob)			(sent 6 HTTP requests and * bytes; received * bytes in responses) (glob)

	Incremental pull of shallow clone fetches new changesets			Incremental pull of shallow clone fetches new changesets

	$ hg --cwd client-shallow-2 --debug pull http://localhost:$HGPORT			$ hg --cwd client-shallow-2 --debug pull http://localhost:$HGPORT
	pulling from http://localhost:$HGPORT/			pulling from http://localhost:$HGPORT/
	using http://localhost:$HGPORT/			using http://localhost:$HGPORT/
	sending capabilities command			sending capabilities command

			Path	Packages
M			mercurial/branchmap.py (21 lines)
M			mercurial/bundle2.py (33 lines)
M			mercurial/changegroup.py (4 lines)
M			mercurial/changelog.py (9 lines)
M			mercurial/commit.py (2 lines)
M			mercurial/exchangev2.py (2 lines)
M			mercurial/interfaces/repository.py (7 lines)
M			mercurial/localrepo.py (3 lines)
M			relnotes/next (3 lines)
M			tests/test-acl.t (7 lines)
M			tests/test-inherit-mode.t (2 lines)
M			tests/test-rebase-conflicts.t (2 lines)
M			tests/test-wireproto-exchangev2-shallow.t (3 lines)

This is an archive of the discontinued Mercurial Phabricator instance.

branchmap: update rev-branch-cache incrementally
AbandonedPublic

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 24863

mercurial/branchmap.py

mercurial/bundle2.py

mercurial/changegroup.py

mercurial/changelog.py

mercurial/commit.py

mercurial/exchangev2.py

mercurial/interfaces/repository.py

mercurial/localrepo.py

relnotes/next

tests/test-acl.t

tests/test-inherit-mode.t

tests/test-rebase-conflicts.t

tests/test-wireproto-exchangev2-shallow.t

This is an archive of the discontinued Mercurial Phabricator instance.

branchmap: update rev-branch-cache incrementallyAbandonedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24863

mercurial/branchmap.py

mercurial/bundle2.py

mercurial/changegroup.py

mercurial/changelog.py

mercurial/commit.py

mercurial/exchangev2.py

mercurial/interfaces/repository.py

mercurial/localrepo.py

relnotes/next

tests/test-acl.t

tests/test-inherit-mode.t

tests/test-rebase-conflicts.t

tests/test-wireproto-exchangev2-shallow.t

branchmap: update rev-branch-cache incrementally
AbandonedPublic

Revision Contents
Changeset List