( )⚙ D963 hgweb: in protocol adapter, look for bytes instances, not str

This is an archive of the discontinued Mercurial Phabricator instance.

hgweb: in protocol adapter, look for bytes instances, not str
ClosedPublic

Authored by durin42 on Oct 5 2017, 5:31 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 5 2017, 5:31 PM
pulkit accepted this revision.Oct 5 2017, 7:09 PM
indygreg accepted this revision.Oct 6 2017, 9:35 AM
indygreg added a subscriber: indygreg.

FWIW, I've written extensions that have returned the wrong type and (previously silently) fell off this function. So yay for catching unicode return values!

This revision is now accepted and ready to land.Oct 6 2017, 9:35 AM
This revision was automatically updated to reflect the committed changes.