( )⚙ D964 python3: move from using func_name to __name__

This is an archive of the discontinued Mercurial Phabricator instance.

python3: move from using func_name to __name__
ClosedPublic

Authored by durin42 on Oct 5 2017, 5:31 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 5 2017, 5:31 PM
pulkit accepted this revision.Oct 5 2017, 7:09 PM
indygreg accepted this revision.Oct 6 2017, 9:37 AM
indygreg added a subscriber: indygreg.

Such a brittle pattern. It feels like the names of things should be defined in a decorator or something. But fixing this would be scope bloat and can be punted to another time.

This revision is now accepted and ready to land.Oct 6 2017, 9:37 AM
yuja requested changes to this revision.Oct 6 2017, 11:24 AM
yuja added a subscriber: yuja.

Can't we just use func.__name__ on both Pythons?

This revision now requires changes to proceed.Oct 6 2017, 11:24 AM
This revision was automatically updated to reflect the committed changes.
durin42 retitled this revision from python3: add and use adapter for func_name attr, now known as __name__ to python3: move from using func_name to __name__.Oct 14 2017, 2:52 AM
durin42 updated this revision to Diff 2721.

Yep, name is much better.

Hm, phabricator still says this is closed. Will make a new revision with the revised code.