Page MenuHomePhabricator

beautifygraph: change the current commit symbol

Authored by msuozzo on Sat, Jan 2, 1:56 AM.



The existing "circle with vertical fill" character renders as full width in
many terminals making the beautified symbols have uneven size. Additionally,
the proposed "fisheye" character is the logic 'active' version of the current
merge symbol, "bullseye."

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

msuozzo created this revision.Sat, Jan 2, 1:56 AM
Alphare accepted this revision.Tue, Jan 5, 4:36 AM

This looks a good idea

pulkit accepted this revision.Sat, Jan 9, 5:06 AM
This revision is now accepted and ready to land.Sat, Jan 9, 5:06 AM
pulkit added a comment.Sat, Jan 9, 5:50 AM

With this patch, test-check-commit.t fails:

--- /repo/hgpush/tests/test-check-commit.t
+++ /repo/hgpush/tests/test-check-commit.t.err
@@ -25,3 +25,8 @@
   >     fi
   >   done
   > fi
+  Revision 5a50c3331135 does not comply with rules
+  ------------------------------------------------------
+  1: username is not an email address
+   # User msuozzo
This revision was automatically updated to reflect the committed changes.