Page MenuHomePhabricator
Differential D9682

copies-rust: extract generic map merge logic from merge_copies_dict
ClosedPublic
Actions

Authored by SimonSapin on Jan 6 2021, 9:12 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG435d9fc72646: copies-rust: extract generic map merge logic from merge_copies_dict
rHG26d0acbc6cce: copies-rust: extract generic map merge logic from merge_copies_dict
Summary

This deduplicates the copy-tracing-specific logic

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Jan 6 2021, 9:12 AM
baymax updated this revision to Diff 24682.Jan 8 2021, 6:16 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Jan 22 2021, 4:38 AM
Alphare added a subscriber: Alphare.

Thanks for the refactor, the comments are also clearer this way.

baymax updated this revision to Diff 25702.Feb 22 2021, 9:14 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 25761.Feb 22 2021, 11:22 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 25800.Feb 22 2021, 5:12 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

SimonSapin added a commit: rHG26d0acbc6cce: copies-rust: extract generic map merge logic from merge_copies_dict.Feb 24 2021, 11:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG26d0acbc6cce: copies-rust: extract generic map merge logic from merge_copies_dict (authored by SimonSapin). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/copy_tracing.rs (227 lines)
Mrust/hg-core/src/utils.rs (150 lines)

Diff 25861

View Options

rust/hg-core/src/copy_tracing.rs

Loading...
View Options

rust/hg-core/src/utils.rs

Loading...