This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9688

nodemap: match comment to actual code
ClosedPublic

Authored by joerg.sonnenberger on Jan 7 2021, 5:51 AM.

Details

Reviewers
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8e7ce6555ea7: nodemap: match comment to actual code
Summary

REV_OFFSET constant is 2, not 10.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute accepted this revision.Jan 7 2021, 7:55 AM
marmoute added a subscriber: marmoute.

looks good, maybe add a reference to REV_OFFSET on the comment ?

pulkit accepted this revision.Jan 9 2021, 5:06 AM
This revision is now accepted and ready to land.Jan 9 2021, 5:06 AM
joerg.sonnenberger added a commit: rHG8e7ce6555ea7: nodemap: match comment to actual code.Jan 9 2021, 6:12 AM
Closed by commit rHG8e7ce6555ea7: nodemap: match comment to actual code (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlogutils/nodemap.py (2 lines)

Diff 24623

mercurial/revlogutils/nodemap.py

# The nodemap is persisted as Trie using 4bits-address/16-entries block. each # The nodemap is persisted as Trie using 4bits-address/16-entries block. each
# revision can be adressed using its node shortest prefix. # revision can be adressed using its node shortest prefix.
# #
# The trie is stored as a sequence of block. Each block contains 16 entries # The trie is stored as a sequence of block. Each block contains 16 entries
# (signed 64bit integer, big endian). Each entry can be one of the following: # (signed 64bit integer, big endian). Each entry can be one of the following:
# #
# * value >= 0 -> index of sub-block # * value >= 0 -> index of sub-block
# * value == -1 -> no value # * value == -1 -> no value
# * value < -1 -> a revision value: rev = -(value+10) # * value < -1 -> a revision value: rev = -(value+2)
# #
# The implementation focus on simplicity, not on performance. A Rust # The implementation focus on simplicity, not on performance. A Rust
# implementation should provide a efficient version of the same binary # implementation should provide a efficient version of the same binary
# persistence. This reference python implementation is never meant to be # persistence. This reference python implementation is never meant to be
# extensively use in production. # extensively use in production.
def persistent_data(index): def persistent_data(index):