( )⚙ D9706 shelve: open patch using new shelf class instead of open()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9706

shelve: open patch using new shelf class instead of open()
ClosedPublic

Authored by martinvonz on Jan 8 2021, 3:36 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG14ce2eb6e8a4: shelve: open patch using new shelf class instead of open()
rHGd6f5e8157cc0: shelve: open patch using new shelf class instead of open()
rHG6f39aab28188: shelve: open patch using new shelf class instead of open()
Summary

For some reason the existing code didn't use shelvedfile().opener()
so here we migrate to shelf().open_patch() from the open() system
call instead.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/shelve.py (3 lines)

Diff 24662

mercurial/shelve.py

from __future__ import absolute_import from __future__ import absolute_import
import collections import collections
import errno import errno
import itertools import itertools
import stat import stat
from .i18n import _ from .i18n import _
from .pycompat import open
from .node import ( from .node import (
bin, bin,
hex, hex,
nullid, nullid,
nullrev, nullrev,
) )
from . import ( from . import (
bookmarks, bookmarks,
continue continue
ui.write(b' ' * (16 - len(sname))) ui.write(b' ' * (16 - len(sname)))
used = 16 used = 16
date = dateutil.makedate(mtime) date = dateutil.makedate(mtime)
age = b'(%s)' % templatefilters.age(date, abbrev=True) age = b'(%s)' % templatefilters.age(date, abbrev=True)
ui.write(age, label=b'shelve.age') ui.write(age, label=b'shelve.age')
ui.write(b' ' * (12 - len(age))) ui.write(b' ' * (12 - len(age)))
used += 12 used += 12
with open(name + b'.' + patchextension, b'rb') as fp: with Shelf(repo, sname).open_patch() as fp:
while True: while True:
line = fp.readline() line = fp.readline()
if not line: if not line:
break break
if not line.startswith(b'#'): if not line.startswith(b'#'):
desc = line.rstrip() desc = line.rstrip()
if ui.formatted(): if ui.formatted():
desc = stringutil.ellipsis(desc, width - used) desc = stringutil.ellipsis(desc, width - used)