( )⚙ D9709 shelve: inline shelvedfile.filename() since there are no callers outside class

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9709

shelve: inline shelvedfile.filename() since there are no callers outside class
ClosedPublic

Authored by martinvonz on Jan 8 2021, 3:36 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG0a69f9e640ec: shelve: inline shelvedfile.filename() since there are no callers outside class
rHG99e178fddde4: shelve: inline shelvedfile.filename() since there are no callers outside class
rHGec196a43e186: shelve: inline shelvedfile.filename() since there are no callers outside class

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/shelve.py (5 lines)

Diff 24944

mercurial/shelve.py

if filetype: if filetype:
self.fname = name + b'.' + filetype self.fname = name + b'.' + filetype
else: else:
self.fname = name self.fname = name
def exists(self): def exists(self):
return self.vfs.exists(self.fname) return self.vfs.exists(self.fname)
def filename(self):
return self.vfs.join(self.fname)
def backupfilename(self): def backupfilename(self):
def gennames(base): def gennames(base):
yield base yield base
base, ext = base.rsplit(b'.', 1) base, ext = base.rsplit(b'.', 1)
for i in itertools.count(1): for i in itertools.count(1):
yield b'%s-%d.%s' % (base, i, ext) yield b'%s-%d.%s' % (base, i, ext)
name = self.backupvfs.join(self.fname) name = self.backupvfs.join(self.fname)
for n in gennames(name): for n in gennames(name):
if not self.backupvfs.exists(n): if not self.backupvfs.exists(n):
return n return n
def movetobackup(self): def movetobackup(self):
if not self.backupvfs.isdir(): if not self.backupvfs.isdir():
self.backupvfs.makedir() self.backupvfs.makedir()
util.rename(self.filename(), self.backupfilename()) util.rename(self.vfs.join(self.fname), self.backupfilename())
class Shelf(object): class Shelf(object):
"""Represents a shelf, including possibly multiple files storing it. """Represents a shelf, including possibly multiple files storing it.
Old shelves will have a .patch and a .hg file. Newer shelves will Old shelves will have a .patch and a .hg file. Newer shelves will
also have a .shelve file. This class abstracts away some of the also have a .shelve file. This class abstracts away some of the
differences and lets you work with the shelf as a whole. differences and lets you work with the shelf as a whole.