This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9747

largefiles: remove unused imports
ClosedPublic

Authored by pulkit on Jan 13 2021, 5:30 AM.

Details

Reviewers
marmoute
mharbison72
Group Reviewers
hg-reviewers
Commits
rHGeb01d6d00a50: largefiles: remove unused imports
Summary

This fixes test-check-pyflakes.t

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jan 13 2021, 5:30 AM
marmoute accepted this revision.Jan 13 2021, 10:18 AM
marmoute added a subscriber: marmoute.

If the tools says they are unused and the test pass, this must be true :-). Can you do a CI run on this to make sure it runs ?

pulkit added a comment.Jan 13 2021, 10:30 AM
In D9747#147223, @marmoute wrote:

If the tools says they are unused and the test pass, this must be true :-). Can you do a CI run on this to make sure it runs ?

Already done. https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/16339 (Ignore pure failures, they will be fixed in a different patch).

mharbison72 accepted this revision.Jan 13 2021, 12:18 PM
This revision is now accepted and ready to land.Jan 13 2021, 12:18 PM
pulkit added a commit: rHGeb01d6d00a50: largefiles: remove unused imports.Jan 13 2021, 12:26 PM
Closed by commit rHGeb01d6d00a50: largefiles: remove unused imports (authored by pulkit). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24791

hgext/largefiles/__init__.py

''' '''
from __future__ import absolute_import from __future__ import absolute_import
from mercurial import ( from mercurial import (
cmdutil, cmdutil,
extensions, extensions,
exthelper, exthelper,
hg, hg,
httppeer,
localrepo, localrepo,
sshpeer,
wireprotov1server, wireprotov1server,
) )
from . import ( from . import (
lfcommands, lfcommands,
overrides, overrides,
proto, proto,
reposetup, reposetup,

hgext/largefiles/proto.py

# Copyright 2011 Fog Creek Software # Copyright 2011 Fog Creek Software
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
import os import os
import re
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial.pycompat import open from mercurial.pycompat import open
from mercurial import ( from mercurial import (
error, error,
exthelper, exthelper,
httppeer, httppeer,