This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9787

hghave: clarify `sqlite` requirements
ClosedPublic

Authored by marmoute on Jan 15 2021, 8:08 AM.

Details

Reviewers
joerg.sonnenberger
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7149fb17ff72: hghave: clarify `sqlite` requirements
Summary

We need more than the python module, we also need the sqlite3 command line.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 15 2021, 8:08 AM
marmoute updated this revision to Diff 24899.Jan 15 2021, 8:54 AM
pulkit accepted this revision.Jan 15 2021, 1:09 PM
This revision is now accepted and ready to land.Jan 15 2021, 1:09 PM
marmoute added a commit: rHG7149fb17ff72: hghave: clarify `sqlite` requirements.Jan 16 2021, 3:53 AM
Closed by commit rHG7149fb17ff72: hghave: clarify `sqlite` requirements (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (2 lines)

Diff 24926

tests/hghave.py

return 'bundlerepo' in getrepofeatures() return 'bundlerepo' in getrepofeatures()
@check('repofncache', 'repository has an fncache') @check('repofncache', 'repository has an fncache')
def has_repofncache(): def has_repofncache():
return 'fncache' in getrepofeatures() return 'fncache' in getrepofeatures()
@check('sqlite', 'sqlite3 module is available') @check('sqlite', 'sqlite3 module and matching cli is available')
def has_sqlite(): def has_sqlite():
try: try:
import sqlite3 import sqlite3
version = sqlite3.sqlite_version_info version = sqlite3.sqlite_version_info
except ImportError: except ImportError:
return False return False