copies: clarify which case some conditional are handling
ClosedPublic

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	24908		Jan 15 2021, 6:09 PM	★	★
Diff 2	24917		Jan 15 2021, 8:23 PM	★	★
Diff 3	24920		Jan 15 2021, 8:58 PM	★	★
Diff 4	25106		Jan 18 2021, 8:54 AM	★	★
Diff 5	25265		Jan 26 2021, 1:31 AM	★	★
Diff 6	25300	rHGb44cc9ed5c74c506a1b18d4c325bdc8048ea3f5b	Jan 15 2021, 5:49 PM	★	★

Commit	Parents	Author	Summary	Date
506e276c6607	61cbed5190e7	Pierre-Yves David		Jan 15 2021, 5:49 PM

Status	Author	Revision
Closed	marmoute	D9796 copies: add an devel option to trace all files
Closed	marmoute	D9795 copies: simplify the conditional for _filter's case 3
Closed	marmoute	D9794 copies: clarify which case some conditional are handling
Closed	marmoute	D9802 copies: explicitly filter out existing file in graftcopies
Closed	marmoute	D9793 copies: fix some comment in _filter

Diff 24908

	#			#
	# _chain() takes care of chaining the copies in 'a' and 'b', but it			# _chain() takes care of chaining the copies in 'a' and 'b', but it
	# cannot tell the difference between cases 1 and 2, between 3 and 4, or			# cannot tell the difference between cases 1 and 2, between 3 and 4, or
	# between 5 and 6, so it includes all cases in its result.			# between 5 and 6, so it includes all cases in its result.
	# Cases 1, 3, and 5 are then removed by _filter().			# Cases 1, 3, and 5 are then removed by _filter().

	for k, v in list(t.items()):			for k, v in list(t.items()):
	# remove copies from files that didn't exist			# remove copies from files that didn't exist
	if v not in src:			if v not in src: # case 5
	del t[k]			del t[k]
	# remove criss-crossed copies			# remove criss-crossed copies
	elif k in src and v in dst:			elif k in src and v in dst:
	del t[k]			del t[k]
	# remove copies to files that were then removed			# remove copies to files that were then removed
	elif k not in dst:			elif k not in dst: # case 1
	del t[k]			del t[k]


	def _chain(prefix, suffix):			def _chain(prefix, suffix):
	"""chain two sets of copies 'prefix' and 'suffix'"""			"""chain two sets of copies 'prefix' and 'suffix'"""
	result = prefix.copy()			result = prefix.copy()
	for key, value in pycompat.iteritems(suffix):			for key, value in pycompat.iteritems(suffix):
	result[key] = prefix.get(value, value)			result[key] = prefix.get(value, value)