Page MenuHomePhabricator

persistent-nodemap: also exchange the nodemap data over the wire
ClosedPublic

Authored by marmoute on Jan 17 2021, 2:29 PM.

Details

Summary

It appears that 2 bytes are never equals to 3 bytes.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 17 2021, 2:29 PM
baymax updated this revision to Diff 25088.Jan 17 2021, 3:46 PM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

mharbison72 accepted this revision.Jan 17 2021, 5:05 PM
This revision is now accepted and ready to land.Jan 17 2021, 5:05 PM
indygreg added inline comments.
mercurial/store.py
394โ€“396

This could be f.endswith((b'.i', b'.d', b'.n', b'.nd')), which is easier to read IMO. I also suspect it might be slightly more efficient.

marmoute added inline comments.Jan 25 2021, 10:34 AM
mercurial/store.py
394โ€“396

Ho right, I'll send a follow up