( )⚙ D9816 run-tests: catch a Windows specific error when testing for a free socket

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9816

run-tests: catch a Windows specific error when testing for a free socket
ClosedPublic

Authored by mharbison72 on Jan 18 2021, 1:45 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG85c0c7145f8e: run-tests: catch a Windows specific error when testing for a free socket
Summary

I'm not sure why this only happens with py3, but this error code doesn't map to
any of the 3 currently being handled, and kills run-tests.py before it can run
any tests when it happens:

OSError: [WinError 10013] An attempt was made to access a socket in a way
forbidden by its access permissions

The documentation[1] says this can happen if another process is bound to the
address with exclusive access. This seems to keep it happy.

[1] https://docs.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jan 18 2021, 1:45 AM
pulkit accepted this revision.Jan 18 2021, 8:51 AM
This revision is now accepted and ready to land.Jan 18 2021, 8:51 AM

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (4 lines)

Diff 25113

tests/run-tests.py

family = socket.AF_INET6 family = socket.AF_INET6
else: else:
family = socket.AF_INET family = socket.AF_INET
try: try:
with contextlib.closing(socket.socket(family, socket.SOCK_STREAM)) as s: with contextlib.closing(socket.socket(family, socket.SOCK_STREAM)) as s:
s.bind(('localhost', port)) s.bind(('localhost', port))
return True return True
except socket.error as exc: except socket.error as exc:
if exc.errno not in ( if os.name == 'nt' and exc.errno == errno.WSAEACCES:
return False
elif exc.errno not in (
errno.EADDRINUSE, errno.EADDRINUSE,
errno.EADDRNOTAVAIL, errno.EADDRNOTAVAIL,
errno.EPROTONOSUPPORT, errno.EPROTONOSUPPORT,
): ):
raise raise
return False return False