This is an archive of the discontinued Mercurial Phabricator instance.

dirstate: move the _dirfoldmap to dirstatemap
ClosedPublic

Authored by durham on Oct 6 2017, 1:19 PM.

Details

Summary

Now that dirstatemap is the source of truth for the list of directories, let's
move _dirfoldmap on to it.

This pattern of moving cached variables onto the dirstate map makes it easier to
invalidate them, as seen by how the cache invalidation functions are slowly
shrinking to just be recreating the dirstatemap instance.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durham created this revision.Oct 6 2017, 1:19 PM
quark accepted this revision.Oct 10 2017, 3:36 PM
quark added a subscriber: quark.

The series looks straightforward. After the change, it might make sense to rename _map to _storage or something to make it clear that it contains extra logic than just a map.

durin42 accepted this revision.Oct 14 2017, 12:29 AM
This revision is now accepted and ready to land.Oct 14 2017, 12:29 AM
This revision was automatically updated to reflect the committed changes.