Page MenuHomePhabricator

share-share: have the hint issue more consistently and point to the right doc
ClosedPublic

Authored by marmoute on Jan 20 2021, 6:53 AM.

Details

Summary

This should help user in trouble to find solution in the documentation.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 20 2021, 6:53 AM
baymax updated this revision to Diff 25175.Jan 20 2021, 7:33 AM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

pulkit accepted this revision.Jan 21 2021, 6:15 AM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
mercurial/localrepo.py
622

Since we are using the same hint now, we can assign it before the if-else.

This revision is now accepted and ready to land.Jan 21 2021, 6:15 AM
baymax updated this revision to Diff 25197.Jan 21 2021, 8:26 AM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

marmoute added inline comments.Jan 21 2021, 9:23 AM
mercurial/localrepo.py
622

good catch. This is now so.

mharbison72 accepted this revision.Jan 21 2021, 11:15 PM