This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9852

rust: lower compile error on non-linux platforms to a warning
ClosedPublic

Authored by danchr on Jan 22 2021, 5:15 AM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHGcabc5e9366c5: rust: lower compile error on non-linux platforms to a warning
Summary

As discussed on D9671#146704 this lowers the error to a warning.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

danchr created this revision.Jan 22 2021, 5:15 AM
danchr edited the summary of this revision. (Show Details)Jan 22 2021, 5:18 AM
danchr added a reviewer: Alphare.
danchr updated this revision to Diff 25218.Jan 22 2021, 5:19 AM
Alphare accepted this revision.Jan 22 2021, 5:20 AM

I'd use a capital R in Rust but aside from that nitpick I'm all for it.

pulkit accepted this revision.Jan 22 2021, 11:35 AM
This revision is now accepted and ready to land.Jan 22 2021, 11:35 AM

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/lib.rs (8 lines)
Msetup.py (6 lines)

Diff 25224

rust/hg-core/src/lib.rs

pub mod matchers; pub mod matchers;
pub mod repo; pub mod repo;
pub mod revlog; pub mod revlog;
pub use revlog::*; pub use revlog::*;
pub mod config; pub mod config;
pub mod operations; pub mod operations;
pub mod utils; pub mod utils;
// Remove this to see (potential) non-artificial compile failures. MacOS
// *should* compile, but fail to compile tests for example as of 2020-03-06
#[cfg(not(target_os = "linux"))]
compile_error!(
"`hg-core` has only been tested on Linux and will most \
likely not behave correctly on other platforms."
);
use crate::utils::hg_path::{HgPathBuf, HgPathError}; use crate::utils::hg_path::{HgPathBuf, HgPathError};
pub use filepatterns::{ pub use filepatterns::{
parse_pattern_syntax, read_pattern_file, IgnorePattern, parse_pattern_syntax, read_pattern_file, IgnorePattern,
PatternFileWarning, PatternSyntax, PatternFileWarning, PatternSyntax,
}; };
use std::collections::HashMap; use std::collections::HashMap;
use twox_hash::RandomXxHashBuilder64; use twox_hash::RandomXxHashBuilder64;

setup.py

self.extensions = [ self.extensions = [
e for e in self.extensions if e.name != 'mercurial.zstd' e for e in self.extensions if e.name != 'mercurial.zstd'
] ]
# Build Rust standalon extensions if it'll be used # Build Rust standalon extensions if it'll be used
# and its build is not explictely disabled (for external build # and its build is not explictely disabled (for external build
# as Linux distributions would do) # as Linux distributions would do)
if self.distribution.rust and self.rust: if self.distribution.rust and self.rust:
if not sys.platform.startswith('linux'):
self.warn(
"rust extensions have only been tested on Linux "
"and may not behave correctly on other platforms"
)
for rustext in ruststandalones: for rustext in ruststandalones:
rustext.build('' if self.inplace else self.build_lib) rustext.build('' if self.inplace else self.build_lib)
return build_ext.build_extensions(self) return build_ext.build_extensions(self)
def build_extension(self, ext): def build_extension(self, ext):
if ( if (
self.distribution.rust self.distribution.rust