This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9865

store: use `endswith` to detect revlog extension
ClosedPublic

Authored by marmoute on Jan 25 2021, 4:32 PM.

Details

Reviewers
SimonSapin
mharbison72
Group Reviewers
hg-reviewers
Commits
rHG374d7fff7cb5: store: use `endswith` to detect revlog extension
rHG40914ec4bc05: store: use `endswith` to detect revlog extension
Summary

Suggested by Gregory Szorc.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jan 25 2021, 4:32 PM
SimonSapin accepted this revision.Jan 26 2021, 1:16 AM
SimonSapin added a subscriber: SimonSapin.

Today I learned about tuple argument for endswith. Looks good.

mharbison72 accepted this revision.Jan 26 2021, 1:18 AM
This revision is now accepted and ready to land.Jan 26 2021, 1:18 AM
marmoute added a commit: rHG40914ec4bc05: store: use `endswith` to detect revlog extension.Jan 26 2021, 1:22 AM
Closed by commit rHG40914ec4bc05: store: use `endswith` to detect revlog extension (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/store.py (5 lines)

Diff 25247

mercurial/store.py

b'00manifest.i', b'00manifest.i',
b'00changelog.d', b'00changelog.d',
b'00changelog.i', b'00changelog.i',
b'phaseroots', b'phaseroots',
b'obsstore', b'obsstore',
b'requires', b'requires',
] ]
REVLOG_FILES_EXT = (b'.i', b'.d', b'.n', b'.nd')
def isrevlog(f, kind, st): def isrevlog(f, kind, st):
if kind != stat.S_IFREG: if kind != stat.S_IFREG:
return False return False
if f[-2:] in (b'.i', b'.d', b'.n'): return f.endswith(REVLOG_FILES_EXT)
return True
return f[-3:] == b'.nd'
class basicstore(object): class basicstore(object):
'''base class for local repository stores''' '''base class for local repository stores'''
def __init__(self, path, vfstype): def __init__(self, path, vfstype):
vfs = vfstype(path) vfs = vfstype(path)
self.path = vfs.base self.path = vfs.base