This is an archive of the discontinued Mercurial Phabricator instance.

run-test: avoid byte issue when replacing output file of python test
ClosedPublic

Authored by marmoute on Jan 25 2021, 9:36 PM.

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

Summary

Otherwise we get error like::

FileNotFoundError: [Errno 2] No such file or directory: "b'…/tests/test-minirst.py'.out"

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision is now accepted and ready to land.Jan 26 2021, 2:59 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/run-tests.py (2 lines)

Status	Author	Revision
Closed	marmoute	D9872 command-namespace: use `::` are the command separator
Closed	marmoute	D9871 perf: test the formatting of a command help
Closed	marmoute	D9870 help: escape ':' (as '\:') when generating command names
Closed	marmoute	D9869 minirst: respect escaping in definition list key
Closed	marmoute	D9868 run-test: avoid byte issue when replacing output file of python test

	else:			else:
	self.stream.write('Accept this change? [y/N] ')			self.stream.write('Accept this change? [y/N] ')
	self.stream.flush()			self.stream.flush()
	answer = sys.stdin.readline().strip()			answer = sys.stdin.readline().strip()
	if answer.lower() in ('y', 'yes'):			if answer.lower() in ('y', 'yes'):
	if test.path.endswith(b'.t'):			if test.path.endswith(b'.t'):
	rename(test.errpath, test.path)			rename(test.errpath, test.path)
	else:			else:
	rename(test.errpath, '%s.out' % test.path)			rename(test.errpath, b'%s.out' % test.path)
	accepted = True			accepted = True
	if not accepted:			if not accepted:
	self.faildata[test.name] = b''.join(lines)			self.faildata[test.name] = b''.join(lines)

	return accepted			return accepted

	def startTest(self, test):			def startTest(self, test):
	super(TestResult, self).startTest(test)			super(TestResult, self).startTest(test)