This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9868

run-test: avoid byte issue when replacing output file of python test
ClosedPublic

Authored by marmoute on Jan 25 2021, 9:36 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7bb31c367847: run-test: avoid byte issue when replacing output file of python test
rHG2bd77a6d3c2b: run-test: avoid byte issue when replacing output file of python test
Summary

Otherwise we get error like::

FileNotFoundError: [Errno 2] No such file or directory: "b'…/tests/test-minirst.py'.out"

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (2 lines)

Diff 25250

tests/run-tests.py

else: else:
self.stream.write('Accept this change? [y/N] ') self.stream.write('Accept this change? [y/N] ')
self.stream.flush() self.stream.flush()
answer = sys.stdin.readline().strip() answer = sys.stdin.readline().strip()
if answer.lower() in ('y', 'yes'): if answer.lower() in ('y', 'yes'):
if test.path.endswith(b'.t'): if test.path.endswith(b'.t'):
rename(test.errpath, test.path) rename(test.errpath, test.path)
else: else:
rename(test.errpath, '%s.out' % test.path) rename(test.errpath, b'%s.out' % test.path)
accepted = True accepted = True
if not accepted: if not accepted:
self.faildata[test.name] = b''.join(lines) self.faildata[test.name] = b''.join(lines)
return accepted return accepted
def startTest(self, test): def startTest(self, test):
super(TestResult, self).startTest(test) super(TestResult, self).startTest(test)