This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9884

changegroup: don't convert revisions to node for duplicate handling
ClosedPublic

Authored by joerg.sonnenberger on Jan 26 2021, 9:10 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGfa7ae7aa0efd: changegroup: don't convert revisions to node for duplicate handling
rHGf7fd34afd1cc: changegroup: don't convert revisions to node for duplicate handling
Summary

The only consumer can handle revision lists fine. Avoid
materializing a range if there are no duplicates as optimization.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 25568

mercurial/changegroup.py

repo.ui.status(_(b"adding changesets\n")) repo.ui.status(_(b"adding changesets\n"))
clstart = len(cl) clstart = len(cl)
progress = repo.ui.makeprogress( progress = repo.ui.makeprogress(
_(b'changesets'), unit=_(b'chunks'), total=expectedtotal _(b'changesets'), unit=_(b'chunks'), total=expectedtotal
) )
self.callback = progress.increment self.callback = progress.increment
efilesset = set() efilesset = set()
cgnodes = [] duprevs = []
def ondupchangelog(cl, rev): def ondupchangelog(cl, rev):
if rev < clstart: if rev < clstart:
cgnodes.append(cl.node(rev)) duprevs.append(rev)
def onchangelog(cl, rev): def onchangelog(cl, rev):
ctx = cl.changelogrevision(rev) ctx = cl.changelogrevision(rev)
efilesset.update(ctx.files) efilesset.update(ctx.files)
repo.register_changeset(rev, ctx) repo.register_changeset(rev, ctx)
self.changelogheader() self.changelogheader()
deltas = self.deltaiter() deltas = self.deltaiter()
# Those changesets have been pushed from the # Those changesets have been pushed from the
# outside, their phases are going to be pushed # outside, their phases are going to be pushed
# alongside. Therefor `targetphase` is # alongside. Therefor `targetphase` is
# ignored. # ignored.
targetphase = phaseall = phases.draft targetphase = phaseall = phases.draft
if added: if added:
phases.registernew(repo, tr, targetphase, added) phases.registernew(repo, tr, targetphase, added)
if phaseall is not None: if phaseall is not None:
phases.advanceboundary(repo, tr, phaseall, cgnodes, revs=added) if duprevs:
cgnodes = [] duprevs.extend(added)
else:
duprevs = added
phases.advanceboundary(repo, tr, phaseall, [], revs=duprevs)
duprevs = []
if changesets > 0: if changesets > 0:
def runhooks(unused_success): def runhooks(unused_success):
# These hooks run when the lock releases, not when the # These hooks run when the lock releases, not when the
# transaction closes. So it's possible for the changelog # transaction closes. So it's possible for the changelog
# to have changed since we last saw it. # to have changed since we last saw it.
if clstart >= len(repo): if clstart >= len(repo):