The node is passed as argument already, so returning it is quite
pointless. The revision number on the other is useful as it decouples
the caller from the revlog internals.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/revlog.py (5 lines) |
| Status | Author | Revision | |
|---|---|---|---|
| Closed | joerg.sonnenberger | ||
| Closed | joerg.sonnenberger | ||
| Closed | joerg.sonnenberger | ||
| Closed | joerg.sonnenberger | ||
| Closed | joerg.sonnenberger |
| useful when reusing a revision not stored in this revlog (ex: received | useful when reusing a revision not stored in this revlog (ex: received | ||||
| over wire, or read from an external bundle). | over wire, or read from an external bundle). | ||||
| """ | """ | ||||
| dfh = None | dfh = None | ||||
| if not self._inline: | if not self._inline: | ||||
| dfh = self._datafp(b"a+") | dfh = self._datafp(b"a+") | ||||
| ifh = self._indexfp(b"a+") | ifh = self._indexfp(b"a+") | ||||
| try: | try: | ||||
| return self._addrevision( | self._addrevision( | ||||
| node, | node, | ||||
| rawtext, | rawtext, | ||||
| transaction, | transaction, | ||||
| link, | link, | ||||
| p1, | p1, | ||||
| p2, | p2, | ||||
| flags, | flags, | ||||
| cachedelta, | cachedelta, | ||||
| ifh, | ifh, | ||||
| dfh, | dfh, | ||||
| deltacomputer=deltacomputer, | deltacomputer=deltacomputer, | ||||
| ) | ) | ||||
| return node | |||||
| finally: | finally: | ||||
| if dfh: | if dfh: | ||||
| dfh.close() | dfh.close() | ||||
| ifh.close() | ifh.close() | ||||
| def compress(self, data): | def compress(self, data): | ||||
| """Generate a possibly-compressed representation of data.""" | """Generate a possibly-compressed representation of data.""" | ||||
| if not data: | if not data: | ||||
| rawtext = btext[0] | rawtext = btext[0] | ||||
| if alwayscache and rawtext is None: | if alwayscache and rawtext is None: | ||||
| rawtext = deltacomputer.buildtext(revinfo, fh) | rawtext = deltacomputer.buildtext(revinfo, fh) | ||||
| if type(rawtext) == bytes: # only accept immutable objects | if type(rawtext) == bytes: # only accept immutable objects | ||||
| self._revisioncache = (node, curr, rawtext) | self._revisioncache = (node, curr, rawtext) | ||||
| self._chainbasecache[curr] = deltainfo.chainbase | self._chainbasecache[curr] = deltainfo.chainbase | ||||
| return node | return curr | ||||
| def _writeentry(self, transaction, ifh, dfh, entry, data, link, offset): | def _writeentry(self, transaction, ifh, dfh, entry, data, link, offset): | ||||
| # Files opened in a+ mode have inconsistent behavior on various | # Files opened in a+ mode have inconsistent behavior on various | ||||
| # platforms. Windows requires that a file positioning call be made | # platforms. Windows requires that a file positioning call be made | ||||
| # when the file handle transitions between reads and writes. See | # when the file handle transitions between reads and writes. See | ||||
| # 3686fa2b8eee and the mixedfilemodewrapper in windows.py. On other | # 3686fa2b8eee and the mixedfilemodewrapper in windows.py. On other | ||||
| # platforms, Python or the platform itself can be buggy. Some versions | # platforms, Python or the platform itself can be buggy. Some versions | ||||
| # of Solaris have been observed to not append at the end of the file | # of Solaris have been observed to not append at the end of the file | ||||