This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9888

black: show required version in skip message
ClosedPublic

Authored by marmoute on Jan 27 2021, 9:54 AM.

Details

Reviewers
joerg.sonnenberger
pulkit
Group Reviewers
hg-reviewers
Commits
rHG959d581bb625: black: show required version in skip message
Summary

This will help people to configure their black

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jan 27 2021, 9:54 AM
joerg.sonnenberger accepted this revision.Jan 27 2021, 10:21 AM
joerg.sonnenberger added a subscriber: joerg.sonnenberger.

I like the change.

baymax retitled this revision from black: issue version information in the skip message to black: show required version in skip message.Jan 27 2021, 11:19 AM
baymax updated this revision to Diff 25310.

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Jan 28 2021, 1:21 PM
This revision is now accepted and ready to land.Jan 28 2021, 1:21 PM
marmoute added a commit: rHG959d581bb625: black: show required version in skip message.Jan 28 2021, 4:15 PM
Closed by commit rHG959d581bb625: black: show required version in skip message (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (2 lines)

Diff 25305

tests/hghave.py

@check('emacs', 'GNU Emacs') @check('emacs', 'GNU Emacs')
def has_emacs(): def has_emacs():
# Our emacs lisp uses `with-eval-after-load` which is new in emacs # Our emacs lisp uses `with-eval-after-load` which is new in emacs
# 24.4, so we allow emacs 24.4, 24.5, and 25+ (24.5 was the last # 24.4, so we allow emacs 24.4, 24.5, and 25+ (24.5 was the last
# 24 release) # 24 release)
return matchoutput('emacs --version', b'GNU Emacs 2(4.4|4.5|5|6|7|8|9)') return matchoutput('emacs --version', b'GNU Emacs 2(4.4|4.5|5|6|7|8|9)')
@check('black', 'the black formatter for python') @check('black', 'the black formatter for python (>= 20.8b1)')
def has_black(): def has_black():
blackcmd = 'black --version' blackcmd = 'black --version'
version_regex = b'black, version ([0-9a-b.]+)' version_regex = b'black, version ([0-9a-b.]+)'
version = matchoutput(blackcmd, version_regex) version = matchoutput(blackcmd, version_regex)
sv = distutils.version.StrictVersion sv = distutils.version.StrictVersion
return version and sv(_bytes2sys(version.group(1))) >= sv('20.8b1') return version and sv(_bytes2sys(version.group(1))) >= sv('20.8b1')