This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9890

clang-format: show required version in skip message
ClosedPublic

Authored by marmoute on Jan 27 2021, 9:55 AM.

Details

Reviewers
joerg.sonnenberger
Group Reviewers
hg-reviewers
Commits
rHG9fd4f7af42ea: clang-format: show required version in skip message
Summary

This will help people to configure their black

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jan 27 2021, 9:55 AM
joerg.sonnenberger accepted this revision.Jan 27 2021, 10:22 AM
joerg.sonnenberger added a subscriber: joerg.sonnenberger.

I like the change.

baymax retitled this revision from clang-format: issue version information in the skip message to clang-format: show required version in skip message.Jan 27 2021, 11:19 AM
baymax updated this revision to Diff 25312.

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit added a subscriber: pulkit.Jan 28 2021, 1:22 PM

This will help people to configure their black

s/black/clang-format in flight

marmoute added a commit: rHG9fd4f7af42ea: clang-format: show required version in skip message.Jan 28 2021, 4:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG9fd4f7af42ea: clang-format: show required version in skip message (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (2 lines)

Diff 25312

tests/hghave.py

return True return True
@check("pylint", "Pylint python linter") @check("pylint", "Pylint python linter")
def has_pylint(): def has_pylint():
return matchoutput("pylint --help", br"Usage:[ ]+pylint", True) return matchoutput("pylint --help", br"Usage:[ ]+pylint", True)
@check("clang-format", "clang-format C code formatter") @check("clang-format", "clang-format C code formatter (>= 11)")
def has_clang_format(): def has_clang_format():
m = matchoutput('clang-format --version', br'clang-format version (\d+)') m = matchoutput('clang-format --version', br'clang-format version (\d+)')
# style changed somewhere between 10.x and 11.x # style changed somewhere between 10.x and 11.x
return m and int(m.group(1)) >= 11 return m and int(m.group(1)) >= 11
@check("jshint", "JSHint static code analysis tool") @check("jshint", "JSHint static code analysis tool")
def has_jshint(): def has_jshint():