Page MenuHomePhabricator

persistent-nodemap: Fix Rust declarations for Revlog_CAPI signatures
ClosedPublic

Authored by SimonSapin on Jan 28 2021, 7:41 AM.

Details

Summary

Use Rust’s libc::ssize_t as the closest match to C’s Py_ssize_t.
See details in test comment.

Going forward we should find a way to have such Rust declarations
auto-generated from C headers at build time,
or auto-checked against them in a test.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Jan 28 2021, 7:41 AM
SimonSapin updated this revision to Diff 25344.Jan 28 2021, 7:45 AM

This two patches are for the stable branch.

Alphare accepted this revision.Jan 28 2021, 7:47 AM
pulkit accepted this revision.Jan 28 2021, 1:17 PM
This revision is now accepted and ready to land.Jan 28 2021, 1:17 PM