This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9910

errors: use exit code 40 for when a hook fails
ClosedPublic

Authored by martinvonz on Jan 29 2021, 5:46 PM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHG768056549737: errors: use exit code 40 for when a hook fails
Summary

A hook can be used for checking inputs, state, configuration,
security, etc., so it's unclear which of the existing exit codes to
use. Let's instead add one specifically for failed hooks. I picked 40.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 29 2021, 5:46 PM
pulkit accepted this revision.Jan 31 2021, 1:15 PM
pulkit added a subscriber: pulkit.

Reviewing this patch made me realize that we don't have any help for exit codes. Might be a good idea to have hg help exitcodes or something similar.

This revision is now accepted and ready to land.Jan 31 2021, 1:15 PM
martinvonz added a commit: rHG768056549737: errors: use exit code 40 for when a hook fails.Jan 31 2021, 2:46 PM
Closed by commit rHG768056549737: errors: use exit code 40 for when a hook fails (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25404

mercurial/scmutil.py

ui.error(_(b"abort: working directory revision cannot be specified\n")) ui.error(_(b"abort: working directory revision cannot be specified\n"))
except error.Abort as inst: except error.Abort as inst:
if isinstance(inst, (error.InputError, error.ParseError)): if isinstance(inst, (error.InputError, error.ParseError)):
detailed_exit_code = 10 detailed_exit_code = 10
elif isinstance(inst, error.StateError): elif isinstance(inst, error.StateError):
detailed_exit_code = 20 detailed_exit_code = 20
elif isinstance(inst, error.ConfigError): elif isinstance(inst, error.ConfigError):
detailed_exit_code = 30 detailed_exit_code = 30
elif isinstance(inst, error.HookAbort):
detailed_exit_code = 40
elif isinstance(inst, error.SecurityError): elif isinstance(inst, error.SecurityError):
detailed_exit_code = 150 detailed_exit_code = 150
elif isinstance(inst, error.CanceledError): elif isinstance(inst, error.CanceledError):
detailed_exit_code = 250 detailed_exit_code = 250
ui.error(inst.format()) ui.error(inst.format())
except error.WorkerError as inst: except error.WorkerError as inst:
# Don't print a message -- the worker already should have # Don't print a message -- the worker already should have
return inst.status_code return inst.status_code

tests/test-bookmarks-pushpull.t

#endif #endif
#if b2-binary #if b2-binary
$ hg push -B @ local $ hg push -B @ local
pushing to $TESTTMP/issue4455-dest pushing to $TESTTMP/issue4455-dest
searching for changes searching for changes
no changes found no changes found
abort: prepushkey hook exited with status 1 abort: prepushkey hook exited with status 1
[255] [40]
#endif #endif
$ hg -R ../issue4455-dest/ bookmarks $ hg -R ../issue4455-dest/ bookmarks
no bookmarks set no bookmarks set
Using ssh Using ssh
--------- ---------

tests/test-bookmarks.t

$ cd unrelated $ cd unrelated
$ echo a > a $ echo a > a
$ hg add a $ hg add a
$ hg commit -m '#0' $ hg commit -m '#0'
$ hg --config hooks.pretxnclose="sh $TESTTMP/savepending.sh" bookmarks INVISIBLE $ hg --config hooks.pretxnclose="sh $TESTTMP/savepending.sh" bookmarks INVISIBLE
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose hook exited with status 1 abort: pretxnclose hook exited with status 1
[255] [40]
$ cp .hg/bookmarks.pending.saved .hg/bookmarks.pending $ cp .hg/bookmarks.pending.saved .hg/bookmarks.pending
(check visible bookmarks while transaction running in repo) (check visible bookmarks while transaction running in repo)
$ cat > $TESTTMP/checkpending.sh <<EOF $ cat > $TESTTMP/checkpending.sh <<EOF
> echo "@repo" > echo "@repo"
> hg -R "$TESTTMP/repo" bookmarks > hg -R "$TESTTMP/repo" bookmarks
> echo "@unrelated" > echo "@unrelated"
four 3:9ba5f110a0b3 four 3:9ba5f110a0b3
should-end-on-two 2:db815d6d32e6 should-end-on-two 2:db815d6d32e6
x y 2:db815d6d32e6 x y 2:db815d6d32e6
@unrelated @unrelated
no bookmarks set no bookmarks set
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose hook exited with status 1 abort: pretxnclose hook exited with status 1
[255] [40]
Check pretxnclose-bookmark can abort a transaction Check pretxnclose-bookmark can abort a transaction
-------------------------------------------------- --------------------------------------------------
add hooks: add hooks:
* to prevent NEW bookmark on a non-public changeset * to prevent NEW bookmark on a non-public changeset
* to prevent non-forward move of NEW bookmark * to prevent non-forward move of NEW bookmark
attempt to create on a default changeset attempt to create on a default changeset
$ hg bookmark -r 81dcce76aa0b NEW $ hg bookmark -r 81dcce76aa0b NEW
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose-bookmark.force-public hook exited with status 1 abort: pretxnclose-bookmark.force-public hook exited with status 1
[255] [40]
create on a public changeset create on a public changeset
$ hg bookmark -r 9ba5f110a0b3 NEW $ hg bookmark -r 9ba5f110a0b3 NEW
move to the other branch move to the other branch
$ hg bookmark -f -r 125c9a1d6df6 NEW $ hg bookmark -f -r 125c9a1d6df6 NEW
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose-bookmark.force-forward hook exited with status 1 abort: pretxnclose-bookmark.force-forward hook exited with status 1
[255] [40]

tests/test-bundle2-exchange.t

remote: adding manifests remote: adding manifests
remote: adding file changes remote: adding file changes
remote: pre-close-tip:e7ec4e813ba6 draft remote: pre-close-tip:e7ec4e813ba6 draft
remote: You shall not pass! remote: You shall not pass!
remote: transaction abort! remote: transaction abort!
remote: Cleaning up the mess... remote: Cleaning up the mess...
remote: rollback completed remote: rollback completed
abort: pretxnclose.failpush hook exited with status 1 abort: pretxnclose.failpush hook exited with status 1
[255] [40]
$ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6 $ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6
pushing to ssh://user@dummy/other pushing to ssh://user@dummy/other
searching for changes searching for changes
remote: adding changesets remote: adding changesets
remote: adding manifests remote: adding manifests
remote: adding file changes remote: adding file changes
remote: pre-close-tip:e7ec4e813ba6 draft remote: pre-close-tip:e7ec4e813ba6 draft
remote: adding changesets remote: adding changesets
remote: adding manifests remote: adding manifests
remote: adding file changes remote: adding file changes
remote: Fail early! remote: Fail early!
remote: transaction abort! remote: transaction abort!
remote: Cleaning up the mess... remote: Cleaning up the mess...
remote: rollback completed remote: rollback completed
abort: pretxnchangegroup hook exited with status 1 abort: pretxnchangegroup hook exited with status 1
[255] [40]
$ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6 $ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6
pushing to ssh://user@dummy/other pushing to ssh://user@dummy/other
searching for changes searching for changes
remote: adding changesets remote: adding changesets
remote: adding manifests remote: adding manifests
remote: adding file changes remote: adding file changes
remote: Fail early! remote: Fail early!
remote: transaction abort! remote: transaction abort!
adding changesets adding changesets
adding manifests adding manifests
adding file changes adding file changes
Fail early! Fail early!
transaction abort! transaction abort!
Cleaning up the mess... Cleaning up the mess...
rollback completed rollback completed
abort: pretxnchangegroup hook exited with status 1 abort: pretxnchangegroup hook exited with status 1
[255] [40]
$ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6 $ hg -R main push ssh://user@dummy/other -r e7ec4e813ba6
pushing to ssh://user@dummy/other pushing to ssh://user@dummy/other
searching for changes searching for changes
remote: adding changesets remote: adding changesets
remote: adding manifests remote: adding manifests
remote: adding file changes remote: adding file changes
remote: Fail early! remote: Fail early!
remote: transaction abort! remote: transaction abort!

tests/test-commandserver.t

... readchannel(server) ... readchannel(server)
... runcommand(server, [b'commit', b'--config', b'hooks.pretxncommit=false', ... runcommand(server, [b'commit', b'--config', b'hooks.pretxncommit=false',
... b'-mfoo']) ... b'-mfoo'])
... runcommand(server, [b'verify']) ... runcommand(server, [b'verify'])
*** runcommand commit --config hooks.pretxncommit=false -mfoo *** runcommand commit --config hooks.pretxncommit=false -mfoo
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit hook exited with status 1 abort: pretxncommit hook exited with status 1
[255] [40]
*** runcommand verify *** runcommand verify
checking changesets checking changesets
checking manifests checking manifests
crosschecking files in changesets and manifests crosschecking files in changesets and manifests
checking files checking files
checked 2 changesets with 2 changes to 1 files checked 2 changesets with 2 changes to 1 files
$ hg revert --no-backup -aq $ hg revert --no-backup -aq
... b'--config', b'hooks.pretxncommit=false', ... b'--config', b'hooks.pretxncommit=false',
... b'-mfoo']) ... b'-mfoo'])
... runcommand(server, [b'log']) ... runcommand(server, [b'log'])
... runcommand(server, [b'verify', b'-q']) ... runcommand(server, [b'verify', b'-q'])
*** runcommand commit --config hooks.pretxncommit=false -mfoo *** runcommand commit --config hooks.pretxncommit=false -mfoo
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit hook exited with status 1 abort: pretxncommit hook exited with status 1
[255] [40]
*** runcommand log *** runcommand log
*** runcommand verify -q *** runcommand verify -q
(failure after finalization) (failure after finalization)
>>> from hgclient import check, readchannel, runcommand >>> from hgclient import check, readchannel, runcommand
>>> @check >>> @check
... def abort(server): ... def abort(server):
... b'--config', b'hooks.pretxncommit=false', ... b'--config', b'hooks.pretxncommit=false',
... b'-mfoo', b'foo']) ... b'-mfoo', b'foo'])
... runcommand(server, [b'log']) ... runcommand(server, [b'log'])
... runcommand(server, [b'verify', b'-q']) ... runcommand(server, [b'verify', b'-q'])
*** runcommand commit --config hooks.pretxncommit=false -mfoo foo *** runcommand commit --config hooks.pretxncommit=false -mfoo foo
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit hook exited with status 1 abort: pretxncommit hook exited with status 1
[255] [40]
*** runcommand log *** runcommand log
0 bar (bar) 0 bar (bar)
*** runcommand verify -q *** runcommand verify -q
(failure after finalization) (failure after finalization)
>>> from hgclient import check, readchannel, runcommand >>> from hgclient import check, readchannel, runcommand
>>> @check >>> @check

tests/test-commit-amend.t

committing files: committing files:
a a
committing manifest committing manifest
committing changelog committing changelog
running hook pretxncommit.test-saving-last-message: false running hook pretxncommit.test-saving-last-message: false
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit.test-saving-last-message hook exited with status 1 abort: pretxncommit.test-saving-last-message hook exited with status 1
[255] [40]
$ cat .hg/last-message.txt $ cat .hg/last-message.txt
message given from command line (no-eol) message given from command line (no-eol)
$ rm -f .hg/last-message.txt $ rm -f .hg/last-message.txt
$ HGEDITOR="\"sh\" \"`pwd`/editor.sh\"" hg commit --amend -v $ HGEDITOR="\"sh\" \"`pwd`/editor.sh\"" hg commit --amend -v
amending changeset a9a13940fc03 amending changeset a9a13940fc03
copying changeset a9a13940fc03 to ad120869acf0 copying changeset a9a13940fc03 to ad120869acf0
no changes, new message no changes, new message
HG: Enter commit message. Lines beginning with 'HG:' are removed. HG: Enter commit message. Lines beginning with 'HG:' are removed.
HG: Leave message empty to abort commit. HG: Leave message empty to abort commit.
HG: -- HG: --
HG: user: foo HG: user: foo
HG: branch 'default' HG: branch 'default'
HG: changed a HG: changed a
committing files: committing files:
a a
committing manifest committing manifest
committing changelog committing changelog
running hook pretxncommit.test-saving-last-message: false running hook pretxncommit.test-saving-last-message: false
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit.test-saving-last-message hook exited with status 1 abort: pretxncommit.test-saving-last-message hook exited with status 1
[255] [40]
$ cat .hg/last-message.txt $ cat .hg/last-message.txt
another precious commit message another precious commit message
$ cat > .hg/hgrc << '__EOF__' $ cat > .hg/hgrc << '__EOF__'
> [hooks] > [hooks]
> pretxncommit.test-saving-last-message = > pretxncommit.test-saving-last-message =
> __EOF__ > __EOF__

tests/test-dispatch.t

abort: option --cwd may not be abbreviated abort: option --cwd may not be abbreviated
[10] [10]
$ HGPLAIN=+strictflags hg log -q -R . -b default $ HGPLAIN=+strictflags hg log -q -R . -b default
abort: option -R has to be separated from other options (e.g. not -qR) and --repository may only be abbreviated as --repo abort: option -R has to be separated from other options (e.g. not -qR) and --repository may only be abbreviated as --repo
[10] [10]
$ HGPLAIN=+strictflags hg --config='hooks.pre-log=false' log -b default $ HGPLAIN=+strictflags hg --config='hooks.pre-log=false' log -b default
abort: pre-log hook exited with status 1 abort: pre-log hook exited with status 1
[255] [40]
$ HGPLAIN=+strictflags hg --cwd .. -q -Ra log -b default $ HGPLAIN=+strictflags hg --cwd .. -q -Ra log -b default
0:cb9a9f314b8b 0:cb9a9f314b8b
$ HGPLAIN=+strictflags hg --cwd .. -q --repository a log -b default $ HGPLAIN=+strictflags hg --cwd .. -q --repository a log -b default
0:cb9a9f314b8b 0:cb9a9f314b8b
$ HGPLAIN=+strictflags hg --cwd .. -q --repo a log -b default $ HGPLAIN=+strictflags hg --cwd .. -q --repo a log -b default
0:cb9a9f314b8b 0:cb9a9f314b8b
For compatibility reasons, HGPLAIN=+strictflags is not enabled by plain HGPLAIN: For compatibility reasons, HGPLAIN=+strictflags is not enabled by plain HGPLAIN:
$ HGPLAIN= hg log --config='hooks.pre-log=false' -b default $ HGPLAIN= hg log --config='hooks.pre-log=false' -b default
abort: pre-log hook exited with status 1 abort: pre-log hook exited with status 1
[255] [40]
$ HGPLAINEXCEPT= hg log --cwd .. -q -Ra -b default $ HGPLAINEXCEPT= hg log --cwd .. -q -Ra -b default
0:cb9a9f314b8b 0:cb9a9f314b8b
[defaults] [defaults]
$ hg cat a $ hg cat a
a a
$ cat >> $HGRCPATH <<EOF $ cat >> $HGRCPATH <<EOF

tests/test-histedit-edit.t

HG: branch 'default' HG: branch 'default'
HG: added f HG: added f
==== ====
transaction abort! transaction abort!
rollback completed rollback completed
note: commit message saved in .hg/last-message.txt note: commit message saved in .hg/last-message.txt
note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it
abort: pretxncommit.unexpectedabort hook exited with status 1 abort: pretxncommit.unexpectedabort hook exited with status 1
[255] [40]
$ cat .hg/last-message.txt $ cat .hg/last-message.txt
f f
check saving last-message.txt check saving last-message.txt
(test also that editor is invoked if histedit is continued for "message" (test also that editor is invoked if histedit is continued for "message"
action) action)
$ HGEDITOR=cat hg histedit --continue $ HGEDITOR=cat hg histedit --continue
f f
HG: Enter commit message. Lines beginning with 'HG:' are removed. HG: Enter commit message. Lines beginning with 'HG:' are removed.
HG: Leave message empty to abort commit. HG: Leave message empty to abort commit.
HG: -- HG: --
HG: user: test HG: user: test
HG: branch 'default' HG: branch 'default'
HG: added f HG: added f
transaction abort! transaction abort!
rollback completed rollback completed
note: commit message saved in .hg/last-message.txt note: commit message saved in .hg/last-message.txt
note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it
abort: pretxncommit.unexpectedabort hook exited with status 1 abort: pretxncommit.unexpectedabort hook exited with status 1
[255] [40]
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [hooks] > [hooks]
> pretxncommit.unexpectedabort = > pretxncommit.unexpectedabort =
> EOF > EOF
$ hg histedit --abort -q $ hg histedit --abort -q
then, check "modify the message" itself then, check "modify the message" itself

tests/test-histedit-fold.t

HG: branch 'default' HG: branch 'default'
HG: added c HG: added c
HG: added d HG: added d
HG: added f HG: added f
==== ====
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit.abortfolding hook failed abort: pretxncommit.abortfolding hook failed
[255] [40]
$ cat .hg/last-message.txt $ cat .hg/last-message.txt
f f
*** ***
c c
*** ***
d d

tests/test-hook.t

$ hg id $ hg id
pre-identify hook: HG_ARGS=id pre-identify hook: HG_ARGS=id
HG_HOOKNAME=pre-identify HG_HOOKNAME=pre-identify
HG_HOOKTYPE=pre-identify HG_HOOKTYPE=pre-identify
HG_OPTS={'bookmarks': None, 'branch': None, 'id': None, 'insecure': None, 'num': None, 'remotecmd': '', 'rev': '', 'ssh': '', 'tags': None, 'template': ''} HG_OPTS={'bookmarks': None, 'branch': None, 'id': None, 'insecure': None, 'num': None, 'remotecmd': '', 'rev': '', 'ssh': '', 'tags': None, 'template': ''}
HG_PATS=[] HG_PATS=[]
abort: pre-identify hook exited with status 1 abort: pre-identify hook exited with status 1
[255] [40]
$ hg cat b $ hg cat b
pre-cat hook: HG_ARGS=cat b pre-cat hook: HG_ARGS=cat b
HG_HOOKNAME=pre-cat HG_HOOKNAME=pre-cat
HG_HOOKTYPE=pre-cat HG_HOOKTYPE=pre-cat
HG_OPTS={'decode': None, 'exclude': [], 'include': [], 'output': '', 'rev': '', 'template': ''} HG_OPTS={'decode': None, 'exclude': [], 'include': [], 'output': '', 'rev': '', 'template': ''}
HG_PATS=['b'] HG_PATS=['b']
b b
pretag.forbid hook: HG_HOOKNAME=pretag.forbid pretag.forbid hook: HG_HOOKNAME=pretag.forbid
HG_HOOKTYPE=pretag HG_HOOKTYPE=pretag
HG_LOCAL=0 HG_LOCAL=0
HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10 HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10
HG_TAG=fa HG_TAG=fa
abort: pretag.forbid hook exited with status 1 abort: pretag.forbid hook exited with status 1
[255] [40]
$ hg tag -l fla $ hg tag -l fla
pretag hook: HG_HOOKNAME=pretag pretag hook: HG_HOOKNAME=pretag
HG_HOOKTYPE=pretag HG_HOOKTYPE=pretag
HG_LOCAL=1 HG_LOCAL=1
HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10 HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10
HG_TAG=fla HG_TAG=fla
pretag.forbid hook: HG_HOOKNAME=pretag.forbid pretag.forbid hook: HG_HOOKNAME=pretag.forbid
HG_HOOKTYPE=pretag HG_HOOKTYPE=pretag
HG_LOCAL=1 HG_LOCAL=1
HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10 HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10
HG_TAG=fla HG_TAG=fla
abort: pretag.forbid hook exited with status 1 abort: pretag.forbid hook exited with status 1
[255] [40]
pretxncommit hook can see changeset, can roll back txn, changeset no pretxncommit hook can see changeset, can roll back txn, changeset no
more there after more there after
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> pretxncommit.forbid0 = sh -c "hg tip -q" > pretxncommit.forbid0 = sh -c "hg tip -q"
> pretxncommit.forbid1 = sh -c "printenv.py --line pretxncommit.forbid 1" > pretxncommit.forbid1 = sh -c "printenv.py --line pretxncommit.forbid 1"
> EOF > EOF
txnabort Python hook: changes,txnid,txnname txnabort Python hook: changes,txnid,txnname
txnabort hook: HG_HOOKNAME=txnabort.1 txnabort hook: HG_HOOKNAME=txnabort.1
HG_HOOKTYPE=txnabort HG_HOOKTYPE=txnabort
HG_TXNID=TXN:$ID$ HG_TXNID=TXN:$ID$
HG_TXNNAME=commit HG_TXNNAME=commit
rollback completed rollback completed
abort: pretxncommit.forbid1 hook exited with status 1 abort: pretxncommit.forbid1 hook exited with status 1
[255] [40]
$ hg -q tip $ hg -q tip
4:539e4b31b6dc 4:539e4b31b6dc
(Check that no 'changelog.i.a' file were left behind) (Check that no 'changelog.i.a' file were left behind)
$ ls -1 .hg/store/ $ ls -1 .hg/store/
00changelog.i 00changelog.i
00manifest.i 00manifest.i
HG_HOOKTYPE=precommit HG_HOOKTYPE=precommit
HG_PARENT1=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10 HG_PARENT1=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10
precommit.forbid hook: HG_HOOKNAME=precommit.forbid precommit.forbid hook: HG_HOOKNAME=precommit.forbid
HG_HOOKTYPE=precommit HG_HOOKTYPE=precommit
HG_PARENT1=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10 HG_PARENT1=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10
abort: precommit.forbid hook exited with status 1 abort: precommit.forbid hook exited with status 1
[255] [40]
$ hg -q tip $ hg -q tip
4:539e4b31b6dc 4:539e4b31b6dc
preupdate hook can prevent update preupdate hook can prevent update
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> preupdate = sh -c "printenv.py --line preupdate" > preupdate = sh -c "printenv.py --line preupdate"
> EOF > EOF
HG_NEW=0000000000000000000000000000000000000000 HG_NEW=0000000000000000000000000000000000000000
HG_PUSHKEYCOMPAT=1 HG_PUSHKEYCOMPAT=1
HG_SOURCE=push HG_SOURCE=push
HG_TXNID=TXN:$ID$ HG_TXNID=TXN:$ID$
HG_TXNNAME=push HG_TXNNAME=push
HG_URL=file:$TESTTMP/a HG_URL=file:$TESTTMP/a
abort: prepushkey hook exited with status 1 abort: prepushkey hook exited with status 1
[255] [40]
$ cd ../a $ cd ../a
test that prelistkeys can prevent listing keys test that prelistkeys can prevent listing keys
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> prelistkeys = sh -c "printenv.py --line prelistkeys.forbid 1" > prelistkeys = sh -c "printenv.py --line prelistkeys.forbid 1"
> EOF > EOF
$ hg bookmark -r null quux $ hg bookmark -r null quux
$ cd ../b $ cd ../b
$ hg pull -B quux ../a $ hg pull -B quux ../a
pulling from ../a pulling from ../a
prelistkeys.forbid hook: HG_HOOKNAME=prelistkeys prelistkeys.forbid hook: HG_HOOKNAME=prelistkeys
HG_HOOKTYPE=prelistkeys HG_HOOKTYPE=prelistkeys
HG_NAMESPACE=bookmarks HG_NAMESPACE=bookmarks
abort: prelistkeys hook exited with status 1 abort: prelistkeys hook exited with status 1
[255] [40]
$ cd ../a $ cd ../a
$ rm .hg/hgrc $ rm .hg/hgrc
prechangegroup hook can prevent incoming changes prechangegroup hook can prevent incoming changes
$ cd ../b $ cd ../b
$ hg -q tip $ hg -q tip
3:07f3376c1e65 3:07f3376c1e65
$ cat > .hg/hgrc <<EOF $ cat > .hg/hgrc <<EOF
> [hooks] > [hooks]
> prechangegroup.forbid = sh -c "printenv.py --line prechangegroup.forbid 1" > prechangegroup.forbid = sh -c "printenv.py --line prechangegroup.forbid 1"
> EOF > EOF
$ hg pull ../a $ hg pull ../a
pulling from ../a pulling from ../a
searching for changes searching for changes
prechangegroup.forbid hook: HG_HOOKNAME=prechangegroup.forbid prechangegroup.forbid hook: HG_HOOKNAME=prechangegroup.forbid
HG_HOOKTYPE=prechangegroup HG_HOOKTYPE=prechangegroup
HG_SOURCE=pull HG_SOURCE=pull
HG_TXNID=TXN:$ID$ HG_TXNID=TXN:$ID$
HG_TXNNAME=pull HG_TXNNAME=pull
file:/*/$TESTTMP/a (glob) file:/*/$TESTTMP/a (glob)
HG_URL=file:$TESTTMP/a HG_URL=file:$TESTTMP/a
abort: prechangegroup.forbid hook exited with status 1 abort: prechangegroup.forbid hook exited with status 1
[255] [40]
pretxnchangegroup hook can see incoming changes, can roll back txn, pretxnchangegroup hook can see incoming changes, can roll back txn,
incoming changes no longer there after incoming changes no longer there after
$ cat > .hg/hgrc <<EOF $ cat > .hg/hgrc <<EOF
> [hooks] > [hooks]
> pretxnchangegroup.forbid0 = hg tip -q > pretxnchangegroup.forbid0 = hg tip -q
> pretxnchangegroup.forbid1 = sh -c "printenv.py --line pretxnchangegroup.forbid 1" > pretxnchangegroup.forbid1 = sh -c "printenv.py --line pretxnchangegroup.forbid 1"
HG_TXNID=TXN:$ID$ HG_TXNID=TXN:$ID$
HG_TXNNAME=pull HG_TXNNAME=pull
file:/*/$TESTTMP/a (glob) file:/*/$TESTTMP/a (glob)
HG_URL=file:$TESTTMP/a HG_URL=file:$TESTTMP/a
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnchangegroup.forbid1 hook exited with status 1 abort: pretxnchangegroup.forbid1 hook exited with status 1
[255] [40]
$ hg -q tip $ hg -q tip
3:07f3376c1e65 3:07f3376c1e65
outgoing hooks can see env vars outgoing hooks can see env vars
$ rm .hg/hgrc $ rm .hg/hgrc
$ cat > ../a/.hg/hgrc <<EOF $ cat > ../a/.hg/hgrc <<EOF
> [hooks] > [hooks]
HG_HOOKTYPE=preoutgoing HG_HOOKTYPE=preoutgoing
HG_SOURCE=pull HG_SOURCE=pull
preoutgoing.forbid hook: HG_HOOKNAME=preoutgoing.forbid preoutgoing.forbid hook: HG_HOOKNAME=preoutgoing.forbid
HG_HOOKTYPE=preoutgoing HG_HOOKTYPE=preoutgoing
HG_SOURCE=pull HG_SOURCE=pull
abort: preoutgoing.forbid hook exited with status 1 abort: preoutgoing.forbid hook exited with status 1
[255] [40]
outgoing hooks work for local clones outgoing hooks work for local clones
$ cd .. $ cd ..
$ cat > a/.hg/hgrc <<EOF $ cat > a/.hg/hgrc <<EOF
> [hooks] > [hooks]
> preoutgoing = sh -c "printenv.py --line preoutgoing" > preoutgoing = sh -c "printenv.py --line preoutgoing"
> outgoing = sh -c "printenv.py --line outgoing" > outgoing = sh -c "printenv.py --line outgoing"
HG_HOOKTYPE=preoutgoing HG_HOOKTYPE=preoutgoing
HG_SOURCE=clone HG_SOURCE=clone
preoutgoing.forbid hook: HG_HOOKNAME=preoutgoing.forbid preoutgoing.forbid hook: HG_HOOKNAME=preoutgoing.forbid
HG_HOOKTYPE=preoutgoing HG_HOOKTYPE=preoutgoing
HG_SOURCE=clone HG_SOURCE=clone
abort: preoutgoing.forbid hook exited with status 1 abort: preoutgoing.forbid hook exited with status 1
[255] [40]
$ cd "$TESTTMP/b" $ cd "$TESTTMP/b"
$ cat > hooktests.py <<EOF $ cat > hooktests.py <<EOF
> from __future__ import print_function > from __future__ import print_function
> from mercurial import ( > from mercurial import (
> error, > error,
> pycompat, > pycompat,
$ echo 'preoutgoing.fail = python:hooktests.failhook' >> ../a/.hg/hgrc $ echo 'preoutgoing.fail = python:hooktests.failhook' >> ../a/.hg/hgrc
$ hg pull ../a $ hg pull ../a
pulling from ../a pulling from ../a
searching for changes searching for changes
hook args: hook args:
hooktype preoutgoing hooktype preoutgoing
source pull source pull
abort: preoutgoing.fail hook failed abort: preoutgoing.fail hook failed
[255] [40]
$ echo '[hooks]' > ../a/.hg/hgrc $ echo '[hooks]' > ../a/.hg/hgrc
$ echo 'preoutgoing.uncallable = python:hooktests.uncallable' >> ../a/.hg/hgrc $ echo 'preoutgoing.uncallable = python:hooktests.uncallable' >> ../a/.hg/hgrc
$ hg pull ../a $ hg pull ../a
pulling from ../a pulling from ../a
searching for changes searching for changes
abort: preoutgoing.uncallable hook is invalid: "hooktests.uncallable" is not callable abort: preoutgoing.uncallable hook is invalid: "hooktests.uncallable" is not callable
[255] [255]
> EOF > EOF
$ hg strip -r 0 --config extensions.strip= $ hg strip -r 0 --config extensions.strip=
0 files updated, 0 files merged, 1 files removed, 0 files unresolved 0 files updated, 0 files merged, 1 files removed, 0 files unresolved
saved backup bundle to * (glob) saved backup bundle to * (glob)
transaction abort! transaction abort!
rollback completed rollback completed
strip failed, backup bundle stored in * (glob) strip failed, backup bundle stored in * (glob)
abort: pretxnclose.error hook exited with status 1 abort: pretxnclose.error hook exited with status 1
[255] [40]
$ hg recover $ hg recover
no interrupted transaction available no interrupted transaction available
[1] [1]
$ cd .. $ cd ..
check whether HG_PENDING makes pending changes only in related check whether HG_PENDING makes pending changes only in related
repositories visible to an external hook. repositories visible to an external hook.
(emulate a transaction running concurrently by copied (emulate a transaction running concurrently by copied
.hg/store/00changelog.i.a in subsequent test) .hg/store/00changelog.i.a in subsequent test)
$ cat > $TESTTMP/savepending.sh <<EOF $ cat > $TESTTMP/savepending.sh <<EOF
> cp .hg/store/00changelog.i.a .hg/store/00changelog.i.a.saved > cp .hg/store/00changelog.i.a .hg/store/00changelog.i.a.saved
> exit 1 # to avoid adding new revision for subsequent tests > exit 1 # to avoid adding new revision for subsequent tests
> EOF > EOF
$ cd a $ cd a
$ hg tip -q $ hg tip -q
4:539e4b31b6dc 4:539e4b31b6dc
$ hg --config hooks.pretxnclose="sh $TESTTMP/savepending.sh" commit -m "invisible" $ hg --config hooks.pretxnclose="sh $TESTTMP/savepending.sh" commit -m "invisible"
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose hook exited with status 1 abort: pretxnclose hook exited with status 1
[255] [40]
$ cp .hg/store/00changelog.i.a.saved .hg/store/00changelog.i.a $ cp .hg/store/00changelog.i.a.saved .hg/store/00changelog.i.a
(check (in)visibility of new changeset while transaction running in (check (in)visibility of new changeset while transaction running in
repo) repo)
$ cat > $TESTTMP/checkpending.sh <<EOF $ cat > $TESTTMP/checkpending.sh <<EOF
> echo '@a' > echo '@a'
> hg -R "$TESTTMP/a" tip -q > hg -R "$TESTTMP/a" tip -q
> echo '@a/nested' > echo '@a/nested'
> hg -R "$TESTTMP/a/nested" tip -q > hg -R "$TESTTMP/a/nested" tip -q
> exit 1 # to avoid adding new revision for subsequent tests > exit 1 # to avoid adding new revision for subsequent tests
> EOF > EOF
$ hg init nested $ hg init nested
$ cd nested $ cd nested
$ echo a > a $ echo a > a
$ hg add a $ hg add a
$ hg --config hooks.pretxnclose="sh $TESTTMP/checkpending.sh" commit -m '#0' $ hg --config hooks.pretxnclose="sh $TESTTMP/checkpending.sh" commit -m '#0'
@a @a
4:539e4b31b6dc 4:539e4b31b6dc
@a/nested @a/nested
0:bf5e395ced2c 0:bf5e395ced2c
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose hook exited with status 1 abort: pretxnclose hook exited with status 1
[255] [40]
Hook from untrusted hgrc are reported as failure Hook from untrusted hgrc are reported as failure
================================================ ================================================
$ cat << EOF > $TESTTMP/untrusted.py $ cat << EOF > $TESTTMP/untrusted.py
> from mercurial import scmutil, util > from mercurial import scmutil, util
> def uisetup(ui): > def uisetup(ui):
> class untrustedui(ui.__class__): > class untrustedui(ui.__class__):
> [hooks] > [hooks]
> pretxnclose.testing=echo pre-txnclose hook called > pretxnclose.testing=echo pre-txnclose hook called
> EOF > EOF
$ touch b && hg commit -Aqm a $ touch b && hg commit -Aqm a
transaction abort! transaction abort!
rollback completed rollback completed
abort: untrusted hook pretxnclose.testing not executed abort: untrusted hook pretxnclose.testing not executed
(see 'hg help config.trusted') (see 'hg help config.trusted')
[255] [40]
$ hg log $ hg log
changeset: 0:3903775176ed changeset: 0:3903775176ed
tag: tip tag: tip
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: a summary: a

tests/test-mactext.t

$ "$PYTHON" unix2mac.py f $ "$PYTHON" unix2mac.py f
$ hg ci -m 2 $ hg ci -m 2
attempt to commit or push text file(s) using CR line endings attempt to commit or push text file(s) using CR line endings
in dea860dc51ec: f in dea860dc51ec: f
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit.cr hook failed abort: pretxncommit.cr hook failed
[255] [40]
$ hg cat f | f --hexdump $ hg cat f | f --hexdump
0000: 68 65 6c 6c 6f 0a |hello.| 0000: 68 65 6c 6c 6f 0a |hello.|
$ f --hexdump f $ f --hexdump f
f: f:
0000: 68 65 6c 6c 6f 0d |hello.| 0000: 68 65 6c 6c 6f 0d |hello.|

tests/test-merge-tools.t

false.whatever= false.whatever=
true.priority=1 true.priority=1
true.executable=cat true.executable=cat
# hg update -C 1 # hg update -C 1
$ hg merge -r 2 --config merge-tools.true.executable="python:$TESTTMP/mybrokenmerge.py:mybrokenmergefn" $ hg merge -r 2 --config merge-tools.true.executable="python:$TESTTMP/mybrokenmerge.py:mybrokenmergefn"
merging f merging f
some fail message some fail message
abort: $TESTTMP/mybrokenmerge.py hook failed abort: $TESTTMP/mybrokenmerge.py hook failed
[255] [40]
$ aftermerge $ aftermerge
# cat f # cat f
revision 1 revision 1
space space
# hg stat # hg stat
? f.orig ? f.orig
# hg resolve --list # hg resolve --list
U f U f

tests/test-mq-qfold.t

HG: changed a HG: changed a
==== ====
note: commit message saved in .hg/last-message.txt note: commit message saved in .hg/last-message.txt
note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it
transaction abort! transaction abort!
rollback completed rollback completed
qrefresh interrupted while patch was popped! (revert --all, qpush to recover) qrefresh interrupted while patch was popped! (revert --all, qpush to recover)
abort: pretxncommit.unexpectedabort hook exited with status 1 abort: pretxncommit.unexpectedabort hook exited with status 1
[255] [40]
$ cat .hg/last-message.txt $ cat .hg/last-message.txt
original message original message
test saving last-message.txt test saving last-message.txt
(confirm whether files listed up in the commit message editing are correct) (confirm whether files listed up in the commit message editing are correct)

tests/test-mq-qnew.t

HG: branch 'default' HG: branch 'default'
HG: no files changed HG: no files changed
==== ====
transaction abort! transaction abort!
rollback completed rollback completed
note: commit message saved in .hg/last-message.txt note: commit message saved in .hg/last-message.txt
note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it
abort: pretxncommit.unexpectedabort hook exited with status 1 abort: pretxncommit.unexpectedabort hook exited with status 1
[255] [40]
$ cat .hg/last-message.txt $ cat .hg/last-message.txt
test saving last-message.txt test saving last-message.txt
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [hooks] > [hooks]
> pretxncommit.unexpectedabort = > pretxncommit.unexpectedabort =
> EOF > EOF

tests/test-mq-qrefresh-replace-log-message.t

HG: added file2 HG: added file2
==== ====
note: commit message saved in .hg/last-message.txt note: commit message saved in .hg/last-message.txt
note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it
transaction abort! transaction abort!
rollback completed rollback completed
qrefresh interrupted while patch was popped! (revert --all, qpush to recover) qrefresh interrupted while patch was popped! (revert --all, qpush to recover)
abort: pretxncommit.unexpectedabort hook exited with status 1 abort: pretxncommit.unexpectedabort hook exited with status 1
[255] [40]
$ cat .hg/last-message.txt $ cat .hg/last-message.txt
Fifth commit message Fifth commit message
This is the 5th log message This is the 5th log message
test saving last-message.txt test saving last-message.txt
A file2 A file2
==== ====
note: commit message saved in .hg/last-message.txt note: commit message saved in .hg/last-message.txt
note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it
transaction abort! transaction abort!
rollback completed rollback completed
qrefresh interrupted while patch was popped! (revert --all, qpush to recover) qrefresh interrupted while patch was popped! (revert --all, qpush to recover)
abort: pretxncommit.unexpectedabort hook exited with status 1 abort: pretxncommit.unexpectedabort hook exited with status 1
[255] [40]
(rebuilding at failure of qrefresh bases on rev #0, and it causes (rebuilding at failure of qrefresh bases on rev #0, and it causes
dropping status of "file2") dropping status of "file2")
$ sh "$TESTTMP/checkvisibility.sh" $ sh "$TESTTMP/checkvisibility.sh"
==== ====
0:25e397dabed2 0:25e397dabed2
==== ====
==== ====
0:25e397dabed2 0:25e397dabed2
A file2 A file2
==== ====
transaction abort! transaction abort!
rollback completed rollback completed
qrefresh interrupted while patch was popped! (revert --all, qpush to recover) qrefresh interrupted while patch was popped! (revert --all, qpush to recover)
abort: pretxncommit.unexpectedabort hook exited with status 1 abort: pretxncommit.unexpectedabort hook exited with status 1
[255] [40]
$ sh "$TESTTMP/checkvisibility.sh" $ sh "$TESTTMP/checkvisibility.sh"
==== ====
0:25e397dabed2 0:25e397dabed2
==== ====
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [hooks] > [hooks]
==== ====
0:25e397dabed2 0:25e397dabed2
A file2 A file2
==== ====
transaction abort! transaction abort!
rollback completed rollback completed
qrefresh interrupted while patch was popped! (revert --all, qpush to recover) qrefresh interrupted while patch was popped! (revert --all, qpush to recover)
abort: pretxncommit.unexpectedabort hook exited with status 1 abort: pretxncommit.unexpectedabort hook exited with status 1
[255] [40]
$ sh "$TESTTMP/checkvisibility.sh" $ sh "$TESTTMP/checkvisibility.sh"
==== ====
0:25e397dabed2 0:25e397dabed2
==== ====
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [hooks] > [hooks]
> pretxncommit.checkvisibility = > pretxncommit.checkvisibility =
> EOF > EOF

tests/test-narrow-pull.t

summary: Update#1 to f3 summary: Update#1 to f3
Interrupting the pull is safe Interrupting the pull is safe
$ hg --config hooks.pretxnchangegroup.bad=false pull -q $ hg --config hooks.pretxnchangegroup.bad=false pull -q
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnchangegroup.bad hook exited with status 1 abort: pretxnchangegroup.bad hook exited with status 1
[255] [40]
$ hg id $ hg id
223311e70a6f tip 223311e70a6f tip
pull new changes down to the narrow clone. Should get 8 new changesets: 4 pull new changes down to the narrow clone. Should get 8 new changesets: 4
relevant to the narrow spec, and 4 ellipsis nodes gluing them all together. relevant to the narrow spec, and 4 ellipsis nodes gluing them all together.
$ hg pull $ hg pull
pulling from ssh://user@dummy/master pulling from ssh://user@dummy/master

tests/test-narrow-widen.t

searching for changes searching for changes
saved backup bundle to $TESTTMP/interrupted/.hg/strip-backup/*-widen.hg (glob) saved backup bundle to $TESTTMP/interrupted/.hg/strip-backup/*-widen.hg (glob)
adding changesets adding changesets
adding manifests adding manifests
adding file changes adding file changes
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnchangegroup.bad hook exited with status 1 abort: pretxnchangegroup.bad hook exited with status 1
[255] [40]
$ hg l $ hg l
$ hg bookmarks $ hg bookmarks
no bookmarks set no bookmarks set
$ hg unbundle .hg/strip-backup/*-widen.hg $ hg unbundle .hg/strip-backup/*-widen.hg
adding changesets adding changesets
adding manifests adding manifests
adding file changes adding file changes
added 3 changesets with 2 changes to 1 files added 3 changesets with 2 changes to 1 files

tests/test-phases.t

> EOF > EOF
$ cd push-dest $ cd push-dest
$ hg phase 6 $ hg phase 6
6: draft 6: draft
$ hg --config hooks.pretxnclose="sh $TESTTMP/savepending.sh" phase -f -s 6 $ hg --config hooks.pretxnclose="sh $TESTTMP/savepending.sh" phase -f -s 6
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose hook exited with status 1 abort: pretxnclose hook exited with status 1
[255] [40]
$ cp .hg/store/phaseroots.pending.saved .hg/store/phaseroots.pending $ cp .hg/store/phaseroots.pending.saved .hg/store/phaseroots.pending
(check (in)visibility of phaseroot while transaction running in repo) (check (in)visibility of phaseroot while transaction running in repo)
$ cat > $TESTTMP/checkpending.sh <<EOF $ cat > $TESTTMP/checkpending.sh <<EOF
> echo '@initialrepo' > echo '@initialrepo'
> hg -R "$TESTTMP/initialrepo" phase 7 > hg -R "$TESTTMP/initialrepo" phase 7
> echo '@push-dest' > echo '@push-dest'
> hg -R "$TESTTMP/push-dest" phase 6 > hg -R "$TESTTMP/push-dest" phase 6
> exit 1 # to avoid changing phase for subsequent tests > exit 1 # to avoid changing phase for subsequent tests
> EOF > EOF
$ cd ../initialrepo $ cd ../initialrepo
$ hg phase 7 $ hg phase 7
7: public 7: public
$ hg --config hooks.pretxnclose="sh $TESTTMP/checkpending.sh" phase -f -s 7 $ hg --config hooks.pretxnclose="sh $TESTTMP/checkpending.sh" phase -f -s 7
@initialrepo @initialrepo
7: secret 7: secret
@push-dest @push-dest
6: draft 6: draft
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose hook exited with status 1 abort: pretxnclose hook exited with status 1
[255] [40]
Check that pretxnclose-phase hook can control phase movement Check that pretxnclose-phase hook can control phase movement
$ hg phase --force b3325c91a4d9 --secret $ hg phase --force b3325c91a4d9 --secret
test-debug-phase: move rev 3: 0 -> 2 test-debug-phase: move rev 3: 0 -> 2
test-debug-phase: move rev 4: 0 -> 2 test-debug-phase: move rev 4: 0 -> 2
test-debug-phase: move rev 5: 1 -> 2 test-debug-phase: move rev 5: 1 -> 2
test-debug-phase: move rev 7: 0 -> 2 test-debug-phase: move rev 7: 0 -> 2
> EOF > EOF
Try various actions. only the draft move should succeed Try various actions. only the draft move should succeed
$ hg phase --public b3325c91a4d9 $ hg phase --public b3325c91a4d9
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose-phase.nopublish_D hook exited with status 1 abort: pretxnclose-phase.nopublish_D hook exited with status 1
[255] [40]
$ hg phase --public a603bfb5a83e $ hg phase --public a603bfb5a83e
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose-phase.nopublish_D hook exited with status 1 abort: pretxnclose-phase.nopublish_D hook exited with status 1
[255] [40]
$ hg phase --draft 17a481b3bccb $ hg phase --draft 17a481b3bccb
test-debug-phase: move rev 3: 2 -> 1 test-debug-phase: move rev 3: 2 -> 1
test-debug-phase: move rev 4: 2 -> 1 test-debug-phase: move rev 4: 2 -> 1
test-debug-phase: move rev 7: 2 -> 1 test-debug-phase: move rev 7: 2 -> 1
test-hook-close-phase: b3325c91a4d916bcc4cdc83ea3fe4ece46a42f6e: secret -> draft test-hook-close-phase: b3325c91a4d916bcc4cdc83ea3fe4ece46a42f6e: secret -> draft
test-hook-close-phase: a603bfb5a83e312131cebcd05353c217d4d21dde: secret -> draft test-hook-close-phase: a603bfb5a83e312131cebcd05353c217d4d21dde: secret -> draft
test-hook-close-phase: 17a481b3bccb796c0521ae97903d81c52bfee4af: secret -> draft test-hook-close-phase: 17a481b3bccb796c0521ae97903d81c52bfee4af: secret -> draft
$ hg phase --public 17a481b3bccb $ hg phase --public 17a481b3bccb
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose-phase.nopublish_D hook exited with status 1 abort: pretxnclose-phase.nopublish_D hook exited with status 1
[255] [40]
$ cd .. $ cd ..
Test for the "internal" phase Test for the "internal" phase
============================= =============================
Check we deny its usage on older repository Check we deny its usage on older repository

tests/test-rebase-interruptions.t

$ cp -R a3 hook-precommit $ cp -R a3 hook-precommit
$ cd hook-precommit $ cd hook-precommit
$ hg rebase --source 2 --dest 5 --tool internal:other --config 'hooks.precommit=hg status | grep "M A"' $ hg rebase --source 2 --dest 5 --tool internal:other --config 'hooks.precommit=hg status | grep "M A"'
rebasing 2:965c486023db "C" rebasing 2:965c486023db "C"
M A M A
rebasing 6:a0b2430ebfb8 tip "F" rebasing 6:a0b2430ebfb8 tip "F"
abort: precommit hook exited with status 1 abort: precommit hook exited with status 1
[255] [40]
$ hg tglogp $ hg tglogp
@ 7: 401ccec5e39f secret 'C' @ 7: 401ccec5e39f secret 'C'
| |
| o 6: a0b2430ebfb8 secret 'F' | o 6: a0b2430ebfb8 secret 'F'
| | | |
o | 5: 45396c49d53b public 'B' o | 5: 45396c49d53b public 'B'
| | | |
o | 4: ae36e8e3dfd7 public 'E' o | 4: ae36e8e3dfd7 public 'E'
$ hg rebase --source 2 --dest 5 --tool internal:other \ $ hg rebase --source 2 --dest 5 --tool internal:other \
> --config 'hooks.tonative.pretxncommit=True' --config 'hooks.pretxncommit=hg log -r $HG_NODE | grep "summary: C"' > --config 'hooks.tonative.pretxncommit=True' --config 'hooks.pretxncommit=hg log -r $HG_NODE | grep "summary: C"'
rebasing 2:965c486023db "C" rebasing 2:965c486023db "C"
summary: C summary: C
rebasing 6:a0b2430ebfb8 tip "F" rebasing 6:a0b2430ebfb8 tip "F"
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit hook exited with status 1 abort: pretxncommit hook exited with status 1
[255] [40]
$ hg tglogp $ hg tglogp
@ 7: 401ccec5e39f secret 'C' @ 7: 401ccec5e39f secret 'C'
| |
| o 6: a0b2430ebfb8 secret 'F' | o 6: a0b2430ebfb8 secret 'F'
| | | |
o | 5: 45396c49d53b public 'B' o | 5: 45396c49d53b public 'B'
| | | |
o | 4: ae36e8e3dfd7 public 'E' o | 4: ae36e8e3dfd7 public 'E'
$ cd hook-pretxnclose $ cd hook-pretxnclose
$ hg rebase --source 2 --dest 5 --tool internal:other --config 'hooks.pretxnclose=hg log -r tip | grep "summary: C"' $ hg rebase --source 2 --dest 5 --tool internal:other --config 'hooks.pretxnclose=hg log -r tip | grep "summary: C"'
rebasing 2:965c486023db "C" rebasing 2:965c486023db "C"
summary: C summary: C
rebasing 6:a0b2430ebfb8 tip "F" rebasing 6:a0b2430ebfb8 tip "F"
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose hook exited with status 1 abort: pretxnclose hook exited with status 1
[255] [40]
$ hg tglogp $ hg tglogp
@ 7: 401ccec5e39f secret 'C' @ 7: 401ccec5e39f secret 'C'
| |
| o 6: a0b2430ebfb8 secret 'F' | o 6: a0b2430ebfb8 secret 'F'
| | | |
o | 5: 45396c49d53b public 'B' o | 5: 45396c49d53b public 'B'
| | | |
o | 4: ae36e8e3dfd7 public 'E' o | 4: ae36e8e3dfd7 public 'E'

tests/test-rollback.t

rollback by pretxncommit saves commit message (issue1635) rollback by pretxncommit saves commit message (issue1635)
$ echo a >> a $ echo a >> a
$ hg --config hooks.pretxncommit=false commit -m"precious commit message" $ hg --config hooks.pretxncommit=false commit -m"precious commit message"
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit hook exited with status * (glob) abort: pretxncommit hook exited with status * (glob)
[255] [40]
$ cat .hg/last-message.txt ; echo $ cat .hg/last-message.txt ; echo
precious commit message precious commit message
same thing, but run $EDITOR same thing, but run $EDITOR
$ cat > editor.sh << '__EOF__' $ cat > editor.sh << '__EOF__'
> echo "another precious commit message" > "$1" > echo "another precious commit message" > "$1"
> __EOF__ > __EOF__
$ HGEDITOR="\"sh\" \"`pwd`/editor.sh\"" hg --config hooks.pretxncommit=false commit 2>&1 $ HGEDITOR="\"sh\" \"`pwd`/editor.sh\"" hg --config hooks.pretxncommit=false commit 2>&1
transaction abort! transaction abort!
rollback completed rollback completed
note: commit message saved in .hg/last-message.txt note: commit message saved in .hg/last-message.txt
note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it
abort: pretxncommit hook exited with status * (glob) abort: pretxncommit hook exited with status * (glob)
[255] [40]
$ cat .hg/last-message.txt $ cat .hg/last-message.txt
another precious commit message another precious commit message
test rollback on served repository test rollback on served repository
#if serve #if serve
$ hg commit -m "precious commit message" $ hg commit -m "precious commit message"
$ hg serve -p $HGPORT -d --pid-file=hg.pid -A access.log -E errors.log $ hg serve -p $HGPORT -d --pid-file=hg.pid -A access.log -E errors.log
warn during pretxnclose warn during pretxnclose
warn during txnclose warn during txnclose
$ echo 1 > foo $ echo 1 > foo
$ hg --config ui.ioerrors=msgabort --config hooks.pretxncommit=false commit -m 'error during abort message' $ hg --config ui.ioerrors=msgabort --config hooks.pretxncommit=false commit -m 'error during abort message'
warn during abort warn during abort
rollback completed rollback completed
abort: pretxncommit hook exited with status 1 abort: pretxncommit hook exited with status 1
[255] [40]
$ hg commit -m 'commit 1' $ hg commit -m 'commit 1'
warn during pretxncommit warn during pretxncommit
warn during pretxnclose warn during pretxnclose
warn during txnclose warn during txnclose
$ cd .. $ cd ..
An I/O error during txnabort should still result in rollback An I/O error during txnabort should still result in rollback
$ hg init ioerror-txnabort $ hg init ioerror-txnabort
$ cd ioerror-txnabort $ cd ioerror-txnabort
$ echo 0 > foo $ echo 0 > foo
$ hg -q commit -A -m initial $ hg -q commit -A -m initial
warn during pretxncommit warn during pretxncommit
warn during pretxnclose warn during pretxnclose
warn during txnclose warn during txnclose
$ echo 1 > foo $ echo 1 > foo
$ hg --config ui.ioerrors=txnabort --config hooks.pretxncommit=false commit -m 'error during abort' $ hg --config ui.ioerrors=txnabort --config hooks.pretxncommit=false commit -m 'error during abort'
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit hook exited with status 1 abort: pretxncommit hook exited with status 1
[255] [40]
$ hg commit -m 'commit 1' $ hg commit -m 'commit 1'
warn during pretxncommit warn during pretxncommit
warn during pretxnclose warn during pretxnclose
warn during txnclose warn during txnclose
$ cd .. $ cd ..
warn during txnclose warn during txnclose
$ echo 1 > foo $ echo 1 > foo
$ hg --config ui.ioerrors=msgrollback --config hooks.pretxncommit=false commit -m 'error during rollback message' $ hg --config ui.ioerrors=msgrollback --config hooks.pretxncommit=false commit -m 'error during rollback message'
transaction abort! transaction abort!
warn during abort warn during abort
abort: pretxncommit hook exited with status 1 abort: pretxncommit hook exited with status 1
[255] [40]
$ hg verify $ hg verify
checking changesets checking changesets
checking manifests checking manifests
crosschecking files in changesets and manifests crosschecking files in changesets and manifests
checking files checking files
checked 1 changesets with 1 changes to 1 files checked 1 changesets with 1 changes to 1 files

tests/test-share-bookmarks.t

@repo3 @repo3
bm1 2:c2e0ac586386 bm1 2:c2e0ac586386
bm2 2:c2e0ac586386 (svfs !) bm2 2:c2e0ac586386 (svfs !)
* bm3 2:c2e0ac586386 * bm3 2:c2e0ac586386
bmX 2:c2e0ac586386 (vfs !) bmX 2:c2e0ac586386 (vfs !)
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose hook exited with status 1 abort: pretxnclose hook exited with status 1
[255] [40]
$ hg book bm1 $ hg book bm1
FYI, in contrast to above test, bmX is invisible in repo1 (= shared FYI, in contrast to above test, bmX is invisible in repo1 (= shared
src), because (1) HG_PENDING refers only repo3 and (2) src), because (1) HG_PENDING refers only repo3 and (2)
"bookmarks.pending" is written only into repo3. "bookmarks.pending" is written only into repo3.
$ cd ../repo3 $ cd ../repo3
$ hg --config hooks.pretxnclose="sh $TESTTMP/checkbookmarks.sh" -q book bmX $ hg --config hooks.pretxnclose="sh $TESTTMP/checkbookmarks.sh" -q book bmX
@repo1 @repo1
* bm1 2:c2e0ac586386 * bm1 2:c2e0ac586386
bm2 2:c2e0ac586386 (svfs !) bm2 2:c2e0ac586386 (svfs !)
bm3 2:c2e0ac586386 bm3 2:c2e0ac586386
@repo2 @repo2
bm1 2:c2e0ac586386 (svfs !) bm1 2:c2e0ac586386 (svfs !)
* bm2 2:c2e0ac586386 * bm2 2:c2e0ac586386
bm3 2:c2e0ac586386 (svfs !) bm3 2:c2e0ac586386 (svfs !)
@repo3 @repo3
bm1 2:c2e0ac586386 bm1 2:c2e0ac586386
bm2 2:c2e0ac586386 (svfs !) bm2 2:c2e0ac586386 (svfs !)
bm3 2:c2e0ac586386 bm3 2:c2e0ac586386
* bmX 2:c2e0ac586386 * bmX 2:c2e0ac586386
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnclose hook exited with status 1 abort: pretxnclose hook exited with status 1
[255] [40]
$ hg book bm3 $ hg book bm3
clean up bm2 since it's uninteresting (not shared in the vfs case and clean up bm2 since it's uninteresting (not shared in the vfs case and
same as bm3 in the svfs case) same as bm3 in the svfs case)
$ cd ../repo2 $ cd ../repo2
$ hg book -d bm2 $ hg book -d bm2
$ cd ../repo1 $ cd ../repo1
bm1 3:b87954705719 bm1 3:b87954705719
bm4 5:92793bfc8cad bm4 5:92793bfc8cad
$ hg --config "extensions.failpullbookmarks=$TESTTMP/failpullbookmarks.py" pull $TESTTMP/repo4 $ hg --config "extensions.failpullbookmarks=$TESTTMP/failpullbookmarks.py" pull $TESTTMP/repo4
pulling from $TESTTMP/repo4 pulling from $TESTTMP/repo4
searching for changes searching for changes
no changes found no changes found
adding remote bookmark bm3 adding remote bookmark bm3
abort: forced failure by extension abort: forced failure by extension
[255] [40]
$ hg boo $ hg boo
bm1 3:b87954705719 bm1 3:b87954705719
bm4 5:92793bfc8cad bm4 5:92793bfc8cad
$ hg pull $TESTTMP/repo4 $ hg pull $TESTTMP/repo4
pulling from $TESTTMP/repo4 pulling from $TESTTMP/repo4
searching for changes searching for changes
no changes found no changes found
adding remote bookmark bm3 adding remote bookmark bm3

tests/test-strip.t

1 files updated, 0 files merged, 0 files removed, 0 files unresolved 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
saved backup bundle to $TESTTMP/test/.hg/strip-backup/*-backup.hg (glob) saved backup bundle to $TESTTMP/test/.hg/strip-backup/*-backup.hg (glob)
transaction abort! transaction abort!
rollback completed rollback completed
strip failed, backup bundle stored in '$TESTTMP/test/.hg/strip-backup/*-backup.hg' (glob) strip failed, backup bundle stored in '$TESTTMP/test/.hg/strip-backup/*-backup.hg' (glob)
strip failed, unrecovered changes stored in '$TESTTMP/test/.hg/strip-backup/*-temp.hg' (glob) strip failed, unrecovered changes stored in '$TESTTMP/test/.hg/strip-backup/*-temp.hg' (glob)
(fix the problem, then recover the changesets with "hg unbundle '$TESTTMP/test/.hg/strip-backup/*-temp.hg'") (glob) (fix the problem, then recover the changesets with "hg unbundle '$TESTTMP/test/.hg/strip-backup/*-temp.hg'") (glob)
abort: pretxnchangegroup.bad hook exited with status 1 abort: pretxnchangegroup.bad hook exited with status 1
[255] [40]
$ restore $ restore
$ hg log -G $ hg log -G
o changeset: 4:443431ffac4f o changeset: 4:443431ffac4f
| tag: tip | tag: tip
| user: test | user: test
| date: Thu Jan 01 00:00:00 1970 +0000 | date: Thu Jan 01 00:00:00 1970 +0000
| summary: e | summary: e
| |

tests/test-tag.t

$ cat > .hg/hgrc << '__EOF__' $ cat > .hg/hgrc << '__EOF__'
> [hooks] > [hooks]
> # this failure occurs before editor invocation > # this failure occurs before editor invocation
> pretag.test-saving-lastmessage = false > pretag.test-saving-lastmessage = false
> __EOF__ > __EOF__
$ rm -f .hg/last-message.txt $ rm -f .hg/last-message.txt
$ HGEDITOR="\"sh\" \"`pwd`/editor.sh\"" hg tag custom-tag -e $ HGEDITOR="\"sh\" \"`pwd`/editor.sh\"" hg tag custom-tag -e
abort: pretag.test-saving-lastmessage hook exited with status 1 abort: pretag.test-saving-lastmessage hook exited with status 1
[255] [40]
$ test -f .hg/last-message.txt $ test -f .hg/last-message.txt
[1] [1]
(test that editor is invoked and commit message is saved into (test that editor is invoked and commit message is saved into
"last-message.txt") "last-message.txt")
$ cat >> .hg/hgrc << '__EOF__' $ cat >> .hg/hgrc << '__EOF__'
> [hooks] > [hooks]
HG: branch 'tag-and-branch-same-name' HG: branch 'tag-and-branch-same-name'
HG: changed .hgtags HG: changed .hgtags
==== ====
transaction abort! transaction abort!
rollback completed rollback completed
note: commit message saved in .hg/last-message.txt note: commit message saved in .hg/last-message.txt
note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it note: use 'hg commit --logfile .hg/last-message.txt --edit' to reuse it
abort: pretxncommit.unexpectedabort hook exited with status 1 abort: pretxncommit.unexpectedabort hook exited with status 1
[255] [40]
$ cat .hg/last-message.txt $ cat .hg/last-message.txt
custom tag message custom tag message
second line second line
$ cat >> .hg/hgrc << '__EOF__' $ cat >> .hg/hgrc << '__EOF__'
> [hooks] > [hooks]
> pretxncommit.unexpectedabort = > pretxncommit.unexpectedabort =
> __EOF__ > __EOF__

tests/test-transplant.t

> EOF > EOF
$ hg transplant "22c515968f13::" $ hg transplant "22c515968f13::"
applying 22c515968f13 applying 22c515968f13
22c515968f13 transplanted to * (glob) 22c515968f13 transplanted to * (glob)
applying e38700ba9dd3 applying e38700ba9dd3
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit.abort hook exited with status 1 abort: pretxncommit.abort hook exited with status 1
[255] [40]
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [hooks] > [hooks]
> pretxncommit.abort = ! > pretxncommit.abort = !
> EOF > EOF
$ hg parents -T "{node|short}\n" $ hg parents -T "{node|short}\n"
d11e3596cc1a d11e3596cc1a
$ hg status -A $ hg status -A
M r1 M r1
? abort ? abort
C r2 C r2
$ cd .. $ cd ..

tests/test-win32text.t

commit should fail commit should fail
$ hg ci -m 2.1 $ hg ci -m 2.1
attempt to commit or push text file(s) using CRLF line endings attempt to commit or push text file(s) using CRLF line endings
in f583ea08d42a: f in f583ea08d42a: f
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit.crlf hook failed abort: pretxncommit.crlf hook failed
[255] [40]
$ mv .hg/hgrc .hg/hgrc.bak $ mv .hg/hgrc .hg/hgrc.bak
commits should succeed commits should succeed
$ hg ci -m 2 $ hg ci -m 2
$ hg cp f g $ hg cp f g
$ hg ci -m 2.2 $ hg ci -m 2.2
win32text = win32text =
[encode] [encode]
** = cleverencode: ** = cleverencode:
[decode] [decode]
** = cleverdecode: ** = cleverdecode:
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnchangegroup.crlf hook failed abort: pretxnchangegroup.crlf hook failed
[255] [40]
$ mv .hg/hgrc.bak .hg/hgrc $ mv .hg/hgrc.bak .hg/hgrc
$ echo hello > f $ echo hello > f
$ hg rm g $ hg rm g
commit should succeed commit should succeed
$ hg ci -m 2.3 $ hg ci -m 2.3
$ "$PYTHON" unix2dos.py d/f2 $ "$PYTHON" unix2dos.py d/f2
$ hg add d/f2 $ hg add d/f2
$ hg ci -m 3 $ hg ci -m 3
attempt to commit or push text file(s) using CRLF line endings attempt to commit or push text file(s) using CRLF line endings
in 053ba1a3035a: d/f2 in 053ba1a3035a: d/f2
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxncommit.crlf hook failed abort: pretxncommit.crlf hook failed
[255] [40]
$ hg revert -a $ hg revert -a
forgetting d/f2 forgetting d/f2
$ rm d/f2 $ rm d/f2
$ hg rem f $ hg rem f
$ hg ci -m 4 $ hg ci -m 4
$ "$PYTHON" -c 'open("bin", "wb").write(b"hello\x00\x0D\x0A")' $ "$PYTHON" -c 'open("bin", "wb").write(b"hello\x00\x0D\x0A")'
win32text = win32text =
[encode] [encode]
** = cleverencode: ** = cleverencode:
[decode] [decode]
** = cleverdecode: ** = cleverdecode:
transaction abort! transaction abort!
rollback completed rollback completed
abort: pretxnchangegroup.crlf hook failed abort: pretxnchangegroup.crlf hook failed
[255] [40]
$ hg log -v $ hg log -v
changeset: 5:f0b1c8d75fce changeset: 5:f0b1c8d75fce
tag: tip tag: tip
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
files: bin files: bin
description: description: