This is an archive of the discontinued Mercurial Phabricator instance.

Differential D996

tests: use readlink.py instead of readlink
ClosedPublic

Authored by durin42 on Oct 10 2017, 11:04 AM.

Details

Reviewers
quark
Group Reviewers
hg-reviewers
Commits
rHGe304fd82c718: tests: use readlink.py instead of readlink
Summary

The latter doesn't always exist, such as on Solaris-derived platforms.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 10 2017, 11:04 AM
durin42 added inline comments.Oct 10 2017, 11:05 AM
tests/test-convert-p4-filetypes.t
750

Please check these carefully. I don't have the ability to run this test, so I had to hand-edit the expected output.

quark accepted this revision.Oct 10 2017, 2:52 PM
Closed by commit rHGe304fd82c718: tests: use readlink.py instead of readlink (authored by durin42). · Explain WhyOct 11 2017, 5:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-convert-p4-filetypes.t (8 lines)

Diff 2579

tests/test-convert-p4-filetypes.t

$Date$ $Date$
$DateTime$ $DateTime$
$Change$ $Change$
$File$ $File$
$Revision$ $Revision$
$Header$$Header$Header$ $Header$$Header$Header$
crazy_symlink crazy_symlink
$ readlink crazy_symlink+k $ readlink.py crazy_symlink+k
target_$Header: //depot/test-mercurial-import/crazy_symlink+k#1 $ crazy_symlink+k -> target_$Header: //depot/test-mercurial-import/crazy_symlink+k#1 $
durin42AuthorUnsubmitted
Not Done

Please check these carefully. I don't have the ability to run this test, so I had to hand-edit the expected output.

durin42: Please check these carefully. I don't have the ability to run this test, so I had to hand-edit…
$ readlink dst/crazy_symlink+k $ readlink.py dst/crazy_symlink+k
target_$Header$ dst/crazy_symlink+k -> target_$Header$
exit trap: exit trap:
stopping the p4 server stopping the p4 server