This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1000

contrib: add check-code rule banning use of readlink
ClosedPublic

Authored by durin42 on Oct 10 2017, 11:04 AM.

Details

Reviewers
quark
ryanmce
Group Reviewers
hg-reviewers
Commits
rHG3e4b7861c1c5: contrib: add check-code rule banning use of readlink
rHGa22fe0662f2f: contrib: add check-code rule banning use of readlink
rHGac80a8d105ec: contrib: add check-code rule banning use of readlink
Summary

readlink doesn't always exist, such as on Solaris-derived platforms.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 10 2017, 11:04 AM
quark accepted this revision.Oct 10 2017, 2:52 PM
quark added a subscriber: quark.

LGTM.

ryanmce accepted this revision.Oct 11 2017, 4:58 AM
ryanmce added a subscriber: ryanmce.

queued

This revision is now accepted and ready to land.Oct 11 2017, 4:58 AM
Closed by commit rHGac80a8d105ec: contrib: add check-code rule banning use of readlink (authored by durin42). · Explain WhyOct 11 2017, 5:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (1 line)

Diff 2578

contrib/check-code.py

(r'^ [^$>].*27\.0\.0\.1', (r'^ [^$>].*27\.0\.0\.1',
'use $LOCALIP not an explicit loopback address'), 'use $LOCALIP not an explicit loopback address'),
(r'^ [^$>].*\$LOCALIP.*[^)]$', (r'^ [^$>].*\$LOCALIP.*[^)]$',
'mark $LOCALIP output lines with (glob) to help tests in BSD jails'), 'mark $LOCALIP output lines with (glob) to help tests in BSD jails'),
(r'^ (cat|find): .*: No such file or directory', (r'^ (cat|find): .*: No such file or directory',
'use test -f to test for file existence'), 'use test -f to test for file existence'),
(r'^ diff -[^ -]*p', (r'^ diff -[^ -]*p',
"don't use (external) diff with -p for portability"), "don't use (external) diff with -p for portability"),
(r' readlink ', 'use readlink.py instead of readlink'),
(r'^ [-+][-+][-+] .* [-+]0000 \(glob\)', (r'^ [-+][-+][-+] .* [-+]0000 \(glob\)',
"glob timezone field in diff output for portability"), "glob timezone field in diff output for portability"),
(r'^ @@ -[0-9]+ [+][0-9]+,[0-9]+ @@', (r'^ @@ -[0-9]+ [+][0-9]+,[0-9]+ @@',
"use '@@ -N* +N,n @@ (glob)' style chunk header for portability"), "use '@@ -N* +N,n @@ (glob)' style chunk header for portability"),
(r'^ @@ -[0-9]+,[0-9]+ [+][0-9]+ @@', (r'^ @@ -[0-9]+,[0-9]+ [+][0-9]+ @@',
"use '@@ -N,n +N* @@ (glob)' style chunk header for portability"), "use '@@ -N,n +N* @@ (glob)' style chunk header for portability"),
(r'^ @@ -[0-9]+ [+][0-9]+ @@', (r'^ @@ -[0-9]+ [+][0-9]+ @@',
"use '@@ -N* +N* @@ (glob)' style chunk header for portability"), "use '@@ -N* +N* @@ (glob)' style chunk header for portability"),