Page MenuHomePhabricator

tests: add a test to demonstrate a bug in `hg diff --git` (issue6486)
ClosedPublic

Authored by khanchi97 on Tue, Feb 16, 5:26 AM.

Details

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

khanchi97 created this revision.Tue, Feb 16, 5:26 AM
pulkit added a subscriber: pulkit.Tue, Feb 16, 6:42 AM

Nice differential number. Can you rebase these and send for stable branch instead?

Nice differential number. Can you rebase these and send for stable branch instead?

Sure. (I also noticed the differential number :D)

khanchi97 added a comment.EditedTue, Feb 16, 6:58 AM

I just phabsend after rebasing to stable but here in Phabricator UI, I still see the default branch. What's wrong? Is it just the UI issue?

I just phabsend after rebasing to stable but here in Phabricator UI, I still see the default branch. What's wrong? Is it just the UI issue?

Seems like a bug in phabsend to me.

Seems like a bug in phabsend to me.

Yeah, I think it's phabsend. I will look into it to see if it's a quick fix. For now, do you think I should abandon these and create new ones?

Seems like a bug in phabsend to me.

Yeah, I think it's phabsend. I will look into it to see if it's a quick fix. For now, do you think I should abandon these and create new ones?

You should be able to just rebase and phabsend again. The branch name in the UI is only cosmetic, but I'm assuming there are conflicts applying to stable.

Phabsend only sets the branch property when creating the differential. IDR if it was because the underlying API didn't support changing it on updates, or what. But feel encouraged to look into it.

FWIW, I've never had a patch fail to get the stable branch tag on Phab after a phabsend.

Phabsend only sets the branch property when creating the differential. IDR if it was because the underlying API didn't support changing it on updates, or what.

Does this mean now the only option is to abandon? Or you meant this only for the Phab UI?

FWIW, I've never had a patch fail to get the stable branch tag on Phab after a phabsend.

I see. Also, did you ever have a scenario where you first phabsend a rev from default branch, then rebased to stable and phabsend again?

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.