This is ported to Rust from mercurial/loggingutil.py.
The "builder" pattern is used to make it visible at call sites what the two
numeric parameters mean. In Python they might simply by keyword arguments.
Details
Details
- Reviewers
Alphare - Group Reviewers
hg-reviewers - Commits
- rHG1f55cd5b292f: rust: Add a log file rotation utility
rHG289cbad841bc: rust: Add a log file rotation utility
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Branch
- default
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
| rust/hg-core/src/logging.rs | ||
|---|---|---|
| 60 | Right, doesn't really matter. I wasn't sure of the behavior of the range operator when doing n..n. | |
Comment Actions
/!\ CI failed for this change after you last updated.
As a note to Simon: you should rely on Baymax to re-send your patches after the initial phabsend. Hopefully we can keep the CI happy and that works well. :)
Comment Actions
Alright, let’s try this: https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/18143
What’s a good workflow when I also have additional patches to add on top of the stack?
Comment Actions
Wait for the CI to finish, and phabsend your stack. No-ops will not trigger notifications. In an ideal world: don't use Phabricator... but that's still a ways out. ;)