Page MenuHomePhabricator

tags: update the hgtagsfnodes cache if invalid file nodes are found
AbandonedPublic

Authored by pulkit on Feb 17 2021, 2:44 PM.

Details

Reviewers
Alphare
marmoute
Group Reviewers
hg-reviewers
Summary

The cache update happens but it happens post calculation of alltags and hence we
still don't get correct list of tags in current run.
Next patch will try to fix this.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Feb 17 2021, 2:44 PM
Alphare requested changes to this revision.Feb 23 2021, 4:47 AM
Alphare added a subscriber: Alphare.

I'm waiting for the "next patch" mentioned in the commit message before this can be accepted, since the behavior changed from an abort to a silent omission of valid data, which is a regression.

mercurial/tags.py
205

This should probably be gated by the presence of invalidnodes to avoid a useless loop.

This revision now requires changes to proceed.Feb 23 2021, 4:47 AM
marmoute requested changes to this revision.
marmoute added a subscriber: marmoute.

Same feedback as @Alphare, what about the final fix ?

pulkit added a comment.Mar 1 2021, 1:54 PM

Superseeded by D10083.

pulkit planned changes to this revision.Mar 1 2021, 1:55 PM
pulkit abandoned this revision.Mar 9 2021, 2:15 AM