| Alphare |
| hg-reviewers |
If the cache is invalid, _readtagcache() can return data which has a wrong
filenode. We want to fix the cache in such cases by replacing the wrong filenode
with a correct one. To do so, first the callers need to be aware from
which cache values returned by this function are read.
This patch adds a new return value which depicts the source of data return from
_readtagcache().
| No Linters Available |
| No Unit Test Coverage |
| mercurial/tags.py | ||
|---|---|---|
| 186–188 | small nits: I would probably use 2 explicit line for this instead of a "one-liner" spawning 3 line: cache_values = _readtagcache(ui, repo) (heads, tagfnode, valid, cachetags, shouldwrite, source) = cache_values | |
| 409–413 | what does this mean if "the cache data is read from hgtagsfnodes" ? Does this always result in cachetags being None ? | |