Differential D10015

debugtagscache: verify that filenode is correct
Needs ReviewPublic
Actions

Authored by pulkit on Wed, Feb 17, 2:44 PM.

Tags

None

Subscribers

marmoute, mercurial-patches

Details

Reviewers

Alphare
marmoute

Group Reviewers

Summary

Previous patch from Matt demonstrates that debugtagscache does not warn about
filenode being unknown which can be caused by a corrupted cache.

We start by showing that it's an unknown node.

Diff Detail

Repository

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

pulkit created this revision.Wed, Feb 17, 2:44 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptWed, Feb 17, 2:44 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

pulkit added a child revision: D10016: tags: return tag cache source from _readtagcache().Wed, Feb 17, 2:44 PM

Alphare accepted this revision.Tue, Feb 23, 4:33 AM

What is an "invalid" node?

This revision now requires changes to proceed.Mon, Mar 1, 3:55 AM

pulkit edited the summary of this revision. (Show Details)Mon, Mar 1, 1:47 PM

pulkit added a child revision: D10083: tags: validate nodes in _getfnodes() and update cache in case of unknown nodes.

pulkit updated this revision to Diff 26005.

pulkit removed a child revision: D10016: tags: return tag cache source from _readtagcache().Mon, Mar 1, 1:55 PM

Revision Contents
Changeset List

			Path	Packages
M			mercurial/debugcommands.py (4 lines)
M			tests/test-tags.t (4 lines)

Diff 26005

mercurial/debugcommands.py

Loading...

tests/test-tags.t

Loading...