error: remove shortening of node in error message
Needs ReviewPublic
Actions

Authored by pulkit on Mon, Feb 15, 7:19 AM.

Details

Reviewers

durin42
Alphare
marmoute

Group Reviewers

hg-reviewers

Summary

This strips the complete 20 bytes node which was not found. Having the the full
node in error message is important as it makes debugging easier.

If a short node is to be displayed, that should be done by callers.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

pulkit created this revision.Mon, Feb 15, 7:19 AM

Herald added a reviewer: durin42. · View Herald TranscriptMon, Feb 15, 7:19 AM

Herald added a reviewer: hg-reviewers. · View Herald Transcript

Herald added a subscriber: mercurial-patches. · View Herald Transcript

pulkit edited the summary of this revision. (Show Details)Tue, Feb 16, 2:52 AM

pulkit added a child revision: D10013: hgtagsfnodes: refactor code to compute fnode into separate fn.Wed, Feb 17, 2:43 PM

Ping for review on the series.

Alphare accepted this revision.Tue, Feb 23, 4:14 AM

+1 on this, such error don't happens on "normal" operation, they are mostly the result of store or cache corruption, or user error when using advanced debug command. So having as much information as possible available is a big plus.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/error.py (4 lines)
M			tests/test-bundle-r.t (2 lines)
M			tests/test-bundle.t (2 lines)
M			tests/test-convert-filemap.t (6 lines)
M			tests/test-convert-hg-source.t (2 lines)
M			tests/test-hgweb-filelog.t (2 lines)
M			tests/test-hgweb.t (6 lines)
M			tests/test-hgwebdir.t (2 lines)
M			tests/test-narrow-exchange.t (6 lines)
M			tests/test-pull-bundle.t (2 lines)

Commit	Parents	Author	Summary	Date
801e6ed82f3d	87f8b3add56b	Pulkit Goyal		Wed, Feb 10, 6:54 AM

Status	Author	Revision
Needs Review	pulkit	D10083 tags: validate nodes in _getfnodes() and update cache in case of unknown nodes
Needs Review	pulkit	D10015 debugtagscache: verify that filenode is correct
Needs Review	mharbison72	D9812 tests: demonstrate a case where a corrupt tag cache causes an abort
Needs Review	pulkit	D10014 debugcommands: prevent using `is False`
Needs Review	pulkit	D10013 hgtagsfnodes: refactor code to compute fnode into separate fn
Needs Review	pulkit	D9994 error: remove shortening of node in error message