Page MenuHomePhabricator

error: remove shortening of node in error message
Needs ReviewPublic

Authored by pulkit on Mon, Feb 15, 7:19 AM.

Details

Reviewers
durin42
Alphare
marmoute
Group Reviewers
hg-reviewers
Summary

This strips the complete 20 bytes node which was not found. Having the the full
node in error message is important as it makes debugging easier.

If a short node is to be displayed, that should be done by callers.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Mon, Feb 15, 7:19 AM
pulkit edited the summary of this revision. (Show Details)Tue, Feb 16, 2:52 AM

Ping for review on the series.

Alphare accepted this revision.Tue, Feb 23, 4:14 AM
marmoute accepted this revision.Mon, Mar 1, 3:49 AM
marmoute added a subscriber: marmoute.

+1 on this, such error don't happens on "normal" operation, they are mostly the result of store or cache corruption, or user error when using advanced debug command. So having as much information as possible available is a big plus.