( )⚙ D10144 rhg: Fall back to Python for --version

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10144

rhg: Fall back to Python for --version
ClosedPublic

Authored by SimonSapin on Mar 9 2021, 4:41 AM.

Download Raw Diff

Tags

None

Subscribers

mercurial-patches

Details

Reviewers

marmoute
Alphare

Group Reviewers

Commits

rHGeb14264b98e8: rhg: Fall back to Python for --version

Summary

Clap has some built-in support for printing something on --version,
but it looks different than what Pytho-based hg does.

Also, at the moment we’re not giving version numbers to rhg
separate from the Mercurial version.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Mar 9 2021, 4:41 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptMar 9 2021, 4:41 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

SimonSapin added a child revision: D10145: rhg: Return an error code for `rhg config Section.idontexist`.Mar 9 2021, 4:41 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute accepted this revision.Mar 9 2021, 1:26 PM

Alphare accepted this revision.Mar 10 2021, 4:25 AM

SimonSapin edited the summary of this revision. (Show Details)Mar 12 2021, 5:08 PM

SimonSapin updated this revision to Diff 26302.

✅ refresh by Heptapod after a successful CI run (🐙 💚)

SimonSapin added a commit: rHGeb14264b98e8: rhg: Fall back to Python for --version.Mar 16 2021, 5:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHGeb14264b98e8: rhg: Fall back to Python for --version (authored by SimonSapin). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			rust/rhg/src/main.rs (1 line)

Diff 26427

rust/rhg/src/main.rs

	ui: &ui::Ui,			ui: &ui::Ui,
	repo: Result<&Repo, &NoRepoInCwdError>,			repo: Result<&Repo, &NoRepoInCwdError>,
	config: &Config,			config: &Config,
	) -> Result<(), CommandError> {			) -> Result<(), CommandError> {
	check_extensions(config)?;			check_extensions(config)?;

	let app = App::new("rhg")			let app = App::new("rhg")
	.global_setting(AppSettings::AllowInvalidUtf8)			.global_setting(AppSettings::AllowInvalidUtf8)
				.global_setting(AppSettings::DisableVersion)
	.setting(AppSettings::SubcommandRequired)			.setting(AppSettings::SubcommandRequired)
	.setting(AppSettings::VersionlessSubcommands)			.setting(AppSettings::VersionlessSubcommands)
	.arg(			.arg(
	Arg::with_name("repository")			Arg::with_name("repository")
	.help("repository root directory")			.help("repository root directory")
	.short("-R")			.short("-R")
	.long("--repository")			.long("--repository")
	.value_name("REPO")			.value_name("REPO")