This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10151

revlog: add attribute on revlogs that specifies its kind
ClosedPublic

Authored by Alphare on Mar 10 2021, 1:36 PM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHGf63299ee7e4d: revlog: add attribute on revlogs that specifies its kind
Summary

The sidedata logic needs to check whether the revlog it's working on is a
changelog, a manifest or a filelog.
Furthermore, future versions of the revlog format will most likely see a split
between the three types (i.e. they will store different information), so having
this will be useful for other future endeavors as well.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Mar 10 2021, 1:36 PM
marmoute accepted this revision.Mar 11 2021, 1:14 PM
Alphare added a commit: rHGf63299ee7e4d: revlog: add attribute on revlogs that specifies its kind.Mar 15 2021, 2:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGf63299ee7e4d: revlog: add attribute on revlogs that specifies its kind (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (1 line)
Mmercurial/filelog.py (1 line)
Mmercurial/manifest.py (1 line)

Diff 26380

mercurial/changelog.py

self._realopener = opener self._realopener = opener
self._delayed = False self._delayed = False
self._delaybuf = None self._delaybuf = None
self._divert = False self._divert = False
self._filteredrevs = frozenset() self._filteredrevs = frozenset()
self._filteredrevs_hashcache = {} self._filteredrevs_hashcache = {}
self._copiesstorage = opener.options.get(b'copies-storage') self._copiesstorage = opener.options.get(b'copies-storage')
self.revlog_kind = b'changelog'
@property @property
def filteredrevs(self): def filteredrevs(self):
return self._filteredrevs return self._filteredrevs
@filteredrevs.setter @filteredrevs.setter
def filteredrevs(self, val): def filteredrevs(self, val):
# Ensure all updates go through this function # Ensure all updates go through this function

mercurial/filelog.py

class filelog(object): class filelog(object):
def __init__(self, opener, path): def __init__(self, opener, path):
self._revlog = revlog.revlog( self._revlog = revlog.revlog(
opener, b'/'.join((b'data', path + b'.i')), censorable=True opener, b'/'.join((b'data', path + b'.i')), censorable=True
) )
# Full name of the user visible file, relative to the repository root. # Full name of the user visible file, relative to the repository root.
# Used by LFS. # Used by LFS.
self._revlog.filename = path self._revlog.filename = path
self._revlog.revlog_kind = b'filelog'
def __len__(self): def __len__(self):
return len(self._revlog) return len(self._revlog)
def __iter__(self): def __iter__(self):
return self._revlog.__iter__() return self._revlog.__iter__()
def hasnode(self, node): def hasnode(self, node):

mercurial/manifest.py

mmaplargeindex=True, mmaplargeindex=True,
upperboundcomp=MAXCOMPRESSION, upperboundcomp=MAXCOMPRESSION,
persistentnodemap=opener.options.get(b'persistent-nodemap', False), persistentnodemap=opener.options.get(b'persistent-nodemap', False),
) )
self.index = self._revlog.index self.index = self._revlog.index
self.version = self._revlog.version self.version = self._revlog.version
self._generaldelta = self._revlog._generaldelta self._generaldelta = self._revlog._generaldelta
self._revlog.revlog_kind = b'manifest'
def _setupmanifestcachehooks(self, repo): def _setupmanifestcachehooks(self, repo):
"""Persist the manifestfulltextcache on lock release""" """Persist the manifestfulltextcache on lock release"""
if not util.safehasattr(repo, b'_wlockref'): if not util.safehasattr(repo, b'_wlockref'):
return return
self._fulltextcache._opener = repo.wcachevfs self._fulltextcache._opener = repo.wcachevfs
if repo._currentlock(repo._wlockref) is None: if repo._currentlock(repo._wlockref) is None: