This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10151

revlog: add attribute on revlogs that specifies its kind
ClosedPublic

Authored by Alphare on Mar 10 2021, 1:36 PM.

Download Raw Diff

Details

Reviewers

marmoute

Group Reviewers

hg-reviewers

Commits

rHGf63299ee7e4d: revlog: add attribute on revlogs that specifies its kind

Summary

The sidedata logic needs to check whether the revlog it's working on is a
changelog, a manifest or a filelog.
Furthermore, future versions of the revlog format will most likely see a split
between the three types (i.e. they will store different information), so having
this will be useful for other future endeavors as well.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Mar 10 2021, 1:36 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptMar 10 2021, 1:36 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

Alphare added a parent revision: D10028: sidedata-exchange: add `wanted_sidedata` and `sidedata_computers` to repos.Mar 10 2021, 1:36 PM

Alphare added a child revision: D10029: changegroupv4: add sidedata helpers.

marmoute accepted this revision.Mar 11 2021, 1:14 PM

Alphare added a commit: rHGf63299ee7e4d: revlog: add attribute on revlogs that specifies its kind.Mar 15 2021, 2:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHGf63299ee7e4d: revlog: add attribute on revlogs that specifies its kind (authored by Alphare). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/changelog.py (1 line)
M			mercurial/filelog.py (1 line)
M			mercurial/manifest.py (1 line)

Status	Author	Revision
Closed	Alphare	D10106 requirements: also add a generaldelta constant
Closed	Alphare	D10105 requirements: add constant for revlog v1 requirement
Closed	Alphare	D10024 error: add `hint` attribute to `SidedataHashError`
Closed	Alphare	D10023 changegroup: use the local variable instead of reaching through self
Closed	Alphare	D10216 configitems: add TODOs blocking the move out of experimental for revlogv2
Closed	Alphare	D10032 sidedata-exchange: rewrite sidedata on-the-fly whenever possible
Closed	Alphare	D10031 revlog-index: add `replace_sidedata_info` method
Closed	Alphare	D10030 revlogv2: temporarily forbid inline revlogs
Closed	Alphare	D10029 changegroupv4: add sidedata helpers
Closed	Alphare	D10151 revlog: add attribute on revlogs that specifies its kind
Closed	Alphare	D10028 sidedata-exchange: add `wanted_sidedata` and `sidedata_computers` to repos
Closed	Alphare	D10027 delta: add sidedata field to revision delta
Closed	Alphare	D10026 changegroup: add v4 changegroup for revlog v2 exchange
Closed	Alphare	D10025 revlogv2: don't assume that the sidedata of the last rev is right after data
Closed	Alphare	D9993 sidedata: move to new sidedata storage in revlogv2
Closed	Alphare	D9846 cext: add support for revlogv2
Closed	Alphare	D9845 bitmanipulation: add utils to read/write bigendian 64bit integers
Closed	Alphare	D10113 format: remove sidedata format variant
Closed	Alphare	D9844 revlogv2: allow upgrading to v2
Closed	Alphare	D9843 revlog: introduce v2 format
Closed	Alphare	D10109 requirements: also add a fncache constant
Closed	Alphare	D10108 requirements: also add a store constant
Closed	Alphare	D10107 requirements: also add a dotencode constant
Closed	Alphare	D10104 pure-parsers: document index class constants

Diff 26380

mercurial/changelog.py


	self._realopener = opener			self._realopener = opener
	self._delayed = False			self._delayed = False
	self._delaybuf = None			self._delaybuf = None
	self._divert = False			self._divert = False
	self._filteredrevs = frozenset()			self._filteredrevs = frozenset()
	self._filteredrevs_hashcache = {}			self._filteredrevs_hashcache = {}
	self._copiesstorage = opener.options.get(b'copies-storage')			self._copiesstorage = opener.options.get(b'copies-storage')
				self.revlog_kind = b'changelog'

	@property			@property
	def filteredrevs(self):			def filteredrevs(self):
	return self._filteredrevs			return self._filteredrevs

	@filteredrevs.setter			@filteredrevs.setter
	def filteredrevs(self, val):			def filteredrevs(self, val):
	# Ensure all updates go through this function			# Ensure all updates go through this function

mercurial/filelog.py

	class filelog(object):			class filelog(object):
	def __init__(self, opener, path):			def __init__(self, opener, path):
	self._revlog = revlog.revlog(			self._revlog = revlog.revlog(
	opener, b'/'.join((b'data', path + b'.i')), censorable=True			opener, b'/'.join((b'data', path + b'.i')), censorable=True
	)			)
	# Full name of the user visible file, relative to the repository root.			# Full name of the user visible file, relative to the repository root.
	# Used by LFS.			# Used by LFS.
	self._revlog.filename = path			self._revlog.filename = path
				self._revlog.revlog_kind = b'filelog'

	def __len__(self):			def __len__(self):
	return len(self._revlog)			return len(self._revlog)

	def __iter__(self):			def __iter__(self):
	return self._revlog.__iter__()			return self._revlog.__iter__()

	def hasnode(self, node):			def hasnode(self, node):

mercurial/manifest.py

	mmaplargeindex=True,			mmaplargeindex=True,
	upperboundcomp=MAXCOMPRESSION,			upperboundcomp=MAXCOMPRESSION,
	persistentnodemap=opener.options.get(b'persistent-nodemap', False),			persistentnodemap=opener.options.get(b'persistent-nodemap', False),
	)			)

	self.index = self._revlog.index			self.index = self._revlog.index
	self.version = self._revlog.version			self.version = self._revlog.version
	self._generaldelta = self._revlog._generaldelta			self._generaldelta = self._revlog._generaldelta
				self._revlog.revlog_kind = b'manifest'

	def _setupmanifestcachehooks(self, repo):			def _setupmanifestcachehooks(self, repo):
	"""Persist the manifestfulltextcache on lock release"""			"""Persist the manifestfulltextcache on lock release"""
	if not util.safehasattr(repo, b'_wlockref'):			if not util.safehasattr(repo, b'_wlockref'):
	return			return

	self._fulltextcache._opener = repo.wcachevfs			self._fulltextcache._opener = repo.wcachevfs
	if repo._currentlock(repo._wlockref) is None:			if repo._currentlock(repo._wlockref) is None:

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	26212		Mar 10 2021, 1:35 PM	★	★
Diff 2	26380	rHGf63299ee7e4d9bc817dac2edeae7725766dbd0cc	Mar 10 2021, 1:33 PM	★	★