( )⚙ D10167 typing: switch an argument type to the generic form

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10167

typing: switch an argument type to the generic form
ClosedPublic

Authored by mharbison72 on Mar 12 2021, 1:08 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8f8fce2dd594: typing: switch an argument type to the generic form
Summary

This fixes the following pytype complaint:

File "/mnt/c/Users/Matt/hg/mercurial/commands.py", line 4672, in log: Function mercurial.logcmdutil.parseopts was called with the wrong arguments [wrong-arg-types]
         Expected: (ui, pats: List[Union[bytearray, bytes, memoryview]], ...)
  Actually passed: (ui, pats: tuple, ...)

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/logcmdutil.py (3 lines)

Diff 26264

mercurial/logcmdutil.py

if pycompat.TYPE_CHECKING: if pycompat.TYPE_CHECKING:
from typing import ( from typing import (
Any, Any,
Callable, Callable,
Dict, Dict,
List, List,
Optional, Optional,
Sequence,
Tuple, Tuple,
) )
for t in (Any, Callable, Dict, List, Optional, Tuple): for t in (Any, Callable, Dict, List, Optional, Tuple):
assert t assert t
def getlimit(opts): def getlimit(opts):
# sort revisions prior to traversal: 'desc', 'topo', or None # sort revisions prior to traversal: 'desc', 'topo', or None
sort_revisions = attr.ib(default=None) # type: Optional[bytes] sort_revisions = attr.ib(default=None) # type: Optional[bytes]
# limit number of changes displayed; None means unlimited # limit number of changes displayed; None means unlimited
limit = attr.ib(default=None) # type: Optional[int] limit = attr.ib(default=None) # type: Optional[int]
def parseopts(ui, pats, opts): def parseopts(ui, pats, opts):
# type: (Any, List[bytes], Dict[bytes, Any]) -> walkopts # type: (Any, Sequence[bytes], Dict[bytes, Any]) -> walkopts
"""Parse log command options into walkopts """Parse log command options into walkopts
The returned walkopts will be passed in to getrevs() or makewalker(). The returned walkopts will be passed in to getrevs() or makewalker().
""" """
if opts.get(b'follow_first'): if opts.get(b'follow_first'):
follow = 1 follow = 1
elif opts.get(b'follow'): elif opts.get(b'follow'):
follow = 2 follow = 2