( )⚙ D10188 rhg: Add an allow-list of ignored extensions

This is an archive of the discontinued Mercurial Phabricator instance.

rhg: Add an allow-list of ignored extensions
ClosedPublic

Authored by SimonSapin on Mar 12 2021, 5:07 PM.

Details

Summary

Because rhg doesn’t know how a Python extension would affect
behavior it implements in Rust, when an unsupported extension
is enabled it conservatively falls back to Python-based hg.

However many users will have unsupported extensions enabled in practice.
Maybe they don’t actually affect rhg behavior, but we don’t know.
This adds a rhg.ignored-extensions configuration that lets
users list extensions that rhg can safely ignore and proceed even
if they’re not supported in Rust.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

SimonSapin created this revision.Mar 12 2021, 5:07 PM
marmoute accepted this revision.Mar 15 2021, 5:41 AM
marmoute added a subscriber: marmoute.

Looks good, with a small comment on the hint style that we can follow up on.

rust/rhg/src/main.rs
381

Maybe put the hint in (…) as we do for other hint in Mercurial.
(and maybe most this to an explicite hint attribute.

baymax updated this revision to Diff 26338.Mar 15 2021, 9:10 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.