This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10201

bisect: replace a missing method on the list primitive
ClosedPublic

Authored by mharbison72 on Mar 13 2021, 2:33 PM.

Download Raw Diff

Details

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

rHG184e0ae0a4b2: bisect: replace a missing method on the list primitive

Summary

Caught by pytype:

File "/mnt/c/Users/Matt/hg/mercurial/commands.py", line 1095, in bisect: No attribute 'last' on list [attribute-error]
  In list

Diff Detail

Repository

rHG Mercurial

Branch

stable

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Mar 13 2021, 2:33 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptMar 13 2021, 2:33 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

mharbison72 added a child revision: D10202: crecord: change str literals to byte literals.Mar 13 2021, 2:33 PM

pulkit accepted this revision.Mar 17 2021, 4:56 AM

This revision is now accepted and ready to land.Mar 17 2021, 4:56 AM

mharbison72 added a commit: rHG184e0ae0a4b2: bisect: replace a missing method on the list primitive.Mar 17 2021, 6:12 AM

Closed by commit rHG184e0ae0a4b2: bisect: replace a missing method on the list primitive (authored by mharbison72). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/commands.py (2 lines)

Commit	Parents	Author	Summary	Date
291fa7370057	2a1c7a5d527b	Matt Harbison		Mar 12 2021, 5:59 PM

Status	Author	Revision
Closed	mharbison72	D10215 typing: rewrite a conditional assignment to unconfuse pytype
Closed	mharbison72	D10214 typing: add assertions to localrepo.py to appease pytype
Closed	mharbison72	D10213 obsutil: maintain a homogenous list when computing successors
Closed	mharbison72	D10212 typing: add an assertion to verify.py to appease pytype
Closed	mharbison72	D10211 typing: add an assertion to mercurial/hgweb/webcommands.py to help pytype
Closed	mharbison72	D10210 crecord: null out the curses attribute with `None` on failure to import
Closed	mharbison72	D10209 typing: fix directives mangled by black
Closed	mharbison72	D10208 typing: disable module attribute warnings for properly conditionalized code
Closed	mharbison72	D10207 typing: disable import error warnings that are already handled
Closed	mharbison72	D10206 typing: disable a few errors when accessing Windows specific attributes
Closed	mharbison72	D10205 typing: disable a few errors calling py3.7+ functions in resourceutil.py
Closed	mharbison72	D10204 wsgicgi: switch the default PATH_INFO back to str
Closed	mharbison72	D10203 crecord: convert an instance of bytes to str
Closed	mharbison72	D10202 crecord: change str literals to byte literals
Closed	mharbison72	D10201 bisect: replace a missing method on the list primitive
Closed	mharbison72	D10183 typing: disable a module-attr warning in the worker module's py2 code
Closed	mharbison72	D10182 wireprotoserver: convert ErrorResponse to bytes
Closed	mharbison72	D10181 verify: convert an exception to bytes before logging
Closed	mharbison72	D10180 typing: add an assertion to the upgrade engine to help pytype
Closed	mharbison72	D10179 subrepo: handle unexpected file types from git gracefully
Closed	mharbison72	D10178 patch: convert a UI message to bytes when editing a patch
Closed	mharbison72	D10177 merge: force an exception message to bytes before printing as a warning
Closed	mharbison72	D10176 hg: convert an exception to bytes in the repo creation exception handler
Closed	mharbison72	D10175 typing: add an assertion instead of blacklisting mercurial/extensions.py
Closed	mharbison72	D10174 debug: convert a few exceptions to bytes before wrapping in another error
Closed	mharbison72	D10173 grep: convert an exception to bytes for a warning message
Closed	mharbison72	D10172 morestatus: convert a UI message about merge conflicts to bytes
Closed	mharbison72	D10171 changegroup: convert a warning message to bytes
Closed	mharbison72	D10170 branchmap: force Exception to bytes before logging
Closed	mharbison72	D10169 nodemap: convert error message to bytes
Closed	mharbison72	D10168 mail: convert SMTPException to bytes before passing to error.Abort()
Closed	mharbison72	D10167 typing: switch an argument type to the generic form
Closed	mharbison72	D10166 typing: ensure that error.Abort is given bytes
Closed	mharbison72	D10165 typing: fix a suppression directive that was mangled by black formatting

Diff 26315

mercurial/commands.py

	)			)
	else:			else:
	node, p2 = repo.dirstate.parents()			node, p2 = repo.dirstate.parents()
	if p2 != nullid:			if p2 != nullid:
	raise error.StateError(_(b'current bisect revision is a merge'))			raise error.StateError(_(b'current bisect revision is a merge'))
	if rev:			if rev:
	if not nodes:			if not nodes:
	raise error.Abort(_(b'empty revision set'))			raise error.Abort(_(b'empty revision set'))
	node = repo[nodes.last()].node()			node = repo[nodes[-1]].node()
	with hbisect.restore_state(repo, state, node):			with hbisect.restore_state(repo, state, node):
	while changesets:			while changesets:
	# update state			# update state
	state[b'current'] = [node]			state[b'current'] = [node]
	hbisect.save_state(repo, state)			hbisect.save_state(repo, state)
	status = ui.system(			status = ui.system(
	command,			command,
	environ={b'HG_NODE': hex(node)},			environ={b'HG_NODE': hex(node)},

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	26315		Mar 13 2021, 2:33 PM	★	★
Diff 2	26474	rHG184e0ae0a4b261cf28bc019bc823837399a1f80c	Mar 12 2021, 5:59 PM	★	★