( )⚙ D10208 typing: disable module attribute warnings for properly conditionalized code

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10208

typing: disable module attribute warnings for properly conditionalized code
ClosedPublic

Authored by mharbison72 on Mar 13 2021, 2:33 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG52528570312e: typing: disable module attribute warnings for properly conditionalized code

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/dispatch.py (4 lines)
Mmercurial/pure/osutil.py (6 lines)
Mmercurial/sslutil.py (2 lines)

Diff 26322

mercurial/dispatch.py

if sys.stdout is not None: if sys.stdout is not None:
# write_through is new in Python 3.7. # write_through is new in Python 3.7.
kwargs = { kwargs = {
"newline": "\n", "newline": "\n",
"line_buffering": sys.stdout.line_buffering, "line_buffering": sys.stdout.line_buffering,
} }
if util.safehasattr(sys.stdout, "write_through"): if util.safehasattr(sys.stdout, "write_through"):
# pytype: disable=attribute-error
kwargs["write_through"] = sys.stdout.write_through kwargs["write_through"] = sys.stdout.write_through
# pytype: enable=attribute-error
sys.stdout = io.TextIOWrapper( sys.stdout = io.TextIOWrapper(
sys.stdout.buffer, sys.stdout.buffer,
sys.stdout.encoding, sys.stdout.encoding,
sys.stdout.errors, sys.stdout.errors,
**kwargs **kwargs
) )
if sys.stderr is not None: if sys.stderr is not None:
kwargs = { kwargs = {
"newline": "\n", "newline": "\n",
"line_buffering": sys.stderr.line_buffering, "line_buffering": sys.stderr.line_buffering,
} }
if util.safehasattr(sys.stderr, "write_through"): if util.safehasattr(sys.stderr, "write_through"):
# pytype: disable=attribute-error
kwargs["write_through"] = sys.stderr.write_through kwargs["write_through"] = sys.stderr.write_through
# pytype: enable=attribute-error
sys.stderr = io.TextIOWrapper( sys.stderr = io.TextIOWrapper(
sys.stderr.buffer, sys.stderr.buffer,
sys.stderr.encoding, sys.stderr.encoding,
sys.stderr.errors, sys.stderr.errors,
**kwargs **kwargs
) )
if sys.stdin is not None: if sys.stdin is not None:

mercurial/pure/osutil.py

cmsg.cmsg_len - _cmsghdr.cmsg_data.offset cmsg.cmsg_len - _cmsghdr.cmsg_data.offset
) // ctypes.sizeof(ctypes.c_int) ) // ctypes.sizeof(ctypes.c_int)
return [rfds[i] for i in pycompat.xrange(rfdscount)] return [rfds[i] for i in pycompat.xrange(rfdscount)]
else: else:
import msvcrt import msvcrt
_kernel32 = ctypes.windll.kernel32 _kernel32 = ctypes.windll.kernel32 # pytype: disable=module-attr
_DWORD = ctypes.c_ulong _DWORD = ctypes.c_ulong
_LPCSTR = _LPSTR = ctypes.c_char_p _LPCSTR = _LPSTR = ctypes.c_char_p
_HANDLE = ctypes.c_void_p _HANDLE = ctypes.c_void_p
_INVALID_HANDLE_VALUE = _HANDLE(-1).value _INVALID_HANDLE_VALUE = _HANDLE(-1).value
# CreateFile # CreateFile
ctypes.c_void_p, ctypes.c_void_p,
_DWORD, _DWORD,
_DWORD, _DWORD,
_HANDLE, _HANDLE,
] ]
_kernel32.CreateFileA.restype = _HANDLE _kernel32.CreateFileA.restype = _HANDLE
def _raiseioerror(name): def _raiseioerror(name):
err = ctypes.WinError() err = ctypes.WinError() # pytype: disable=module-attr
raise IOError( raise IOError(
err.errno, '%s: %s' % (encoding.strfromlocal(name), err.strerror) err.errno, '%s: %s' % (encoding.strfromlocal(name), err.strerror)
) )
class posixfile(object): class posixfile(object):
"""a file object aiming for POSIX-like semantics """a file object aiming for POSIX-like semantics
CPython's open() returns a file that was opened *without* setting the CPython's open() returns a file that was opened *without* setting the
None, None,
creation, creation,
_FILE_ATTRIBUTE_NORMAL, _FILE_ATTRIBUTE_NORMAL,
None, None,
) )
if fh == _INVALID_HANDLE_VALUE: if fh == _INVALID_HANDLE_VALUE:
_raiseioerror(name) _raiseioerror(name)
fd = msvcrt.open_osfhandle(fh, flags) fd = msvcrt.open_osfhandle(fh, flags) # pytype: disable=module-attr
if fd == -1: if fd == -1:
_kernel32.CloseHandle(fh) _kernel32.CloseHandle(fh)
_raiseioerror(name) _raiseioerror(name)
f = os.fdopen(fd, pycompat.sysstr(mode), bufsize) f = os.fdopen(fd, pycompat.sysstr(mode), bufsize)
# unfortunately, f.name is '<fdopen>' at this point -- so we store # unfortunately, f.name is '<fdopen>' at this point -- so we store
# the name on this wrapper. We cannot just assign to f.name, # the name on this wrapper. We cannot just assign to f.name,
# because that attribute is read-only. # because that attribute is read-only.

mercurial/sslutil.py

# Improve forward secrecy. # Improve forward secrecy.
sslcontext.options |= getattr(ssl, 'OP_SINGLE_DH_USE', 0) sslcontext.options |= getattr(ssl, 'OP_SINGLE_DH_USE', 0)
sslcontext.options |= getattr(ssl, 'OP_SINGLE_ECDH_USE', 0) sslcontext.options |= getattr(ssl, 'OP_SINGLE_ECDH_USE', 0)
# Use the list of more secure ciphers if found in the ssl module. # Use the list of more secure ciphers if found in the ssl module.
if util.safehasattr(ssl, b'_RESTRICTED_SERVER_CIPHERS'): if util.safehasattr(ssl, b'_RESTRICTED_SERVER_CIPHERS'):
sslcontext.options |= getattr(ssl, 'OP_CIPHER_SERVER_PREFERENCE', 0) sslcontext.options |= getattr(ssl, 'OP_CIPHER_SERVER_PREFERENCE', 0)
# pytype: disable=module-attr
sslcontext.set_ciphers(ssl._RESTRICTED_SERVER_CIPHERS) sslcontext.set_ciphers(ssl._RESTRICTED_SERVER_CIPHERS)
# pytype: enable=module-attr
if requireclientcert: if requireclientcert:
sslcontext.verify_mode = ssl.CERT_REQUIRED sslcontext.verify_mode = ssl.CERT_REQUIRED
else: else:
sslcontext.verify_mode = ssl.CERT_NONE sslcontext.verify_mode = ssl.CERT_NONE
if certfile or keyfile: if certfile or keyfile:
sslcontext.load_cert_chain(certfile=certfile, keyfile=keyfile) sslcontext.load_cert_chain(certfile=certfile, keyfile=keyfile)